All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Parav Pandit <parav@nvidia.com>
Cc: virtio-comment@lists.oasis-open.org,
	virtio-dev@lists.oasis-open.org, jasowang@redhat.com,
	cohuck@redhat.com, sgarzare@redhat.com, stefanha@redhat.com,
	nrupal.jani@intel.com, Piotr.Uminski@intel.com,
	hang.yuan@intel.com, virtio@lists.oasis-open.org,
	Jiri Pirko <jiri@nvidia.com>,
	Zhu Lingshan <lingshan.zhu@intel.com>,
	pasic@linux.ibm.com, Shahaf Shuler <shahafs@nvidia.com>,
	Max Gurtovoy <mgurtovoy@nvidia.com>
Subject: [virtio-comment] Re: [PATCH v11 07/10] ccw: document ADMIN_VQ as reserved
Date: Mon, 3 Apr 2023 13:29:21 -0400	[thread overview]
Message-ID: <20230403132907-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <0fe1e488-a1e7-11a9-d2a2-3b8b7ee6a1c7@nvidia.com>

On Mon, Apr 03, 2023 at 11:55:29AM -0400, Parav Pandit wrote:
> 
> 
> On 4/3/2023 11:03 AM, Michael S. Tsirkin wrote:
> > Adding relevant registers needs more work and it's not
> > clear what the use-case will be as currently only
> > the PCI transport is supported. But let's keep the
> > door open on this.
> > We already say it's reserved in a central place, but it
> > does not hurt to remind implementers to mask it.
> > 
> s/implementers/implementation
> 
> > Note: there are more features to add to this list.
> > Will be done later with a patch on top.
> > 
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> > ---
> >   content.tex | 12 ++++++++++++
> >   1 file changed, 12 insertions(+)
> > 
> > diff --git a/content.tex b/content.tex
> > index f7446bf..1213d48 100644
> > --- a/content.tex
> > +++ b/content.tex
> > @@ -2978,6 +2978,18 @@ \subsubsection{Resetting Devices}\label{sec:Virtio Transport Options / Virtio ov
> >   MAY also choose to verify reset completion by reading \field{device status} via
> >   CCW_CMD_READ_STATUS and checking whether it is 0 afterwards.
> > +\subsection{Features reserved for future use}\label{sec:Virtio Transport Options / Virtio over channel I/O / Features reserved for future use}
> > +
> > +At this time, devices and drivers utilizing Virtio over channel I/O
> > +do not support the following features:
> > +\begin{itemize}
> > +
> > +\item VIRTIO_F_ADMIN_VQ
> > +
> > +\end{itemize}
> > +
> > +These features are reserved for future use.
> > +
> >   \chapter{Device Types}\label{sec:Device Types}
> >   On top of the queues, config space and feature negotiation facilities
> 
> Same nit as that of mmio.

Sorry I don't get what this refers to.

> Reviewed-by: Parav Pandit <parav@nvidia.com>


This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/


WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Parav Pandit <parav@nvidia.com>
Cc: virtio-comment@lists.oasis-open.org,
	virtio-dev@lists.oasis-open.org, jasowang@redhat.com,
	cohuck@redhat.com, sgarzare@redhat.com, stefanha@redhat.com,
	nrupal.jani@intel.com, Piotr.Uminski@intel.com,
	hang.yuan@intel.com, virtio@lists.oasis-open.org,
	Jiri Pirko <jiri@nvidia.com>,
	Zhu Lingshan <lingshan.zhu@intel.com>,
	pasic@linux.ibm.com, Shahaf Shuler <shahafs@nvidia.com>,
	Max Gurtovoy <mgurtovoy@nvidia.com>
Subject: [virtio-dev] Re: [PATCH v11 07/10] ccw: document ADMIN_VQ as reserved
Date: Mon, 3 Apr 2023 13:29:21 -0400	[thread overview]
Message-ID: <20230403132907-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <0fe1e488-a1e7-11a9-d2a2-3b8b7ee6a1c7@nvidia.com>

On Mon, Apr 03, 2023 at 11:55:29AM -0400, Parav Pandit wrote:
> 
> 
> On 4/3/2023 11:03 AM, Michael S. Tsirkin wrote:
> > Adding relevant registers needs more work and it's not
> > clear what the use-case will be as currently only
> > the PCI transport is supported. But let's keep the
> > door open on this.
> > We already say it's reserved in a central place, but it
> > does not hurt to remind implementers to mask it.
> > 
> s/implementers/implementation
> 
> > Note: there are more features to add to this list.
> > Will be done later with a patch on top.
> > 
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> > ---
> >   content.tex | 12 ++++++++++++
> >   1 file changed, 12 insertions(+)
> > 
> > diff --git a/content.tex b/content.tex
> > index f7446bf..1213d48 100644
> > --- a/content.tex
> > +++ b/content.tex
> > @@ -2978,6 +2978,18 @@ \subsubsection{Resetting Devices}\label{sec:Virtio Transport Options / Virtio ov
> >   MAY also choose to verify reset completion by reading \field{device status} via
> >   CCW_CMD_READ_STATUS and checking whether it is 0 afterwards.
> > +\subsection{Features reserved for future use}\label{sec:Virtio Transport Options / Virtio over channel I/O / Features reserved for future use}
> > +
> > +At this time, devices and drivers utilizing Virtio over channel I/O
> > +do not support the following features:
> > +\begin{itemize}
> > +
> > +\item VIRTIO_F_ADMIN_VQ
> > +
> > +\end{itemize}
> > +
> > +These features are reserved for future use.
> > +
> >   \chapter{Device Types}\label{sec:Device Types}
> >   On top of the queues, config space and feature negotiation facilities
> 
> Same nit as that of mmio.

Sorry I don't get what this refers to.

> Reviewed-by: Parav Pandit <parav@nvidia.com>


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


  reply	other threads:[~2023-04-03 17:29 UTC|newest]

Thread overview: 116+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-03 15:02 [virtio-comment] [PATCH v11 00/10] Introduce device group and device management Michael S. Tsirkin
2023-04-03 15:02 ` [virtio-dev] " Michael S. Tsirkin
2023-04-03 15:03 ` [virtio-comment] [PATCH v11 01/10] virtio: document forward compatibility guarantees Michael S. Tsirkin
2023-04-03 15:03   ` [virtio-dev] " Michael S. Tsirkin
2023-04-06  7:15   ` [virtio-comment] " Zhu, Lingshan
2023-04-06  7:15     ` [virtio-dev] " Zhu, Lingshan
2023-04-03 15:03 ` [virtio-comment] [PATCH v11 02/10] admin: introduce device group and related concepts Michael S. Tsirkin
2023-04-03 15:03   ` [virtio-dev] " Michael S. Tsirkin
2023-04-04 11:38   ` [virtio-comment] " Stefan Hajnoczi
2023-04-04 11:38     ` [virtio-dev] " Stefan Hajnoczi
2023-04-06  3:42   ` [virtio-comment] " Parav Pandit
2023-04-06  3:42     ` [virtio-dev] " Parav Pandit
2023-04-10 13:23     ` [virtio-comment] " Michael S. Tsirkin
2023-04-10 13:23       ` [virtio-dev] " Michael S. Tsirkin
2023-04-10 16:42       ` [virtio-comment] " Parav Pandit
2023-04-10 16:42         ` [virtio-dev] " Parav Pandit
2023-04-24 16:30         ` [virtio-comment] " Michael S. Tsirkin
2023-04-24 16:30           ` [virtio-dev] " Michael S. Tsirkin
2023-04-24 16:45           ` [virtio-comment] RE: [virtio] " Parav Pandit
2023-04-24 16:45             ` [virtio-dev] " Parav Pandit
2023-04-24 20:32             ` [virtio-comment] " Michael S. Tsirkin
2023-04-24 20:32               ` [virtio-dev] " Michael S. Tsirkin
2023-04-06  7:16   ` [virtio-comment] Re: [virtio-dev] " Zhu, Lingshan
2023-04-06  7:16     ` Zhu, Lingshan
2023-04-03 15:03 ` [virtio-comment] [PATCH v11 03/10] admin: introduce group administration commands Michael S. Tsirkin
2023-04-03 15:03   ` [virtio-dev] " Michael S. Tsirkin
2023-04-04 11:50   ` [virtio-comment] " Stefan Hajnoczi
2023-04-04 11:50     ` [virtio-dev] " Stefan Hajnoczi
2023-04-06  3:58   ` [virtio-comment] " Parav Pandit
2023-04-06  3:58     ` [virtio-dev] " Parav Pandit
2023-04-06  7:16   ` [virtio-comment] " Zhu, Lingshan
2023-04-06  7:16     ` [virtio-dev] " Zhu, Lingshan
2023-04-03 15:03 ` [virtio-comment] [PATCH v11 04/10] admin: introduce virtio admin virtqueues Michael S. Tsirkin
2023-04-03 15:03   ` [virtio-dev] " Michael S. Tsirkin
2023-04-04 11:58   ` [virtio-comment] " Stefan Hajnoczi
2023-04-04 11:58     ` [virtio-dev] " Stefan Hajnoczi
2023-04-06  4:08   ` [virtio-comment] " Parav Pandit
2023-04-06  4:08     ` [virtio-dev] " Parav Pandit
2023-04-10 13:22     ` [virtio-comment] " Michael S. Tsirkin
2023-04-10 13:22       ` [virtio-dev] " Michael S. Tsirkin
2023-04-10 14:22       ` [virtio-comment] " Parav Pandit
2023-04-10 14:22         ` [virtio-dev] " Parav Pandit
2023-04-10 20:04         ` [virtio-comment] " Michael S. Tsirkin
2023-04-10 20:04           ` [virtio-dev] " Michael S. Tsirkin
2023-04-11 13:39           ` [virtio-comment] " Parav Pandit
2023-04-11 13:39             ` [virtio-dev] " Parav Pandit
2023-04-11 14:01             ` [virtio-comment] " Michael S. Tsirkin
2023-04-11 14:01               ` [virtio-dev] " Michael S. Tsirkin
2023-04-11 15:46               ` [virtio-comment] " Parav Pandit
2023-04-11 15:46                 ` [virtio-dev] " Parav Pandit
2023-04-06  7:17   ` [virtio-comment] Re: [virtio-dev] " Zhu Lingshan
2023-04-06  7:17     ` Zhu Lingshan
2023-04-03 15:03 ` [virtio-comment] [PATCH v11 05/10] pci: add admin vq registers to virtio over pci Michael S. Tsirkin
2023-04-03 15:03   ` [virtio-dev] " Michael S. Tsirkin
2023-04-04 12:52   ` [virtio-comment] " Stefan Hajnoczi
2023-04-04 12:52     ` [virtio-dev] " Stefan Hajnoczi
2023-04-06  4:14   ` [virtio-comment] " Parav Pandit
2023-04-06  4:14     ` [virtio-dev] " Parav Pandit
2023-04-24 15:36     ` [virtio-comment] " Michael S. Tsirkin
2023-04-24 15:36       ` [virtio-dev] " Michael S. Tsirkin
2023-04-06  7:17   ` [virtio-comment] Re: [virtio] " Zhu, Lingshan
2023-04-06  7:17     ` [virtio-dev] " Zhu, Lingshan
2023-04-03 15:03 ` [virtio-comment] [PATCH v11 06/10] mmio: document ADMIN_VQ as reserved Michael S. Tsirkin
2023-04-03 15:03   ` [virtio-dev] " Michael S. Tsirkin
2023-04-03 15:54   ` [virtio-comment] " Parav Pandit
2023-04-03 15:54     ` [virtio-dev] " Parav Pandit
2023-04-24 15:38     ` [virtio-comment] " Michael S. Tsirkin
2023-04-24 15:38       ` [virtio-dev] " Michael S. Tsirkin
2023-04-06  7:18   ` [virtio-comment] " Zhu Lingshan
2023-04-06  7:18     ` [virtio-dev] " Zhu Lingshan
2023-04-03 15:03 ` [virtio-comment] [PATCH v11 07/10] ccw: " Michael S. Tsirkin
2023-04-03 15:03   ` [virtio-dev] " Michael S. Tsirkin
2023-04-03 15:55   ` [virtio-comment] " Parav Pandit
2023-04-03 15:55     ` [virtio-dev] " Parav Pandit
2023-04-03 17:29     ` Michael S. Tsirkin [this message]
2023-04-03 17:29       ` Michael S. Tsirkin
2023-04-06  4:15   ` [virtio-comment] " Parav Pandit
2023-04-06  4:15     ` [virtio-dev] " Parav Pandit
2023-04-06  7:18   ` [virtio-comment] Re: [virtio-dev] " Zhu Lingshan
2023-04-06  7:18     ` Zhu Lingshan
2023-04-03 15:03 ` [virtio-comment] [PATCH v11 08/10] admin: command list discovery Michael S. Tsirkin
2023-04-03 15:03   ` [virtio-dev] " Michael S. Tsirkin
2023-04-04 12:57   ` [virtio-comment] " Stefan Hajnoczi
2023-04-04 12:57     ` [virtio-dev] " Stefan Hajnoczi
2023-04-06  4:27   ` [virtio-comment] " Parav Pandit
2023-04-06  4:27     ` [virtio-dev] " Parav Pandit
2023-04-24 16:13     ` [virtio-comment] " Michael S. Tsirkin
2023-04-24 16:13       ` [virtio-dev] " Michael S. Tsirkin
2023-04-06  7:20   ` [virtio-comment] Re: [virtio-dev] " Zhu Lingshan
2023-04-06  7:20     ` Zhu Lingshan
2023-04-06 14:05     ` [virtio-comment] " Parav Pandit
2023-04-06 14:05       ` Parav Pandit
2023-04-07  2:01       ` [virtio-comment] " Zhu, Lingshan
2023-04-07  2:01         ` Zhu, Lingshan
2023-04-07  7:34       ` [virtio-comment] " Michael S. Tsirkin
2023-04-07  7:34         ` Michael S. Tsirkin
2023-04-03 15:03 ` [virtio-comment] [PATCH v11 09/10] admin: conformance clauses Michael S. Tsirkin
2023-04-03 15:03   ` [virtio-dev] " Michael S. Tsirkin
2023-04-04 13:03   ` [virtio-comment] " Stefan Hajnoczi
2023-04-04 13:03     ` [virtio-dev] " Stefan Hajnoczi
2023-04-06  7:30   ` [virtio-comment] Re: [virtio] " Zhu, Lingshan
2023-04-06  7:30     ` [virtio-dev] " Zhu, Lingshan
2023-04-24 16:17     ` [virtio-comment] " Michael S. Tsirkin
2023-04-24 16:17       ` [virtio-dev] " Michael S. Tsirkin
2023-04-03 15:04 ` [virtio-comment] [PATCH v11 10/10] ccw: document more reserved features Michael S. Tsirkin
2023-04-03 15:04   ` [virtio-dev] " Michael S. Tsirkin
2023-04-06  7:31   ` [virtio-comment] " Zhu Lingshan
2023-04-06  7:31     ` [virtio-dev] " Zhu Lingshan
2023-04-03 15:59 ` [virtio-comment] Re: [PATCH v11 00/10] Introduce device group and device management Parav Pandit
2023-04-03 15:59   ` [virtio-dev] " Parav Pandit
2023-04-03 16:39 ` [virtio-comment] " Cornelia Huck
2023-04-03 16:39   ` [virtio-dev] " Cornelia Huck
2023-04-03 17:31   ` [virtio-comment] " Michael S. Tsirkin
2023-04-03 17:31     ` [virtio-dev] " Michael S. Tsirkin
2023-04-04  8:10     ` [virtio-comment] " Cornelia Huck
2023-04-04  8:10       ` [virtio-dev] " Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230403132907-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=Piotr.Uminski@intel.com \
    --cc=cohuck@redhat.com \
    --cc=hang.yuan@intel.com \
    --cc=jasowang@redhat.com \
    --cc=jiri@nvidia.com \
    --cc=lingshan.zhu@intel.com \
    --cc=mgurtovoy@nvidia.com \
    --cc=nrupal.jani@intel.com \
    --cc=parav@nvidia.com \
    --cc=pasic@linux.ibm.com \
    --cc=sgarzare@redhat.com \
    --cc=shahafs@nvidia.com \
    --cc=stefanha@redhat.com \
    --cc=virtio-comment@lists.oasis-open.org \
    --cc=virtio-dev@lists.oasis-open.org \
    --cc=virtio@lists.oasis-open.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.