[PATCHv1 0/2] generic-ohci: increase allowed clocks

[PATCHv1 0/2] generic-ohci: increase allowed clocks

[Sebastian Reichel]

Hi,

This increases the max. allowed clocks for generic-ohci from 3 to 4.
On RK3588 a total of 4 clocks is required to access the OHCI registers.
Note, that EHCI already supports 4 clocks.

-- Sebastian

Sebastian Reichel (2):
  dt-bindings: usb: generic-ohci: increase allowed clocks
  usb: host: ohci-platform: increase max clock number to 4

 Documentation/devicetree/bindings/usb/generic-ohci.yaml | 2 +-
 drivers/usb/host/ohci-platform.c                        | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

-- 
2.39.2

[PATCHv1 1/2] dt-bindings: usb: generic-ohci: increase allowed clocks

[Sebastian Reichel]

Increase number of allowed clocks to 4, which is the number
required on Rockchip RK3588.

Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
---
 Documentation/devicetree/bindings/usb/generic-ohci.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/usb/generic-ohci.yaml b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
index a9ba7257b884..c0880d0664f1 100644
--- a/Documentation/devicetree/bindings/usb/generic-ohci.yaml
+++ b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
@@ -69,7 +69,7 @@ properties:
 
   clocks:
     minItems: 1
-    maxItems: 3
+    maxItems: 4
     description: |
       In case the Renesas R-Car Gen3 SoCs:
         - if a host only channel: first clock should be host.
-- 
2.39.2

Re: [PATCHv1 1/2] dt-bindings: usb: generic-ohci: increase allowed clocks

[Rob Herring]

On Fri, Mar 31, 2023 at 06:31:47PM +0200, Sebastian Reichel wrote:
> Increase number of allowed clocks to 4, which is the number
> required on Rockchip RK3588.

It was 3 because that's what crept in until we made a schema. Additions 
should really have a specific compatible and a conditional schema 
limiting that 4 clocks to that compatible.

> 
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> ---
>  Documentation/devicetree/bindings/usb/generic-ohci.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/generic-ohci.yaml b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
> index a9ba7257b884..c0880d0664f1 100644
> --- a/Documentation/devicetree/bindings/usb/generic-ohci.yaml
> +++ b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
> @@ -69,7 +69,7 @@ properties:
>  
>    clocks:
>      minItems: 1
> -    maxItems: 3
> +    maxItems: 4
>      description: |
>        In case the Renesas R-Car Gen3 SoCs:
>          - if a host only channel: first clock should be host.
> -- 
> 2.39.2
> 

[PATCHv1 2/2] usb: host: ohci-platform: increase max clock number to 4

[Sebastian Reichel]

Rockchip RK3588 OHCI requires 4 clocks to be enabled.

Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
---
 drivers/usb/host/ohci-platform.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/host/ohci-platform.c b/drivers/usb/host/ohci-platform.c
index a84305091c43..dec38a845cff 100644
--- a/drivers/usb/host/ohci-platform.c
+++ b/drivers/usb/host/ohci-platform.c
@@ -33,7 +33,7 @@
 #include "ohci.h"
 
 #define DRIVER_DESC "OHCI generic platform driver"
-#define OHCI_MAX_CLKS 3
+#define OHCI_MAX_CLKS 4
 #define hcd_to_ohci_priv(h) ((struct ohci_platform_priv *)hcd_to_ohci(h)->priv)
 
 struct ohci_platform_priv {
-- 
2.39.2

Re: [PATCHv1 0/2] generic-ohci: increase allowed clocks

[Alan Stern]

On Fri, Mar 31, 2023 at 06:31:46PM +0200, Sebastian Reichel wrote:
> Hi,
> 
> This increases the max. allowed clocks for generic-ohci from 3 to 4.
> On RK3588 a total of 4 clocks is required to access the OHCI registers.
> Note, that EHCI already supports 4 clocks.
> 
> -- Sebastian
> 
> Sebastian Reichel (2):
>   dt-bindings: usb: generic-ohci: increase allowed clocks
>   usb: host: ohci-platform: increase max clock number to 4
> 
>  Documentation/devicetree/bindings/usb/generic-ohci.yaml | 2 +-
>  drivers/usb/host/ohci-platform.c                        | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Acked-by: Alan Stern <stern@rowland.harvard.edu>