From: "Michael S. Tsirkin" <mst@redhat.com>
To: Parav Pandit <parav@nvidia.com>
Cc: Halil Pasic <pasic@linux.ibm.com>,
"virtio-dev@lists.oasis-open.org"
<virtio-dev@lists.oasis-open.org>,
"cohuck@redhat.com" <cohuck@redhat.com>,
"sgarzare@redhat.com" <sgarzare@redhat.com>,
"virtio-comment@lists.oasis-open.org"
<virtio-comment@lists.oasis-open.org>,
Shahaf Shuler <shahafs@nvidia.com>
Subject: [virtio-comment] Re: [virtio-dev] [PATCH v10 0/8] Rename queue index to queue number
Date: Tue, 4 Apr 2023 03:13:53 -0400 [thread overview]
Message-ID: <20230404030859-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <d62d2090-de0d-0ea6-5c85-ecf19ae828c7@nvidia.com>
On Mon, Apr 03, 2023 at 10:57:35PM -0400, Parav Pandit wrote:
> I see few options.
>
> Option_1:
> 1. I will send v12 of this series to use index all the places instead of
> number.
> 2. driver notification structure vqn to rename to vq_notify_id.
> (after merging this series as follow up cleanup).
We can pretend that vqn means "VQ Notification". Backronims are fun.
In fact it is not always a vq index, sometimes it's a different value.
So maybe keeping vqn there makes sense.
> 3. Once interrupt moderation series is merged, rename vqn to vq_index.
> (really vqn reads better even though history say vq index).
> Because votes is completed and voting period ended for the important
> feature.
It's ongoing but sure, we can do a fix up on top.
> 4. Michael send v12 with index.
Of AQ? Sure.
> Option_2:
> 1. Continue with the v11 of this series as vq number.
> 2. Continue with interrupt moderation series voted
> 3. Continue with Michael's work of AQ
> 4. Will do #2 of option_1.
>
> Please decide at earliest.
>
It looks like the sentiment is now going more option 1.
If you like post v12 and we'll see which gets more acks.
--
MST
This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.
In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.
Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Parav Pandit <parav@nvidia.com>
Cc: Halil Pasic <pasic@linux.ibm.com>,
"virtio-dev@lists.oasis-open.org"
<virtio-dev@lists.oasis-open.org>,
"cohuck@redhat.com" <cohuck@redhat.com>,
"sgarzare@redhat.com" <sgarzare@redhat.com>,
"virtio-comment@lists.oasis-open.org"
<virtio-comment@lists.oasis-open.org>,
Shahaf Shuler <shahafs@nvidia.com>
Subject: Re: [virtio-dev] [PATCH v10 0/8] Rename queue index to queue number
Date: Tue, 4 Apr 2023 03:13:53 -0400 [thread overview]
Message-ID: <20230404030859-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <d62d2090-de0d-0ea6-5c85-ecf19ae828c7@nvidia.com>
On Mon, Apr 03, 2023 at 10:57:35PM -0400, Parav Pandit wrote:
> I see few options.
>
> Option_1:
> 1. I will send v12 of this series to use index all the places instead of
> number.
> 2. driver notification structure vqn to rename to vq_notify_id.
> (after merging this series as follow up cleanup).
We can pretend that vqn means "VQ Notification". Backronims are fun.
In fact it is not always a vq index, sometimes it's a different value.
So maybe keeping vqn there makes sense.
> 3. Once interrupt moderation series is merged, rename vqn to vq_index.
> (really vqn reads better even though history say vq index).
> Because votes is completed and voting period ended for the important
> feature.
It's ongoing but sure, we can do a fix up on top.
> 4. Michael send v12 with index.
Of AQ? Sure.
> Option_2:
> 1. Continue with the v11 of this series as vq number.
> 2. Continue with interrupt moderation series voted
> 3. Continue with Michael's work of AQ
> 4. Will do #2 of option_1.
>
> Please decide at earliest.
>
It looks like the sentiment is now going more option 1.
If you like post v12 and we'll see which gets more acks.
--
MST
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2023-04-04 7:14 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 21:23 [virtio-comment] [PATCH v10 0/8] Rename queue index to queue number Parav Pandit
2023-03-29 21:23 ` [virtio-dev] " Parav Pandit
2023-03-29 21:23 ` [virtio-comment] [PATCH v10 1/8] content: Add vq number text Parav Pandit
2023-03-29 21:23 ` [virtio-dev] " Parav Pandit
2023-03-30 7:44 ` [virtio-comment] " Cornelia Huck
2023-03-30 7:44 ` [virtio-dev] " Cornelia Huck
2023-03-29 21:23 ` [virtio-comment] [PATCH v10 2/8] transport-pci: Refer to the vq by its number Parav Pandit
2023-03-29 21:23 ` [virtio-dev] " Parav Pandit
2023-03-30 17:10 ` [virtio-comment] " Halil Pasic
2023-03-30 17:10 ` [virtio-dev] " Halil Pasic
2023-03-30 19:00 ` Parav Pandit
2023-03-30 19:00 ` [virtio-dev] " Parav Pandit
2023-03-29 21:23 ` [virtio-comment] [PATCH v10 3/8] transport-mmio: Rename QueueNum register Parav Pandit
2023-03-29 21:23 ` [virtio-dev] " Parav Pandit
2023-03-29 21:23 ` [virtio-comment] [PATCH v10 4/8] transport-mmio: Refer to the vq by its number Parav Pandit
2023-03-29 21:23 ` [virtio-dev] " Parav Pandit
2023-03-29 21:23 ` [virtio-comment] [PATCH v10 5/8] transport-ccw: Rename queue depth/size to other transports Parav Pandit
2023-03-29 21:23 ` [virtio-dev] " Parav Pandit
2023-03-29 21:23 ` [virtio-comment] [PATCH v10 6/8] transport-ccw: Refer to the vq by its number Parav Pandit
2023-03-29 21:23 ` [virtio-dev] " Parav Pandit
2023-03-30 7:48 ` [virtio-comment] " Cornelia Huck
2023-03-30 7:48 ` [virtio-dev] " Cornelia Huck
2023-03-29 21:23 ` [virtio-comment] [PATCH v10 7/8] virtio-net: Avoid duplicate receive queue example Parav Pandit
2023-03-29 21:23 ` [virtio-dev] " Parav Pandit
2023-03-30 7:53 ` [virtio-comment] " Cornelia Huck
2023-03-30 7:53 ` [virtio-dev] " Cornelia Huck
2023-03-29 21:23 ` [virtio-comment] [PATCH v10 8/8] virtio-net: Describe RSS using rss rq id Parav Pandit
2023-03-29 21:23 ` [virtio-dev] " Parav Pandit
2023-03-30 9:17 ` [virtio-comment] " Cornelia Huck
2023-03-30 9:17 ` [virtio-dev] " Cornelia Huck
2023-04-03 22:29 ` [virtio-comment] " Parav Pandit
2023-04-03 22:29 ` [virtio-dev] " Parav Pandit
2023-04-04 8:15 ` [virtio-comment] " Cornelia Huck
2023-04-04 8:15 ` [virtio-dev] " Cornelia Huck
2023-04-04 16:11 ` Parav Pandit
2023-04-04 16:11 ` [virtio-dev] " Parav Pandit
2023-03-30 17:11 ` [virtio-comment] Re: [virtio-dev] [PATCH v10 0/8] Rename queue index to queue number Halil Pasic
2023-03-30 17:11 ` Halil Pasic
2023-03-30 19:13 ` [virtio-comment] " Parav Pandit
2023-03-30 19:13 ` Parav Pandit
2023-04-04 1:36 ` [virtio-comment] " Halil Pasic
2023-04-04 1:36 ` Halil Pasic
2023-04-04 2:57 ` [virtio-comment] " Parav Pandit
2023-04-04 2:57 ` Parav Pandit
2023-04-04 6:33 ` [virtio-comment] " Michael S. Tsirkin
2023-04-04 6:33 ` Michael S. Tsirkin
2023-04-04 16:44 ` [virtio-comment] " Halil Pasic
2023-04-04 16:44 ` [virtio-dev] " Halil Pasic
2023-04-04 7:07 ` Michael S. Tsirkin
2023-04-04 7:07 ` Michael S. Tsirkin
2023-04-04 15:55 ` [virtio-comment] " Halil Pasic
2023-04-04 15:55 ` Halil Pasic
2023-04-04 16:08 ` [virtio-comment] " Cornelia Huck
2023-04-04 16:08 ` [virtio-dev] " Cornelia Huck
2023-04-04 7:13 ` Michael S. Tsirkin [this message]
2023-04-04 7:13 ` Michael S. Tsirkin
2023-03-31 8:13 ` [virtio-comment] " Cornelia Huck
2023-03-31 8:13 ` Cornelia Huck
2023-04-04 6:34 ` [virtio-comment] " Michael S. Tsirkin
2023-04-04 6:34 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230404030859-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=cohuck@redhat.com \
--cc=parav@nvidia.com \
--cc=pasic@linux.ibm.com \
--cc=sgarzare@redhat.com \
--cc=shahafs@nvidia.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.