From: Luca Ceresoli <luca.ceresoli@bootlin.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Sowjanya Komatineni <skomatineni@nvidia.com>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dmitry Osipenko <digetx@gmail.com>,
linux-media@vger.kernel.org, linux-tegra@vger.kernel.org,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
Richard Leitner <richard.leitner@skidata.com>
Subject: Re: [RESEND PATCH v4 03/21] staging: media: tegra-video: fix .vidioc_enum_fmt_vid_cap to return all formats
Date: Wed, 5 Apr 2023 10:31:34 +0200 [thread overview]
Message-ID: <20230405103134.2ae10766@booty> (raw)
In-Reply-To: <20230405023048.GD9915@pendragon.ideasonboard.com>
Hi Laurent,
On Wed, 5 Apr 2023 05:30:48 +0300
Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote:
> Hi Luca,
>
> On Tue, Apr 04, 2023 at 04:12:51PM +0200, Luca Ceresoli wrote:
> > On Wed, 29 Mar 2023 13:16:22 +0200 Hans Verkuil wrote:
> >
> > > Hi Luca,
> > >
> > > I finally found the time to test this series. It looks OK, except for this patch.
> >
> > Thank you very much for taking the time!
> >
> > > The list of supported formats really has to be the intersection of what the tegra
> > > supports and what the sensor supports.
> > >
> > > Otherwise you would advertise pixelformats that cannot be used, and the application
> > > would have no way of knowing that.
> >
> > As far as I understand, I think we should rather make this driver fully
> > behave as an MC-centric device. It is already using MC quite
> > successfully after all.
> >
> > Do you think this is correct?
>
> Given the use cases for this driver, I agree.
Ok, thanks for the feedback. I will send a v5 with this change.
Best regards,
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
WARNING: multiple messages have this Message-ID (diff)
From: Luca Ceresoli <luca.ceresoli@bootlin.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: devicetree@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Richard Leitner <richard.leitner@skidata.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
linux-tegra@vger.kernel.org,
Thierry Reding <thierry.reding@gmail.com>,
Sowjanya Komatineni <skomatineni@nvidia.com>,
dri-devel@lists.freedesktop.org,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Dmitry Osipenko <digetx@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org
Subject: Re: [RESEND PATCH v4 03/21] staging: media: tegra-video: fix .vidioc_enum_fmt_vid_cap to return all formats
Date: Wed, 5 Apr 2023 10:31:34 +0200 [thread overview]
Message-ID: <20230405103134.2ae10766@booty> (raw)
In-Reply-To: <20230405023048.GD9915@pendragon.ideasonboard.com>
Hi Laurent,
On Wed, 5 Apr 2023 05:30:48 +0300
Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote:
> Hi Luca,
>
> On Tue, Apr 04, 2023 at 04:12:51PM +0200, Luca Ceresoli wrote:
> > On Wed, 29 Mar 2023 13:16:22 +0200 Hans Verkuil wrote:
> >
> > > Hi Luca,
> > >
> > > I finally found the time to test this series. It looks OK, except for this patch.
> >
> > Thank you very much for taking the time!
> >
> > > The list of supported formats really has to be the intersection of what the tegra
> > > supports and what the sensor supports.
> > >
> > > Otherwise you would advertise pixelformats that cannot be used, and the application
> > > would have no way of knowing that.
> >
> > As far as I understand, I think we should rather make this driver fully
> > behave as an MC-centric device. It is already using MC quite
> > successfully after all.
> >
> > Do you think this is correct?
>
> Given the use cases for this driver, I agree.
Ok, thanks for the feedback. I will send a v5 with this change.
Best regards,
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2023-04-05 8:31 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 14:42 [RESEND PATCH v4 00/21] Add Tegra20 parallel video input capture Luca Ceresoli
2023-03-09 14:42 ` Luca Ceresoli
2023-03-09 14:43 ` [RESEND PATCH v4 01/21] dt-bindings: display: tegra: add Tegra20 VIP Luca Ceresoli
2023-03-09 14:43 ` Luca Ceresoli
2023-03-09 14:43 ` [RESEND PATCH v4 02/21] dt-bindings: display: tegra: vi: add 'vip' property and example Luca Ceresoli
2023-03-09 14:43 ` Luca Ceresoli
2023-03-09 14:43 ` [RESEND PATCH v4 03/21] staging: media: tegra-video: fix .vidioc_enum_fmt_vid_cap to return all formats Luca Ceresoli
2023-03-09 14:43 ` Luca Ceresoli
2023-03-29 11:16 ` Hans Verkuil
2023-03-29 11:16 ` Hans Verkuil
2023-03-29 11:56 ` Hans Verkuil
2023-03-29 11:56 ` Hans Verkuil
2023-04-04 14:12 ` Luca Ceresoli
2023-04-04 14:12 ` Luca Ceresoli
2023-04-05 2:30 ` Laurent Pinchart
2023-04-05 2:30 ` Laurent Pinchart
2023-04-05 8:31 ` Luca Ceresoli [this message]
2023-04-05 8:31 ` Luca Ceresoli
2023-04-05 8:50 ` Hans Verkuil
2023-04-05 8:50 ` Hans Verkuil
2023-04-05 9:28 ` Thierry Reding
2023-04-05 9:28 ` Thierry Reding
2023-04-05 14:30 ` Laurent Pinchart
2023-04-05 14:30 ` Laurent Pinchart
2023-03-09 14:43 ` [RESEND PATCH v4 04/21] staging: media: tegra-video: improve documentation of tegra_video_format fields Luca Ceresoli
2023-03-09 14:43 ` Luca Ceresoli
2023-03-09 14:43 ` [RESEND PATCH v4 05/21] staging: media: tegra-video: document tegra_channel_get_remote_source_subdev Luca Ceresoli
2023-03-09 14:43 ` Luca Ceresoli
2023-03-09 14:43 ` [RESEND PATCH v4 06/21] staging: media: tegra-video: fix typos in comment Luca Ceresoli
2023-03-09 14:43 ` Luca Ceresoli
2023-03-09 14:43 ` [RESEND PATCH v4 07/21] staging: media: tegra-video: improve error messages Luca Ceresoli
2023-03-09 14:43 ` Luca Ceresoli
2023-03-09 14:43 ` [RESEND PATCH v4 08/21] staging: media: tegra-video: slightly simplify cleanup on errors Luca Ceresoli
2023-03-09 14:43 ` Luca Ceresoli
2023-03-09 14:43 ` [RESEND PATCH v4 09/21] staging: media: tegra-video: move private struct declaration to C file Luca Ceresoli
2023-03-09 14:43 ` Luca Ceresoli
2023-03-09 14:43 ` [RESEND PATCH v4 10/21] staging: media: tegra-video: move tegra210_csi_soc " Luca Ceresoli
2023-03-09 14:43 ` Luca Ceresoli
2023-03-09 14:43 ` [RESEND PATCH v4 11/21] staging: media: tegra-video: remove unneeded include Luca Ceresoli
2023-03-09 14:43 ` Luca Ceresoli
2023-03-09 14:43 ` [RESEND PATCH v4 12/21] staging: media: tegra-video: Kconfig: allow TPG only on Tegra210 Luca Ceresoli
2023-03-09 14:43 ` Luca Ceresoli
2023-03-09 14:43 ` [RESEND PATCH v4 13/21] staging: media: tegra-video: move tegra_channel_fmt_align to a per-soc op Luca Ceresoli
2023-03-09 14:43 ` Luca Ceresoli
2023-03-09 14:43 ` [RESEND PATCH v4 14/21] staging: media: tegra-video: move default format to soc-specific data Luca Ceresoli
2023-03-09 14:43 ` Luca Ceresoli
2023-03-09 14:43 ` [RESEND PATCH v4 15/21] staging: media: tegra-video: move MIPI calibration calls from VI to CSI Luca Ceresoli
2023-03-09 14:43 ` Luca Ceresoli
2023-03-09 14:43 ` [RESEND PATCH v4 16/21] staging: media: tegra-video: add a per-soc enable/disable op Luca Ceresoli
2023-03-09 14:43 ` Luca Ceresoli
2023-03-09 14:43 ` [RESEND PATCH v4 17/21] staging: media: tegra-video: move syncpt init/free to a per-soc op Luca Ceresoli
2023-03-09 14:43 ` Luca Ceresoli
2023-03-09 14:43 ` [RESEND PATCH v4 18/21] staging: media: tegra-video: add syncpts for Tegra20 to struct tegra_vi Luca Ceresoli
2023-03-09 14:43 ` Luca Ceresoli
2023-03-09 14:43 ` [RESEND PATCH v4 19/21] staging: media: tegra-video: add hooks for planar YUV and H/V flip Luca Ceresoli
2023-03-09 14:43 ` Luca Ceresoli
2023-03-09 14:43 ` [RESEND PATCH v4 20/21] staging: media: tegra-video: add H/V flip controls Luca Ceresoli
2023-03-09 14:43 ` Luca Ceresoli
2023-03-09 14:43 ` [RESEND PATCH v4 21/21] staging: media: tegra-video: add support for Tegra20 parallel input Luca Ceresoli
2023-03-09 14:43 ` Luca Ceresoli
2023-03-22 9:14 ` [RESEND PATCH v4 00/21] Add Tegra20 parallel video input capture Luca Ceresoli
2023-03-22 9:14 ` Luca Ceresoli
2023-03-22 9:29 ` Hans Verkuil
2023-03-22 9:29 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230405103134.2ae10766@booty \
--to=luca.ceresoli@bootlin.com \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-tegra@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=paul.kocialkowski@bootlin.com \
--cc=richard.leitner@skidata.com \
--cc=robh+dt@kernel.org \
--cc=skomatineni@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.