All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Andreas Henriksson <andreas@fatal.se>
Cc: Marco Felsch <m.felsch@pengutronix.de>, Jun Li <jun.li@nxp.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"krzysztof.kozlowski+dt@linaro.org"
	<krzysztof.kozlowski+dt@linaro.org>,
	dl-linux-imx <linux-imx@nxp.com>,
	"festevam@gmail.com" <festevam@gmail.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	Xu Yang <xu.yang_2@nxp.com>
Subject: Re: [PATCH] arm64: dts: imx8mp-evk: add dual-role usb port1 support
Date: Wed, 5 Apr 2023 21:16:37 +0800	[thread overview]
Message-ID: <20230405131637.GB11367@dragon> (raw)
In-Reply-To: <20230403093812.rjj2wkusajsx5mwi@fatal.se>

On Mon, Apr 03, 2023 at 11:38:12AM +0200, Andreas Henriksson wrote:
> Hello Marco Felsch,
> 
> On Thu, Mar 30, 2023 at 04:38:13PM +0200, Marco Felsch wrote:
> > Hi,
> > 
> > On 23-03-27, Andreas Henriksson wrote:
> [...]
> > > / {
> > >     gpio-sbu-mux {
> > >         compatible = "gpio-sbu-mux";
> [...]
> > I didn't tested it but at the moment I don't see the problem with my
> > patch. 
> 
> As Jun Li helpfully explained my patch is not correct, so don't bother.
> 
> I don't have a problem with your patch, was just trying to share
> what I had done.
> 
> I've since learned that the board I'll be working on will not even have
> SS, so I will not pursue SBU. I'll most likely use your patches instead
> as they seem simpler than what I did and should fully meet my needs for
> an usb port that works in both host and device mode.
> 
> Not that it matters, but +1 from me on applying your patches.
> (If people are hesitant to do it because of lack of SS, then maybe
> that could be adressed by adding a comment setting the expectations?)

Marco,

Could you update the patch to mention a bit about Super-Speed support
as discussed here?

Shawn

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Andreas Henriksson <andreas@fatal.se>
Cc: Marco Felsch <m.felsch@pengutronix.de>, Jun Li <jun.li@nxp.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"krzysztof.kozlowski+dt@linaro.org" 
	<krzysztof.kozlowski+dt@linaro.org>,
	dl-linux-imx <linux-imx@nxp.com>,
	"festevam@gmail.com" <festevam@gmail.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	Xu Yang <xu.yang_2@nxp.com>
Subject: Re: [PATCH] arm64: dts: imx8mp-evk: add dual-role usb port1 support
Date: Wed, 5 Apr 2023 21:16:37 +0800	[thread overview]
Message-ID: <20230405131637.GB11367@dragon> (raw)
In-Reply-To: <20230403093812.rjj2wkusajsx5mwi@fatal.se>

On Mon, Apr 03, 2023 at 11:38:12AM +0200, Andreas Henriksson wrote:
> Hello Marco Felsch,
> 
> On Thu, Mar 30, 2023 at 04:38:13PM +0200, Marco Felsch wrote:
> > Hi,
> > 
> > On 23-03-27, Andreas Henriksson wrote:
> [...]
> > > / {
> > >     gpio-sbu-mux {
> > >         compatible = "gpio-sbu-mux";
> [...]
> > I didn't tested it but at the moment I don't see the problem with my
> > patch. 
> 
> As Jun Li helpfully explained my patch is not correct, so don't bother.
> 
> I don't have a problem with your patch, was just trying to share
> what I had done.
> 
> I've since learned that the board I'll be working on will not even have
> SS, so I will not pursue SBU. I'll most likely use your patches instead
> as they seem simpler than what I did and should fully meet my needs for
> an usb port that works in both host and device mode.
> 
> Not that it matters, but +1 from me on applying your patches.
> (If people are hesitant to do it because of lack of SS, then maybe
> that could be adressed by adding a comment setting the expectations?)

Marco,

Could you update the patch to mention a bit about Super-Speed support
as discussed here?

Shawn

  reply	other threads:[~2023-04-05 13:17 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-23 10:58 [PATCH] arm64: dts: imx8mp-evk: add dual-role usb port1 support Marco Felsch
2023-03-23 10:58 ` Marco Felsch
2023-03-24 10:18 ` Jun Li
2023-03-24 10:18   ` Jun Li
2023-03-27  8:22   ` Marco Felsch
2023-03-27  8:22     ` Marco Felsch
2023-03-27  8:49   ` Andreas Henriksson
2023-03-27  8:49     ` Andreas Henriksson
2023-03-27 11:48     ` Jun Li
2023-03-27 11:48       ` Jun Li
2023-05-03 18:48       ` Marco Felsch
2023-05-03 18:48         ` Marco Felsch
2023-05-03 19:08         ` Marco Felsch
2023-05-03 19:08           ` Marco Felsch
2023-03-30 14:38     ` Marco Felsch
2023-03-30 14:38       ` Marco Felsch
2023-04-03  9:38       ` Andreas Henriksson
2023-04-03  9:38         ` Andreas Henriksson
2023-04-05 13:16         ` Shawn Guo [this message]
2023-04-05 13:16           ` Shawn Guo
2023-05-03 15:38           ` Marco Felsch
2023-05-03 15:38             ` Marco Felsch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230405131637.GB11367@dragon \
    --to=shawnguo@kernel.org \
    --cc=andreas@fatal.se \
    --cc=festevam@gmail.com \
    --cc=jun.li@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.felsch@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=xu.yang_2@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.