* [PATCH] sched/psi: set varaiable psi_cgroups_enabled storage-class-specifier to static
@ 2023-04-05 16:36 Tom Rix
2023-04-05 16:46 ` Johannes Weiner
0 siblings, 1 reply; 3+ messages in thread
From: Tom Rix @ 2023-04-05 16:36 UTC (permalink / raw)
To: hannes, surenb, mingo, peterz, juri.lelli, vincent.guittot,
dietmar.eggemann, rostedt, bsegall, mgorman, bristot, vschneid
Cc: linux-kernel, Tom Rix
smatch reports
kernel/sched/psi.c:143:1: warning: symbol
'psi_cgroups_enabled' was not declared. Should it be static?
This variable is only used in one file so should be static.
Signed-off-by: Tom Rix <trix@redhat.com>
---
kernel/sched/psi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c
index 02e011cabe91..c8a556eb9f8a 100644
--- a/kernel/sched/psi.c
+++ b/kernel/sched/psi.c
@@ -140,7 +140,7 @@
static int psi_bug __read_mostly;
DEFINE_STATIC_KEY_FALSE(psi_disabled);
-DEFINE_STATIC_KEY_TRUE(psi_cgroups_enabled);
+static DEFINE_STATIC_KEY_TRUE(psi_cgroups_enabled);
#ifdef CONFIG_PSI_DEFAULT_DISABLED
static bool psi_enable;
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] sched/psi: set varaiable psi_cgroups_enabled storage-class-specifier to static
2023-04-05 16:36 [PATCH] sched/psi: set varaiable psi_cgroups_enabled storage-class-specifier to static Tom Rix
@ 2023-04-05 16:46 ` Johannes Weiner
2023-04-05 18:38 ` Suren Baghdasaryan
0 siblings, 1 reply; 3+ messages in thread
From: Johannes Weiner @ 2023-04-05 16:46 UTC (permalink / raw)
To: Tom Rix
Cc: surenb, mingo, peterz, juri.lelli, vincent.guittot,
dietmar.eggemann, rostedt, bsegall, mgorman, bristot, vschneid,
linux-kernel
On Wed, Apr 05, 2023 at 12:36:02PM -0400, Tom Rix wrote:
> smatch reports
> kernel/sched/psi.c:143:1: warning: symbol
> 'psi_cgroups_enabled' was not declared. Should it be static?
>
> This variable is only used in one file so should be static.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] sched/psi: set varaiable psi_cgroups_enabled storage-class-specifier to static
2023-04-05 16:46 ` Johannes Weiner
@ 2023-04-05 18:38 ` Suren Baghdasaryan
0 siblings, 0 replies; 3+ messages in thread
From: Suren Baghdasaryan @ 2023-04-05 18:38 UTC (permalink / raw)
To: Johannes Weiner
Cc: Tom Rix, mingo, peterz, juri.lelli, vincent.guittot,
dietmar.eggemann, rostedt, bsegall, mgorman, bristot, vschneid,
linux-kernel
On Wed, Apr 5, 2023 at 9:46 AM Johannes Weiner <hannes@cmpxchg.org> wrote:
>
> On Wed, Apr 05, 2023 at 12:36:02PM -0400, Tom Rix wrote:
> > smatch reports
> > kernel/sched/psi.c:143:1: warning: symbol
> > 'psi_cgroups_enabled' was not declared. Should it be static?
> >
> > This variable is only used in one file so should be static.
> >
> > Signed-off-by: Tom Rix <trix@redhat.com>
>
> Acked-by: Johannes Weiner <hannes@cmpxchg.org>
Acked-by: Suren Baghdasaryan <surenb@google.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-05 18:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-05 16:36 [PATCH] sched/psi: set varaiable psi_cgroups_enabled storage-class-specifier to static Tom Rix
2023-04-05 16:46 ` Johannes Weiner
2023-04-05 18:38 ` Suren Baghdasaryan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.