* [linux-next:master 8027/9787] drivers/gpu/drm/i915/display/intel_tc.c:424 icl_tc_phy_hpd_live_status() error: uninitialized symbol 'fia_isr'.
@ 2023-04-06 20:35 kernel test robot
0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2023-04-06 20:35 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp, Dan Carpenter
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: Linux Memory Management List <linux-mm@kvack.org>
TO: Imre Deak <imre.deak@intel.com>
CC: Mika Kahola <mika.kahola@intel.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: e134c93f788fb93fd6a3ec3af9af850a2048c7e6
commit: 8979918af711b057620c7c5f9d29a0043f927753 [8027/9787] drm/i915/tc: Get power ref for reading the HPD live status register
:::::: branch date: 15 hours ago
:::::: commit date: 4 days ago
config: i386-randconfig-m031-20230403 (https://download.01.org/0day-ci/archive/20230407/202304070402.p78bkshq-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Link: https://lore.kernel.org/r/202304070402.p78bkshq-lkp@intel.com/
New smatch warnings:
drivers/gpu/drm/i915/display/intel_tc.c:424 icl_tc_phy_hpd_live_status() error: uninitialized symbol 'fia_isr'.
drivers/gpu/drm/i915/display/intel_tc.c:436 icl_tc_phy_hpd_live_status() error: uninitialized symbol 'pch_isr'.
drivers/gpu/drm/i915/display/intel_tc.c:709 adlp_tc_phy_hpd_live_status() error: uninitialized symbol 'cpu_isr'.
drivers/gpu/drm/i915/display/intel_tc.c:714 adlp_tc_phy_hpd_live_status() error: uninitialized symbol 'pch_isr'.
Old smatch warnings:
drivers/gpu/drm/i915/display/intel_tc.c:660 tgl_tc_phy_init() error: uninitialized symbol 'val'.
vim +/fia_isr +424 drivers/gpu/drm/i915/display/intel_tc.c
16cf693e31bdb4 Imre Deak 2023-03-23 408
3eafcddf766b6b Imre Deak 2023-03-23 409 static u32 icl_tc_phy_hpd_live_status(struct intel_tc_port *tc)
c905eb28bd3f43 Imre Deak 2019-06-28 410 {
3eafcddf766b6b Imre Deak 2023-03-23 411 struct drm_i915_private *i915 = tc_to_i915(tc);
3eafcddf766b6b Imre Deak 2023-03-23 412 struct intel_digital_port *dig_port = tc->dig_port;
5a4dd6f0e84654 Jani Nikula 2022-08-24 413 u32 isr_bit = i915->display.hotplug.pch_hpd[dig_port->base.hpd_pin];
8979918af711b0 Imre Deak 2023-03-23 414 intel_wakeref_t wakeref;
8979918af711b0 Imre Deak 2023-03-23 415 u32 fia_isr;
8979918af711b0 Imre Deak 2023-03-23 416 u32 pch_isr;
c905eb28bd3f43 Imre Deak 2019-06-28 417 u32 mask = 0;
c905eb28bd3f43 Imre Deak 2019-06-28 418
8979918af711b0 Imre Deak 2023-03-23 419 with_intel_display_power(i915, tc_phy_cold_off_domain(tc), wakeref) {
8979918af711b0 Imre Deak 2023-03-23 420 fia_isr = intel_de_read(i915, PORT_TX_DFLEXDPSP(tc->phy_fia));
8979918af711b0 Imre Deak 2023-03-23 421 pch_isr = intel_de_read(i915, SDEISR);
8979918af711b0 Imre Deak 2023-03-23 422 }
c905eb28bd3f43 Imre Deak 2019-06-28 423
8979918af711b0 Imre Deak 2023-03-23 @424 if (fia_isr == 0xffffffff) {
c4d162618216f7 Wambui Karuga 2020-01-30 425 drm_dbg_kms(&i915->drm,
c4d162618216f7 Wambui Karuga 2020-01-30 426 "Port %s: PHY in TCCOLD, nothing connected\n",
3eafcddf766b6b Imre Deak 2023-03-23 427 tc->port_name);
424f109f5c5d9c Imre Deak 2019-06-28 428 return mask;
424f109f5c5d9c Imre Deak 2019-06-28 429 }
424f109f5c5d9c Imre Deak 2019-06-28 430
8979918af711b0 Imre Deak 2023-03-23 431 if (fia_isr & TC_LIVE_STATE_TBT(tc->phy_fia_idx))
c905eb28bd3f43 Imre Deak 2019-06-28 432 mask |= BIT(TC_PORT_TBT_ALT);
8979918af711b0 Imre Deak 2023-03-23 433 if (fia_isr & TC_LIVE_STATE_TC(tc->phy_fia_idx))
c905eb28bd3f43 Imre Deak 2019-06-28 434 mask |= BIT(TC_PORT_DP_ALT);
c905eb28bd3f43 Imre Deak 2019-06-28 435
8979918af711b0 Imre Deak 2023-03-23 @436 if (pch_isr & isr_bit)
c905eb28bd3f43 Imre Deak 2019-06-28 437 mask |= BIT(TC_PORT_LEGACY);
c905eb28bd3f43 Imre Deak 2019-06-28 438
c905eb28bd3f43 Imre Deak 2019-06-28 439 return mask;
c905eb28bd3f43 Imre Deak 2019-06-28 440 }
c905eb28bd3f43 Imre Deak 2019-06-28 441
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
^ permalink raw reply [flat|nested] 3+ messages in thread* [linux-next:master 8027/9787] drivers/gpu/drm/i915/display/intel_tc.c:424 icl_tc_phy_hpd_live_status() error: uninitialized symbol 'fia_isr'.
@ 2023-04-07 8:57 Dan Carpenter
2023-04-11 10:40 ` Imre Deak
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2023-04-07 8:57 UTC (permalink / raw)
To: oe-kbuild, Imre Deak; +Cc: lkp, oe-kbuild-all, Mika Kahola
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: e134c93f788fb93fd6a3ec3af9af850a2048c7e6
commit: 8979918af711b057620c7c5f9d29a0043f927753 [8027/9787] drm/i915/tc: Get power ref for reading the HPD live status register
config: i386-randconfig-m031-20230403 (https://download.01.org/0day-ci/archive/20230407/202304070402.p78bkshq-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Link: https://lore.kernel.org/r/202304070402.p78bkshq-lkp@intel.com/
New smatch warnings:
drivers/gpu/drm/i915/display/intel_tc.c:424 icl_tc_phy_hpd_live_status() error: uninitialized symbol 'fia_isr'.
drivers/gpu/drm/i915/display/intel_tc.c:436 icl_tc_phy_hpd_live_status() error: uninitialized symbol 'pch_isr'.
drivers/gpu/drm/i915/display/intel_tc.c:709 adlp_tc_phy_hpd_live_status() error: uninitialized symbol 'cpu_isr'.
drivers/gpu/drm/i915/display/intel_tc.c:714 adlp_tc_phy_hpd_live_status() error: uninitialized symbol 'pch_isr'.
Old smatch warnings:
drivers/gpu/drm/i915/display/intel_tc.c:660 tgl_tc_phy_init() error: uninitialized symbol 'val'.
vim +/fia_isr +424 drivers/gpu/drm/i915/display/intel_tc.c
3eafcddf766b6b Imre Deak 2023-03-23 409 static u32 icl_tc_phy_hpd_live_status(struct intel_tc_port *tc)
c905eb28bd3f43 Imre Deak 2019-06-28 410 {
3eafcddf766b6b Imre Deak 2023-03-23 411 struct drm_i915_private *i915 = tc_to_i915(tc);
3eafcddf766b6b Imre Deak 2023-03-23 412 struct intel_digital_port *dig_port = tc->dig_port;
5a4dd6f0e84654 Jani Nikula 2022-08-24 413 u32 isr_bit = i915->display.hotplug.pch_hpd[dig_port->base.hpd_pin];
8979918af711b0 Imre Deak 2023-03-23 414 intel_wakeref_t wakeref;
8979918af711b0 Imre Deak 2023-03-23 415 u32 fia_isr;
8979918af711b0 Imre Deak 2023-03-23 416 u32 pch_isr;
c905eb28bd3f43 Imre Deak 2019-06-28 417 u32 mask = 0;
c905eb28bd3f43 Imre Deak 2019-06-28 418
8979918af711b0 Imre Deak 2023-03-23 419 with_intel_display_power(i915, tc_phy_cold_off_domain(tc), wakeref) {
8979918af711b0 Imre Deak 2023-03-23 420 fia_isr = intel_de_read(i915, PORT_TX_DFLEXDPSP(tc->phy_fia));
8979918af711b0 Imre Deak 2023-03-23 421 pch_isr = intel_de_read(i915, SDEISR);
What's the story with with_intel_display_power()? I guess it must
always be true. I've asked about it several times before but no one
ever responds to my emails about it.
8979918af711b0 Imre Deak 2023-03-23 422 }
c905eb28bd3f43 Imre Deak 2019-06-28 423
8979918af711b0 Imre Deak 2023-03-23 @424 if (fia_isr == 0xffffffff) {
c4d162618216f7 Wambui Karuga 2020-01-30 425 drm_dbg_kms(&i915->drm,
c4d162618216f7 Wambui Karuga 2020-01-30 426 "Port %s: PHY in TCCOLD, nothing connected\n",
3eafcddf766b6b Imre Deak 2023-03-23 427 tc->port_name);
424f109f5c5d9c Imre Deak 2019-06-28 428 return mask;
424f109f5c5d9c Imre Deak 2019-06-28 429 }
424f109f5c5d9c Imre Deak 2019-06-28 430
8979918af711b0 Imre Deak 2023-03-23 431 if (fia_isr & TC_LIVE_STATE_TBT(tc->phy_fia_idx))
c905eb28bd3f43 Imre Deak 2019-06-28 432 mask |= BIT(TC_PORT_TBT_ALT);
8979918af711b0 Imre Deak 2023-03-23 433 if (fia_isr & TC_LIVE_STATE_TC(tc->phy_fia_idx))
c905eb28bd3f43 Imre Deak 2019-06-28 434 mask |= BIT(TC_PORT_DP_ALT);
c905eb28bd3f43 Imre Deak 2019-06-28 435
8979918af711b0 Imre Deak 2023-03-23 @436 if (pch_isr & isr_bit)
c905eb28bd3f43 Imre Deak 2019-06-28 437 mask |= BIT(TC_PORT_LEGACY);
c905eb28bd3f43 Imre Deak 2019-06-28 438
c905eb28bd3f43 Imre Deak 2019-06-28 439 return mask;
c905eb28bd3f43 Imre Deak 2019-06-28 440 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [linux-next:master 8027/9787] drivers/gpu/drm/i915/display/intel_tc.c:424 icl_tc_phy_hpd_live_status() error: uninitialized symbol 'fia_isr'.
2023-04-07 8:57 Dan Carpenter
@ 2023-04-11 10:40 ` Imre Deak
0 siblings, 0 replies; 3+ messages in thread
From: Imre Deak @ 2023-04-11 10:40 UTC (permalink / raw)
To: Dan Carpenter; +Cc: oe-kbuild, lkp, oe-kbuild-all, Mika Kahola
On Fri, Apr 07, 2023 at 11:57:10AM +0300, Dan Carpenter wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: e134c93f788fb93fd6a3ec3af9af850a2048c7e6
> commit: 8979918af711b057620c7c5f9d29a0043f927753 [8027/9787] drm/i915/tc: Get power ref for reading the HPD live status register
> config: i386-randconfig-m031-20230403 (https://download.01.org/0day-ci/archive/20230407/202304070402.p78bkshq-lkp@intel.com/config)
> compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
>
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@intel.com>
> | Reported-by: Dan Carpenter <error27@gmail.com>
> | Link: https://lore.kernel.org/r/202304070402.p78bkshq-lkp@intel.com/
>
> New smatch warnings:
> drivers/gpu/drm/i915/display/intel_tc.c:424 icl_tc_phy_hpd_live_status() error: uninitialized symbol 'fia_isr'.
> drivers/gpu/drm/i915/display/intel_tc.c:436 icl_tc_phy_hpd_live_status() error: uninitialized symbol 'pch_isr'.
> drivers/gpu/drm/i915/display/intel_tc.c:709 adlp_tc_phy_hpd_live_status() error: uninitialized symbol 'cpu_isr'.
> drivers/gpu/drm/i915/display/intel_tc.c:714 adlp_tc_phy_hpd_live_status() error: uninitialized symbol 'pch_isr'.
>
> Old smatch warnings:
> drivers/gpu/drm/i915/display/intel_tc.c:660 tgl_tc_phy_init() error: uninitialized symbol 'val'.
>
> vim +/fia_isr +424 drivers/gpu/drm/i915/display/intel_tc.c
>
> 3eafcddf766b6b Imre Deak 2023-03-23 409 static u32 icl_tc_phy_hpd_live_status(struct intel_tc_port *tc)
> c905eb28bd3f43 Imre Deak 2019-06-28 410 {
> 3eafcddf766b6b Imre Deak 2023-03-23 411 struct drm_i915_private *i915 = tc_to_i915(tc);
> 3eafcddf766b6b Imre Deak 2023-03-23 412 struct intel_digital_port *dig_port = tc->dig_port;
> 5a4dd6f0e84654 Jani Nikula 2022-08-24 413 u32 isr_bit = i915->display.hotplug.pch_hpd[dig_port->base.hpd_pin];
> 8979918af711b0 Imre Deak 2023-03-23 414 intel_wakeref_t wakeref;
> 8979918af711b0 Imre Deak 2023-03-23 415 u32 fia_isr;
> 8979918af711b0 Imre Deak 2023-03-23 416 u32 pch_isr;
> c905eb28bd3f43 Imre Deak 2019-06-28 417 u32 mask = 0;
> c905eb28bd3f43 Imre Deak 2019-06-28 418
> 8979918af711b0 Imre Deak 2023-03-23 419 with_intel_display_power(i915, tc_phy_cold_off_domain(tc), wakeref) {
> 8979918af711b0 Imre Deak 2023-03-23 420 fia_isr = intel_de_read(i915, PORT_TX_DFLEXDPSP(tc->phy_fia));
> 8979918af711b0 Imre Deak 2023-03-23 421 pch_isr = intel_de_read(i915, SDEISR);
>
> What's the story with with_intel_display_power()? I guess it must
> always be true. I've asked about it several times before but no one
> ever responds to my emails about it.
Yes, it's guaranteed that the block inside with_intel_display_power() {}
will run.
> 8979918af711b0 Imre Deak 2023-03-23 422 }
> c905eb28bd3f43 Imre Deak 2019-06-28 423
> 8979918af711b0 Imre Deak 2023-03-23 @424 if (fia_isr == 0xffffffff) {
> c4d162618216f7 Wambui Karuga 2020-01-30 425 drm_dbg_kms(&i915->drm,
> c4d162618216f7 Wambui Karuga 2020-01-30 426 "Port %s: PHY in TCCOLD, nothing connected\n",
> 3eafcddf766b6b Imre Deak 2023-03-23 427 tc->port_name);
> 424f109f5c5d9c Imre Deak 2019-06-28 428 return mask;
> 424f109f5c5d9c Imre Deak 2019-06-28 429 }
> 424f109f5c5d9c Imre Deak 2019-06-28 430
> 8979918af711b0 Imre Deak 2023-03-23 431 if (fia_isr & TC_LIVE_STATE_TBT(tc->phy_fia_idx))
> c905eb28bd3f43 Imre Deak 2019-06-28 432 mask |= BIT(TC_PORT_TBT_ALT);
> 8979918af711b0 Imre Deak 2023-03-23 433 if (fia_isr & TC_LIVE_STATE_TC(tc->phy_fia_idx))
> c905eb28bd3f43 Imre Deak 2019-06-28 434 mask |= BIT(TC_PORT_DP_ALT);
> c905eb28bd3f43 Imre Deak 2019-06-28 435
> 8979918af711b0 Imre Deak 2023-03-23 @436 if (pch_isr & isr_bit)
> c905eb28bd3f43 Imre Deak 2019-06-28 437 mask |= BIT(TC_PORT_LEGACY);
> c905eb28bd3f43 Imre Deak 2019-06-28 438
> c905eb28bd3f43 Imre Deak 2019-06-28 439 return mask;
> c905eb28bd3f43 Imre Deak 2019-06-28 440 }
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-11 10:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-06 20:35 [linux-next:master 8027/9787] drivers/gpu/drm/i915/display/intel_tc.c:424 icl_tc_phy_hpd_live_status() error: uninitialized symbol 'fia_isr' kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2023-04-07 8:57 Dan Carpenter
2023-04-11 10:40 ` Imre Deak
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.