* [PATCH] drm/amdgpu: fix introduce gc_*_mes_2.bin v2
@ 2023-04-11 2:35 Li Ma
2023-04-11 2:43 ` Zhang, Yifan
2023-04-11 15:45 ` Deucher, Alexander
0 siblings, 2 replies; 3+ messages in thread
From: Li Ma @ 2023-04-11 2:35 UTC (permalink / raw)
To: amd-gfx; +Cc: Alexander.Deucher, yifan1.zhang, Li Ma, xiaojian.du, tim.huang
Rename MODULE_FIRMWARE declaration of gc_11_0_4_mes to gc_11_0_4_mes_2
Signed-off-by: Li Ma <li.ma@amd.com>
---
drivers/gpu/drm/amd/amdgpu/mes_v11_0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/mes_v11_0.c b/drivers/gpu/drm/amd/amdgpu/mes_v11_0.c
index 67f7557d545d..7e8c15cd8dc2 100644
--- a/drivers/gpu/drm/amd/amdgpu/mes_v11_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/mes_v11_0.c
@@ -40,7 +40,7 @@ MODULE_FIRMWARE("amdgpu/gc_11_0_2_mes_2.bin");
MODULE_FIRMWARE("amdgpu/gc_11_0_2_mes1.bin");
MODULE_FIRMWARE("amdgpu/gc_11_0_3_mes_2.bin");
MODULE_FIRMWARE("amdgpu/gc_11_0_3_mes1.bin");
-MODULE_FIRMWARE("amdgpu/gc_11_0_4_mes.bin");
+MODULE_FIRMWARE("amdgpu/gc_11_0_4_mes_2.bin");
MODULE_FIRMWARE("amdgpu/gc_11_0_4_mes1.bin");
static int mes_v11_0_hw_fini(void *handle);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] drm/amdgpu: fix introduce gc_*_mes_2.bin v2
2023-04-11 2:35 [PATCH] drm/amdgpu: fix introduce gc_*_mes_2.bin v2 Li Ma
@ 2023-04-11 2:43 ` Zhang, Yifan
2023-04-11 15:45 ` Deucher, Alexander
1 sibling, 0 replies; 3+ messages in thread
From: Zhang, Yifan @ 2023-04-11 2:43 UTC (permalink / raw)
To: Ma, Li, amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander, Huang, Tim, Du, Xiaojian
[AMD Official Use Only - General]
Please add
Fixes: 0f486b64b8d4 ("drm/amd/amdgpu: introduce gc_*_mes_2.bin v2")
With this fixed, patch Reviewed-by: Yifan Zhang <yifan1.zhang@amd.com>
Best Regards,
Yifan
-----Original Message-----
From: Ma, Li <Li.Ma@amd.com>
Sent: Tuesday, April 11, 2023 10:36 AM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Zhang, Yifan <Yifan1.Zhang@amd.com>; Huang, Tim <Tim.Huang@amd.com>; Du, Xiaojian <Xiaojian.Du@amd.com>; Ma, Li <Li.Ma@amd.com>
Subject: [PATCH] drm/amdgpu: fix introduce gc_*_mes_2.bin v2
Rename MODULE_FIRMWARE declaration of gc_11_0_4_mes to gc_11_0_4_mes_2
Signed-off-by: Li Ma <li.ma@amd.com>
---
drivers/gpu/drm/amd/amdgpu/mes_v11_0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/mes_v11_0.c b/drivers/gpu/drm/amd/amdgpu/mes_v11_0.c
index 67f7557d545d..7e8c15cd8dc2 100644
--- a/drivers/gpu/drm/amd/amdgpu/mes_v11_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/mes_v11_0.c
@@ -40,7 +40,7 @@ MODULE_FIRMWARE("amdgpu/gc_11_0_2_mes_2.bin");
MODULE_FIRMWARE("amdgpu/gc_11_0_2_mes1.bin");
MODULE_FIRMWARE("amdgpu/gc_11_0_3_mes_2.bin");
MODULE_FIRMWARE("amdgpu/gc_11_0_3_mes1.bin");
-MODULE_FIRMWARE("amdgpu/gc_11_0_4_mes.bin");
+MODULE_FIRMWARE("amdgpu/gc_11_0_4_mes_2.bin");
MODULE_FIRMWARE("amdgpu/gc_11_0_4_mes1.bin");
static int mes_v11_0_hw_fini(void *handle);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] drm/amdgpu: fix introduce gc_*_mes_2.bin v2
2023-04-11 2:35 [PATCH] drm/amdgpu: fix introduce gc_*_mes_2.bin v2 Li Ma
2023-04-11 2:43 ` Zhang, Yifan
@ 2023-04-11 15:45 ` Deucher, Alexander
1 sibling, 0 replies; 3+ messages in thread
From: Deucher, Alexander @ 2023-04-11 15:45 UTC (permalink / raw)
To: Ma, Li, amd-gfx@lists.freedesktop.org
Cc: Zhang, Yifan, Du, Xiaojian, Huang, Tim
[AMD Official Use Only - General]
> -----Original Message-----
> From: Ma, Li <Li.Ma@amd.com>
> Sent: Monday, April 10, 2023 10:36 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Zhang, Yifan
> <Yifan1.Zhang@amd.com>; Huang, Tim <Tim.Huang@amd.com>; Du,
> Xiaojian <Xiaojian.Du@amd.com>; Ma, Li <Li.Ma@amd.com>
> Subject: [PATCH] drm/amdgpu: fix introduce gc_*_mes_2.bin v2
>
> Rename MODULE_FIRMWARE declaration of gc_11_0_4_mes to
> gc_11_0_4_mes_2
>
> Signed-off-by: Li Ma <li.ma@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/mes_v11_0.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/mes_v11_0.c
> b/drivers/gpu/drm/amd/amdgpu/mes_v11_0.c
> index 67f7557d545d..7e8c15cd8dc2 100644
> --- a/drivers/gpu/drm/amd/amdgpu/mes_v11_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/mes_v11_0.c
> @@ -40,7 +40,7 @@
> MODULE_FIRMWARE("amdgpu/gc_11_0_2_mes_2.bin");
> MODULE_FIRMWARE("amdgpu/gc_11_0_2_mes1.bin");
> MODULE_FIRMWARE("amdgpu/gc_11_0_3_mes_2.bin");
> MODULE_FIRMWARE("amdgpu/gc_11_0_3_mes1.bin");
> -MODULE_FIRMWARE("amdgpu/gc_11_0_4_mes.bin");
I don't think you need to remove the old ones, they should still be available as a fallback if the new ones don't exist.
Alex
> +MODULE_FIRMWARE("amdgpu/gc_11_0_4_mes_2.bin");
> MODULE_FIRMWARE("amdgpu/gc_11_0_4_mes1.bin");
>
> static int mes_v11_0_hw_fini(void *handle);
> --
> 2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-11 15:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-11 2:35 [PATCH] drm/amdgpu: fix introduce gc_*_mes_2.bin v2 Li Ma
2023-04-11 2:43 ` Zhang, Yifan
2023-04-11 15:45 ` Deucher, Alexander
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.