+ mm-backing-dev-set-variables-dev_attr_minmax_bytes-storage-class-specifier-to-static.patch added to mm-unstable branch

+ mm-backing-dev-set-variables-dev_attr_minmax_bytes-storage-class-specifier-to-static.patch added to mm-unstable branch

[Andrew Morton]

The patch titled
     Subject: mm: backing-dev: set variables dev_attr_min,max_bytes storage-class-specifier to static
has been added to the -mm mm-unstable branch.  Its filename is
     mm-backing-dev-set-variables-dev_attr_minmax_bytes-storage-class-specifier-to-static.patch

This patch will shortly appear at
     https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-backing-dev-set-variables-dev_attr_minmax_bytes-storage-class-specifier-to-static.patch

This patch will later appear in the mm-unstable branch at
    git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***

The -mm tree is included into linux-next via the mm-everything
branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there every 2-3 working days

------------------------------------------------------
From: Tom Rix <trix@redhat.com>
Subject: mm: backing-dev: set variables dev_attr_min,max_bytes storage-class-specifier to static
Date: Sat, 8 Apr 2023 10:16:09 -0400

smatch reports
mm/backing-dev.c:266:1: warning: symbol
  'dev_attr_min_bytes' was not declared. Should it be static?
mm/backing-dev.c:294:1: warning: symbol
  'dev_attr_max_bytes' was not declared. Should it be static?

These variables are only used in one file so should be static.

Link: https://lkml.kernel.org/r/20230408141609.2703647-1-trix@redhat.com
Signed-off-by: Tom Rix <trix@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 mm/backing-dev.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/mm/backing-dev.c~mm-backing-dev-set-variables-dev_attr_minmax_bytes-storage-class-specifier-to-static
+++ a/mm/backing-dev.c
@@ -263,7 +263,7 @@ static ssize_t min_bytes_store(struct de
 
 	return ret;
 }
-DEVICE_ATTR_RW(min_bytes);
+static DEVICE_ATTR_RW(min_bytes);
 
 static ssize_t max_bytes_show(struct device *dev,
 			      struct device_attribute *attr,
@@ -291,7 +291,7 @@ static ssize_t max_bytes_store(struct de
 
 	return ret;
 }
-DEVICE_ATTR_RW(max_bytes);
+static DEVICE_ATTR_RW(max_bytes);
 
 static ssize_t stable_pages_required_show(struct device *dev,
 					  struct device_attribute *attr,
_

Patches currently in -mm which might be from trix@redhat.com are

mm-backing-dev-set-variables-dev_attr_minmax_bytes-storage-class-specifier-to-static.patch