From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc: linux-mips@vger.kernel.org, llvm@lists.linux.dev,
ndesaulniers@google.com, nathan@kernel.org
Subject: Re: [PATCH 3/8] MIPS: loongson2ef: Add missing break in cs5536_isa
Date: Wed, 12 Apr 2023 15:31:35 +0200 [thread overview]
Message-ID: <20230412133135.GC11717@alpha.franken.de> (raw)
In-Reply-To: <20230409104309.13887-4-jiaxun.yang@flygoat.com>
On Sun, Apr 09, 2023 at 11:43:04AM +0100, Jiaxun Yang wrote:
> Fixes build error:
>
> arch/mips/loongson2ef/common/cs5536/cs5536_isa.c:217:2: error:
> unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough]
> default:
> ^
> arch/mips/loongson2ef/common/cs5536/cs5536_isa.c:217:2:
> note: insert 'break;' to avoid fall-through
> default:
> ^
> break;
>
> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> ---
> arch/mips/loongson2ef/common/cs5536/cs5536_isa.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/loongson2ef/common/cs5536/cs5536_isa.c b/arch/mips/loongson2ef/common/cs5536/cs5536_isa.c
> index 5ad38f86ee62..d60dd9992377 100644
> --- a/arch/mips/loongson2ef/common/cs5536/cs5536_isa.c
> +++ b/arch/mips/loongson2ef/common/cs5536/cs5536_isa.c
> @@ -213,7 +213,7 @@ void pci_isa_write_reg(int reg, u32 value)
> lo |= 0x00000063;
> _wrmsr(SB_MSR_REG(SB_ERROR), hi, lo);
> }
> -
> + break;
> default:
> /* ALL OTHER PCI CONFIG SPACE HEADER IS NOT IMPLEMENTED. */
> break;
> --
> 2.39.2 (Apple Git-143)
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
next prev parent reply other threads:[~2023-04-12 13:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-09 10:43 [PATCH 0/7] MIPS: LLVM build fixes Jiaxun Yang
2023-04-09 10:43 ` [PATCH 1/8] MIPS: Replace assembly isa level directives with macros Jiaxun Yang
2023-04-20 16:43 ` Nick Desaulniers
2023-04-20 19:29 ` Jiaxun Yang
2023-04-21 7:41 ` Thomas Bogendoerfer
2023-04-21 8:18 ` Jiaxun Yang
2023-04-21 13:01 ` Maciej W. Rozycki
2023-04-09 10:43 ` [PATCH 2/8] MIPS: Set ISA level for MSA control reg helpers Jiaxun Yang
2023-04-09 10:43 ` [PATCH 3/8] MIPS: loongson2ef: Add missing break in cs5536_isa Jiaxun Yang
2023-04-12 13:31 ` Thomas Bogendoerfer [this message]
2023-04-09 10:43 ` [PATCH 4/8] MIPS: asmmacro: Restore fp macro after undef Jiaxun Yang
2023-04-09 10:43 ` [PATCH 5/8] MIPS: mipsregs: Parse fp and sp register by name in parse_r Jiaxun Yang
2023-04-21 10:48 ` Thomas Bogendoerfer
2023-04-21 11:38 ` Jiaxun Yang
2023-04-21 12:21 ` Thomas Bogendoerfer
2023-04-21 12:42 ` Jiaxun Yang
2023-04-09 10:43 ` [PATCH 6/8] MIPS: c-r4k: Use cache_op function for rm7k_erratum31 Jiaxun Yang
2023-04-09 10:43 ` [PATCH 7/8] MIPS: octeon_switch: Remove duplicated labels Jiaxun Yang
2023-04-12 13:31 ` Thomas Bogendoerfer
2023-04-09 10:43 ` [PATCH 8/8] MIPS: Implement microMIPS MT ASE helpers Jiaxun Yang
2023-04-21 8:31 ` [PATCH 0/7] MIPS: LLVM build fixes Jiaxun Yang
-- strict thread matches above, loose matches on Subject: below --
2023-04-11 11:12 Jiaxun Yang
2023-04-11 11:12 ` [PATCH 3/8] MIPS: loongson2ef: Add missing break in cs5536_isa Jiaxun Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230412133135.GC11717@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-mips@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.