Re: [PATCH v9 net-next 12/14] pds_core: add the aux client API

[Leon Romanovsky <leon@kernel.org>]

On Mon, Apr 10, 2023 at 01:50:52PM -0700, Shannon Nelson wrote:
> On 4/9/23 10:07 AM, Leon Romanovsky wrote:
> > 
> > On Thu, Apr 06, 2023 at 04:41:41PM -0700, Shannon Nelson wrote:
> > > Add the client API operations for running adminq commands.
> > > The core registers the client with the FW, then the client
> > > has a context for requesting adminq services.  We expect
> > > to add additional operations for other clients, including
> > > requesting additional private adminqs and IRQs, but don't have
> > > the need yet.
> > > 
> > > Signed-off-by: Shannon Nelson <shannon.nelson@amd.com>
> > > ---
> > >   drivers/net/ethernet/amd/pds_core/auxbus.c | 135 ++++++++++++++++++++-
> > >   include/linux/pds/pds_auxbus.h             |  28 +++++
> > >   2 files changed, 160 insertions(+), 3 deletions(-)

<...>

> > 
> > > diff --git a/include/linux/pds/pds_auxbus.h b/include/linux/pds/pds_auxbus.h
> > > index aa0192af4a29..f98efd578e1c 100644
> > > --- a/include/linux/pds/pds_auxbus.h
> > > +++ b/include/linux/pds/pds_auxbus.h
> > > @@ -10,7 +10,35 @@ struct pds_auxiliary_dev {
> > >        struct auxiliary_device aux_dev;
> > >        struct pci_dev *vf_pdev;
> > >        struct pci_dev *pf_pdev;
> > > +     struct pds_core_ops *ops;
> > 
> > I honestly don't understand why pds_core functionality is espoused
> > through ops callbacks on auxdevice. IMHO, they shouldn't be callbacks
> > and that functionality shouldn't operate on auxdevice.
> 
> The original design had several more operations and wrapped all the
> interaction into a single defined interface rather that polluting the kernel
> with additional direct EXPORTed functions from the PF.  Since much has
> disappeared as we simplified the interface and don't yet have use for some
> of them, this ops struct with its single entry is the last vestige of that
> idea.
> 
> Perhaps it is time to put it away and add one more EXPORTed function. We can
> revisit this idea if/when the interface grows again.

Thanks