+ mm-hwpoison-coredump-support-recovery-from-dump_user_range-checkpatch-fixes.patch added to mm-unstable branch

+ mm-hwpoison-coredump-support-recovery-from-dump_user_range-checkpatch-fixes.patch added to mm-unstable branch

[Andrew Morton]

The patch titled
     Subject: mm-hwpoison-coredump-support-recovery-from-dump_user_range-checkpatch-fixes
has been added to the -mm mm-unstable branch.  Its filename is
     mm-hwpoison-coredump-support-recovery-from-dump_user_range-checkpatch-fixes.patch

This patch will shortly appear at
     https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-hwpoison-coredump-support-recovery-from-dump_user_range-checkpatch-fixes.patch

This patch will later appear in the mm-unstable branch at
    git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***

The -mm tree is included into linux-next via the mm-everything
branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there every 2-3 working days

------------------------------------------------------
From: Andrew Morton <akpm@linux-foundation.org>
Subject: mm-hwpoison-coredump-support-recovery-from-dump_user_range-checkpatch-fixes
Date: Thu Apr 13 03:05:23 PM PDT 2023

WARNING: 'an user' may be misspelled - perhaps 'a user'?
#33: 
address may not always an user address, so introduce a new copy_mc flag in
                       ^^^^^^^

WARNING: please, no spaces at the start of a line
#133: FILE: lib/iov_iter.c:637:
+       if (iov_iter_is_copy_mc(i))$

WARNING: suspect code indent for conditional statements (7, 15)
#133: FILE: lib/iov_iter.c:637:
+       if (iov_iter_is_copy_mc(i))
+               return (void *)copy_mc_to_kernel(to, from, size);

ERROR: code indent should use tabs where possible
#134: FILE: lib/iov_iter.c:638:
+               return (void *)copy_mc_to_kernel(to, from, size);$

WARNING: please, no spaces at the start of a line
#134: FILE: lib/iov_iter.c:638:
+               return (void *)copy_mc_to_kernel(to, from, size);$

total: 1 errors, 4 warnings, 118 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

NOTE: Whitespace errors detected.
      You may wish to use scripts/cleanpatch or scripts/cleanfile

./patches/mm-hwpoison-coredump-support-recovery-from-dump_user_range.patch has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Kefeng Wang <wangkefeng.wang@huawei.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 lib/iov_iter.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/lib/iov_iter.c~mm-hwpoison-coredump-support-recovery-from-dump_user_range-checkpatch-fixes
+++ a/lib/iov_iter.c
@@ -634,8 +634,8 @@ EXPORT_SYMBOL_GPL(_copy_mc_to_iter);
 static void *memcpy_from_iter(struct iov_iter *i, void *to, const void *from,
 				 size_t size)
 {
-       if (iov_iter_is_copy_mc(i))
-               return (void *)copy_mc_to_kernel(to, from, size);
+	if (iov_iter_is_copy_mc(i))
+		return (void *)copy_mc_to_kernel(to, from, size);
 	return memcpy(to, from, size);
 }
 
_

Patches currently in -mm which might be from akpm@linux-foundation.org are

mm-khugepaged-fix-kernel-bug-in-hpage_collapse_scan_file-fix.patch
mm-treewide-redefine-max_order-sanely-fix-fix-fix.patch
memcg-do-not-drain-charge-pcp-caches-on-remote-isolated-cpus-fix.patch
vmstat-add-pcp-remote-node-draining-via-cpu_vm_stats_fold-fix.patch
lib-test_vmallocc-add-vm_map_ram-vm_unmap_ram-test-case-fix.patch
mm-hwpoison-coredump-support-recovery-from-dump_user_range-checkpatch-fixes.patch
scripts-gdb-create-linux-vfspy-for-vfs-related-gdb-helpers-fix.patch

Re: + mm-hwpoison-coredump-support-recovery-from-dump_user_range-checkpatch-fixes.patch added to mm-unstable branch

[Kefeng Wang]

On 2023/4/14 6:06, Andrew Morton wrote:
> 
> The patch titled
>       Subject: mm-hwpoison-coredump-support-recovery-from-dump_user_range-checkpatch-fixes
> has been added to the -mm mm-unstable branch.  Its filename is
>       mm-hwpoison-coredump-support-recovery-from-dump_user_range-checkpatch-fixes.patch
> 
> This patch will shortly appear at
>       https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-hwpoison-coredump-support-recovery-from-dump_user_range-checkpatch-fixes.patch
> 
> This patch will later appear in the mm-unstable branch at
>      git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> 
> Before you just go and hit "reply", please:
>     a) Consider who else should be cc'ed
>     b) Prefer to cc a suitable mailing list as well
>     c) Ideally: find the original patch on the mailing list and do a
>        reply-to-all to that, adding suitable additional cc's
> 
> *** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
> 
> The -mm tree is included into linux-next via the mm-everything
> branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> and is updated there every 2-3 working days
> 
> ------------------------------------------------------
> From: Andrew Morton <akpm@linux-foundation.org>
> Subject: mm-hwpoison-coredump-support-recovery-from-dump_user_range-checkpatch-fixes
> Date: Thu Apr 13 03:05:23 PM PDT 2023
> 
> WARNING: 'an user' may be misspelled - perhaps 'a user'?
> #33:
> address may not always an user address, so introduce a new copy_mc flag in
>                         ^^^^^^^
> 
> WARNING: please, no spaces at the start of a line
> #133: FILE: lib/iov_iter.c:637:
> +       if (iov_iter_is_copy_mc(i))$
> 
> WARNING: suspect code indent for conditional statements (7, 15)
> #133: FILE: lib/iov_iter.c:637:
> +       if (iov_iter_is_copy_mc(i))
> +               return (void *)copy_mc_to_kernel(to, from, size);
> 
> ERROR: code indent should use tabs where possible
> #134: FILE: lib/iov_iter.c:638:
> +               return (void *)copy_mc_to_kernel(to, from, size);$
> 
> WARNING: please, no spaces at the start of a line
> #134: FILE: lib/iov_iter.c:638:
> +               return (void *)copy_mc_to_kernel(to, from, size);$
> 
> total: 1 errors, 4 warnings, 118 lines checked
> 
> NOTE: For some of the reported defects, checkpatch may be able to
>        mechanically convert to the typical style using --fix or --fix-inplace.
> 
> NOTE: Whitespace errors detected.
>        You may wish to use scripts/cleanpatch or scripts/cleanfile
> 
> ./patches/mm-hwpoison-coredump-support-recovery-from-dump_user_range.patch has style problems, please review.
> 
> NOTE: If any of the errors are false positives, please report
>        them to the maintainer, see CHECKPATCH in MAINTAINERS.
> 
> Please run checkpatch prior to sending patches
> 

Hi Andrew, thanks for your fixes, I should do it, sorry, and I realized
the help iov_iter_clear_copy_mc() is not needed, at least for coredump
memcpy recovery, because the iov_iter is a local variable, after 
__kernel_write_iter(), no one use it, I will wait a moment to see if any 
other comments and resend a new patch with dropping clear helper and fix 
above issue.