All of lore.kernel.org
 help / color / mirror / Atom feed
From: Damien Le Moal <dlemoal@kernel.org>
To: Bjorn Helgaas <bhelgaas@google.com>, linux-pci@vger.kernel.org
Cc: "Rick Wertenbroek" <rick.wertenbroek@gmail.com>,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Krzysztof Wilczyński" <kw@linux.com>,
	"Manivannan Sadhasivam" <mani@kernel.org>,
	"Kishon Vijay Abraham I" <kishon@kernel.org>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Subject: [PATCH v5 03/17] PCI: epf-test: Fix DMA transfer completion initialization
Date: Sat, 15 Apr 2023 11:35:28 +0900	[thread overview]
Message-ID: <20230415023542.77601-4-dlemoal@kernel.org> (raw)
In-Reply-To: <20230415023542.77601-1-dlemoal@kernel.org>

Re-initialize the transfer_complete DMA transfer completion before
calling tx_submit(), to avoid seeing the DMA transfer complete before
the completion is initialized, thus potentially losing the completion
notification.

Fixes: 8353813c88ef ("PCI: endpoint: Enable DMA tests for endpoints with DMA capabilities")
Cc: stable@vger.kernel.org
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
---
 drivers/pci/endpoint/functions/pci-epf-test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c
index 0f9d2ec822ac..d65419735d2e 100644
--- a/drivers/pci/endpoint/functions/pci-epf-test.c
+++ b/drivers/pci/endpoint/functions/pci-epf-test.c
@@ -151,10 +151,10 @@ static int pci_epf_test_data_transfer(struct pci_epf_test *epf_test,
 		return -EIO;
 	}
 
+	reinit_completion(&epf_test->transfer_complete);
 	tx->callback = pci_epf_test_dma_callback;
 	tx->callback_param = epf_test;
 	cookie = tx->tx_submit(tx);
-	reinit_completion(&epf_test->transfer_complete);
 
 	ret = dma_submit_error(cookie);
 	if (ret) {
-- 
2.39.2


  parent reply	other threads:[~2023-04-15  2:35 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-15  2:35 [PATCH v5 00/17] PCI endpoint fixes and improvements Damien Le Moal
2023-04-15  2:35 ` [PATCH v5 01/17] PCI: endpoint: Automatically create a function specific attributes group Damien Le Moal
2023-04-15  2:35 ` [PATCH v5 02/17] PCI: endpoint: Move pci_epf_type_add_cfs() code Damien Le Moal
2023-04-15  2:35 ` Damien Le Moal [this message]
2023-04-15  2:35 ` [PATCH v5 04/17] PCI: epf-test: Fix DMA transfer completion detection Damien Le Moal
2023-04-15  2:35 ` [PATCH v5 05/17] PCI: epf-test: Use dmaengine_submit() to initiate DMA transfer Damien Le Moal
2023-04-15  2:35 ` [PATCH v5 06/17] PCI: epf-test: Simplify read/write/copy test functions Damien Le Moal
2023-04-15  2:35 ` [PATCH v5 07/17] PCI: epf-test: Simplify pci_epf_test_raise_irq() Damien Le Moal
2023-04-15  2:35 ` [PATCH v5 08/17] PCI: epf-test: Simplify IRQ test commands execution Damien Le Moal
2023-04-15  2:35 ` [PATCH v5 09/17] PCI: epf-test: Improve handling of command and status registers Damien Le Moal
2023-04-15  2:35 ` [PATCH v5 10/17] PCI: epf-test: Cleanup pci_epf_test_cmd_handler() Damien Le Moal
2023-04-15  2:35 ` [PATCH v5 11/17] PCI: epf-test: Cleanup request result handling Damien Le Moal
2023-04-15  2:35 ` [PATCH v5 12/17] PCI: epf-test: Simplify DMA support checks Damien Le Moal
2023-04-15  2:35 ` [PATCH v5 13/17] PCI: epf-test: Simplify transfers result print Damien Le Moal
2023-04-15  2:35 ` [PATCH v5 14/17] misc: pci_endpoint_test: Free IRQs before removing the device Damien Le Moal
2023-04-15  2:35 ` [PATCH v5 15/17] misc: pci_endpoint_test: Re-init completion for every test Damien Le Moal
2023-04-15  2:35 ` [PATCH v5 16/17] misc: pci_endpoint_test: Do not write status in IRQ handler Damien Le Moal
2023-04-15  2:35 ` [PATCH v5 17/17] misc: pci_endpoint_test: Simplify pci_endpoint_test_msi_irq() Damien Le Moal
2023-04-21 10:10 ` [PATCH v5 00/17] PCI endpoint fixes and improvements Lorenzo Pieralisi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230415023542.77601-4-dlemoal@kernel.org \
    --to=dlemoal@kernel.org \
    --cc=arnd@arndb.de \
    --cc=bhelgaas@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kishon@kernel.org \
    --cc=kw@linux.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=mani@kernel.org \
    --cc=rick.wertenbroek@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.