All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Mario Haustein <mario.haustein@hrz.tu-chemnitz.de>
Cc: "Alvaro G. M" <alvaro.gamez@hazent.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2] package/dcron: fix /etc/cron.d/system cron jobs
Date: Mon, 17 Apr 2023 08:48:22 +0200	[thread overview]
Message-ID: <20230417064822.GK2819@scaer> (raw)
In-Reply-To: <20220926160849.1046939-1-mario.haustein@hrz.tu-chemnitz.de>

Mario, All,

Sorry, for the long delay...

> Jobs with the syntax @hourly, @daily, ... were not executed since the
> version bump from `v4.5` to commit `1ba33c3325df48de46263276a43ed76cf9d81518`.
> This patch fixes the bug downstream.
> 
> Signed-off-by: Mario Haustein <mario.haustein@hrz.tu-chemnitz.de>

Without any feedback from upstream, which has been inactive for more
than a year now: applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
> Changes v1 -> v2:
>   - Use `git format-patch` to export the patch
>   - Specify the version bump which broke dcron in the commit message
> 
> Signed-off-by: Mario Haustein <mario.haustein@hrz.tu-chemnitz.de>
> ---
>  package/dcron/0002-system-crontab.patch | 28 +++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
>  create mode 100644 package/dcron/0002-system-crontab.patch
> 
> diff --git a/package/dcron/0002-system-crontab.patch b/package/dcron/0002-system-crontab.patch
> new file mode 100644
> index 0000000000..95d9606b7a
> --- /dev/null
> +++ b/package/dcron/0002-system-crontab.patch
> @@ -0,0 +1,28 @@
> +From 1fd99b71b063b1573beaf9f6b801ec5be2fbe24f Mon Sep 17 00:00:00 2001
> +From: Mario Haustein <mario.haustein@hrz.tu-chemnitz.de>
> +Date: Fri, 2 Sep 2022 23:20:14 +0200
> +Subject: [PATCH] Make @hourly, @daily, ... work again
> +
> +closes #15
> +
> +Signed-off-by: Mario Haustein <mario.haustein@hrz.tu-chemnitz.de>
> +[Upstream status: https://github.com/dubiousjim/dcron/pull/35]
> +---
> + database.c | 2 ++
> + 1 file changed, 2 insertions(+)
> +
> +diff --git a/database.c b/database.c
> +index 37cf17a..6ec720e 100644
> +--- a/database.c
> ++++ b/database.c
> +@@ -455,6 +455,8 @@ SynchronizeFile(const char *dpath, const char *fileName, const char *userName)
> + 							line.cl_Days[j] = 1;
> + 						for (j=0; j<12; ++j)
> + 							line.cl_Mons[j] = 1;
> ++						for (j=0; j<7; ++j)
> ++							line.cl_Dow[j] = ALL_DOW;
> + 					}
> + 
> + 					while (*ptr == ' ' || *ptr == '\t')
> +-- 
> +2.35.1
> -- 
> 2.30.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-04-17  6:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-02 22:28 [Buildroot] [PATCH 1/1] package/dcron: fix /etc/cron.d/system cron jobs Mario Haustein
2022-09-24  8:30 ` Thomas Petazzoni
2022-09-26 16:15   ` Mario Haustein
2022-09-26 16:08 ` [Buildroot] [PATCH v2] " Mario Haustein
2023-04-17  6:48   ` Yann E. MORIN [this message]
2023-04-23 10:37   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230417064822.GK2819@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=alvaro.gamez@hazent.com \
    --cc=buildroot@buildroot.org \
    --cc=mario.haustein@hrz.tu-chemnitz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.