From: Mario Haustein <mario.haustein@hrz.tu-chemnitz.de>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: "Alvaro G . M" <alvaro.gamez@hazent.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/dcron: fix /etc/cron.d/system cron jobs
Date: Mon, 26 Sep 2022 18:15:29 +0200 [thread overview]
Message-ID: <3721052.kQq0lBPeGt@localdomain> (raw)
In-Reply-To: <20220924103036.6ba8ea92@windsurf>
[-- Attachment #1.1: Type: text/plain, Size: 1379 bytes --]
Am Samstag, 24. September 2022, 10:30:36 CEST schrieb Thomas Petazzoni:
> Hello Mario,
Hello Thomas,
> Thanks for your patch. See below some questions/comments.
>
> On Sat, 3 Sep 2022 00:28:49 +0200
>
> Mario Haustein <mario.haustein@hrz.tu-chemnitz.de> wrote:
> > Jobs with the syntax @hourly, @daily, ... were not executed since the
> > recent version bump. This patch fixes the bug downstream.
>
> Which "recent" version bump ?
I meant the latest version bump in buildroot, so effectively the bump from
version 4.5 to commit 1ba33c3325df48de46263276a43ed76cf9d81518.
The bug was introduced by the upstream commit
f048a83da348c1d62204fcbdf407b7abf33e3db0 AFAIR.
> The last commit on package/dcron/ in Builroot is from January 2021, I
> wouldn't call it recent. It bumped from version 4.5 to
> 1ba33c3325df48de46263276a43ed76cf9d81518, while switching to
> https://github.com/dubiousjim/dcron/ as the upstream location.
>
> Is it this version bump that broke things?
Yes.
> Could you use "git format-patch" to generate this patch, and include in
> it a reference to the upstream pull request
> https://github.com/dubiousjim/dcron/pull/35.
I prepared an updated version of the patch. I hope you are satisfied with the
update. If there is something I missed, just tell. It's my first patch to
buildroot, so I'm not familiar with the procedure.
Kind Regards
Mario
[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 150 bytes --]
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-09-26 16:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-02 22:28 [Buildroot] [PATCH 1/1] package/dcron: fix /etc/cron.d/system cron jobs Mario Haustein
2022-09-24 8:30 ` Thomas Petazzoni
2022-09-26 16:15 ` Mario Haustein [this message]
2022-09-26 16:08 ` [Buildroot] [PATCH v2] " Mario Haustein
2023-04-17 6:48 ` Yann E. MORIN
2023-04-23 10:37 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3721052.kQq0lBPeGt@localdomain \
--to=mario.haustein@hrz.tu-chemnitz.de \
--cc=alvaro.gamez@hazent.com \
--cc=buildroot@buildroot.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.