* [PATCH v2 1/2] drm/radeon: Fix integer overflow in radeon_cs_parser_init
@ 2023-04-19 8:57 ` hackyzh002
0 siblings, 0 replies; 6+ messages in thread
From: hackyzh002 @ 2023-04-19 8:57 UTC (permalink / raw)
To: alexander.deucher
Cc: Xinhui.Pan, linux-kernel, amd-gfx, sumit.semwal, linaro-mm-sig,
dri-devel, daniel, hackyzh002, airlied, christian.koenig,
linux-media
The type of size is unsigned, if size is 0x40000000, there will be an
integer overflow, size will be zero after size *= sizeof(uint32_t),
will cause uninitialized memory to be referenced later
Signed-off-by: hackyzh002 <hackyzh002@gmail.com>
---
drivers/gpu/drm/radeon/radeon_cs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/radeon/radeon_cs.c b/drivers/gpu/drm/radeon/radeon_cs.c
index 46a27ebf4..8e12b406e 100644
--- a/drivers/gpu/drm/radeon/radeon_cs.c
+++ b/drivers/gpu/drm/radeon/radeon_cs.c
@@ -270,7 +270,7 @@ int radeon_cs_parser_init(struct radeon_cs_parser *p, void *data)
{
struct drm_radeon_cs *cs = data;
uint64_t *chunk_array_ptr;
- unsigned size, i;
+ u64 size, i;
u32 ring = RADEON_CS_RING_GFX;
s32 priority = 0;
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH v2 1/2] drm/radeon: Fix integer overflow in radeon_cs_parser_init
@ 2023-04-19 8:57 ` hackyzh002
0 siblings, 0 replies; 6+ messages in thread
From: hackyzh002 @ 2023-04-19 8:57 UTC (permalink / raw)
To: alexander.deucher
Cc: christian.koenig, Xinhui.Pan, airlied, daniel, sumit.semwal,
amd-gfx, dri-devel, linux-kernel, linux-media, linaro-mm-sig,
hackyzh002
The type of size is unsigned, if size is 0x40000000, there will be an
integer overflow, size will be zero after size *= sizeof(uint32_t),
will cause uninitialized memory to be referenced later
Signed-off-by: hackyzh002 <hackyzh002@gmail.com>
---
drivers/gpu/drm/radeon/radeon_cs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/radeon/radeon_cs.c b/drivers/gpu/drm/radeon/radeon_cs.c
index 46a27ebf4..8e12b406e 100644
--- a/drivers/gpu/drm/radeon/radeon_cs.c
+++ b/drivers/gpu/drm/radeon/radeon_cs.c
@@ -270,7 +270,7 @@ int radeon_cs_parser_init(struct radeon_cs_parser *p, void *data)
{
struct drm_radeon_cs *cs = data;
uint64_t *chunk_array_ptr;
- unsigned size, i;
+ u64 size, i;
u32 ring = RADEON_CS_RING_GFX;
s32 priority = 0;
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH v2 1/2] drm/radeon: Fix integer overflow in radeon_cs_parser_init
@ 2023-04-19 8:57 ` hackyzh002
0 siblings, 0 replies; 6+ messages in thread
From: hackyzh002 @ 2023-04-19 8:57 UTC (permalink / raw)
To: alexander.deucher
Cc: Xinhui.Pan, linux-kernel, amd-gfx, sumit.semwal, linaro-mm-sig,
dri-devel, hackyzh002, christian.koenig, linux-media
The type of size is unsigned, if size is 0x40000000, there will be an
integer overflow, size will be zero after size *= sizeof(uint32_t),
will cause uninitialized memory to be referenced later
Signed-off-by: hackyzh002 <hackyzh002@gmail.com>
---
drivers/gpu/drm/radeon/radeon_cs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/radeon/radeon_cs.c b/drivers/gpu/drm/radeon/radeon_cs.c
index 46a27ebf4..8e12b406e 100644
--- a/drivers/gpu/drm/radeon/radeon_cs.c
+++ b/drivers/gpu/drm/radeon/radeon_cs.c
@@ -270,7 +270,7 @@ int radeon_cs_parser_init(struct radeon_cs_parser *p, void *data)
{
struct drm_radeon_cs *cs = data;
uint64_t *chunk_array_ptr;
- unsigned size, i;
+ u64 size, i;
u32 ring = RADEON_CS_RING_GFX;
s32 priority = 0;
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v2 1/2] drm/radeon: Fix integer overflow in radeon_cs_parser_init
2023-04-19 8:57 ` hackyzh002
(?)
@ 2023-04-19 8:59 ` Christian König
-1 siblings, 0 replies; 6+ messages in thread
From: Christian König @ 2023-04-19 8:59 UTC (permalink / raw)
To: hackyzh002, alexander.deucher
Cc: Xinhui.Pan, linux-kernel, amd-gfx, linaro-mm-sig, dri-devel,
daniel, airlied, sumit.semwal, linux-media
Am 19.04.23 um 10:57 schrieb hackyzh002:
> The type of size is unsigned, if size is 0x40000000, there will be an
> integer overflow, size will be zero after size *= sizeof(uint32_t),
> will cause uninitialized memory to be referenced later
>
> Signed-off-by: hackyzh002 <hackyzh002@gmail.com>
> ---
> drivers/gpu/drm/radeon/radeon_cs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_cs.c b/drivers/gpu/drm/radeon/radeon_cs.c
> index 46a27ebf4..8e12b406e 100644
> --- a/drivers/gpu/drm/radeon/radeon_cs.c
> +++ b/drivers/gpu/drm/radeon/radeon_cs.c
> @@ -270,7 +270,7 @@ int radeon_cs_parser_init(struct radeon_cs_parser *p, void *data)
> {
> struct drm_radeon_cs *cs = data;
> uint64_t *chunk_array_ptr;
> - unsigned size, i;
> + u64 size, i;
Ok, once more: Please only change the type of the "size" variable" and
not the type of "i".
Otherwise the patch looks good to me,
Christian.
> u32 ring = RADEON_CS_RING_GFX;
> s32 priority = 0;
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2 1/2] drm/radeon: Fix integer overflow in radeon_cs_parser_init
@ 2023-04-19 8:59 ` Christian König
0 siblings, 0 replies; 6+ messages in thread
From: Christian König @ 2023-04-19 8:59 UTC (permalink / raw)
To: hackyzh002, alexander.deucher
Cc: Xinhui.Pan, airlied, daniel, sumit.semwal, amd-gfx, dri-devel,
linux-kernel, linux-media, linaro-mm-sig
Am 19.04.23 um 10:57 schrieb hackyzh002:
> The type of size is unsigned, if size is 0x40000000, there will be an
> integer overflow, size will be zero after size *= sizeof(uint32_t),
> will cause uninitialized memory to be referenced later
>
> Signed-off-by: hackyzh002 <hackyzh002@gmail.com>
> ---
> drivers/gpu/drm/radeon/radeon_cs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_cs.c b/drivers/gpu/drm/radeon/radeon_cs.c
> index 46a27ebf4..8e12b406e 100644
> --- a/drivers/gpu/drm/radeon/radeon_cs.c
> +++ b/drivers/gpu/drm/radeon/radeon_cs.c
> @@ -270,7 +270,7 @@ int radeon_cs_parser_init(struct radeon_cs_parser *p, void *data)
> {
> struct drm_radeon_cs *cs = data;
> uint64_t *chunk_array_ptr;
> - unsigned size, i;
> + u64 size, i;
Ok, once more: Please only change the type of the "size" variable" and
not the type of "i".
Otherwise the patch looks good to me,
Christian.
> u32 ring = RADEON_CS_RING_GFX;
> s32 priority = 0;
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2 1/2] drm/radeon: Fix integer overflow in radeon_cs_parser_init
@ 2023-04-19 8:59 ` Christian König
0 siblings, 0 replies; 6+ messages in thread
From: Christian König @ 2023-04-19 8:59 UTC (permalink / raw)
To: hackyzh002, alexander.deucher
Cc: Xinhui.Pan, linux-kernel, amd-gfx, linaro-mm-sig, dri-devel,
sumit.semwal, linux-media
Am 19.04.23 um 10:57 schrieb hackyzh002:
> The type of size is unsigned, if size is 0x40000000, there will be an
> integer overflow, size will be zero after size *= sizeof(uint32_t),
> will cause uninitialized memory to be referenced later
>
> Signed-off-by: hackyzh002 <hackyzh002@gmail.com>
> ---
> drivers/gpu/drm/radeon/radeon_cs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_cs.c b/drivers/gpu/drm/radeon/radeon_cs.c
> index 46a27ebf4..8e12b406e 100644
> --- a/drivers/gpu/drm/radeon/radeon_cs.c
> +++ b/drivers/gpu/drm/radeon/radeon_cs.c
> @@ -270,7 +270,7 @@ int radeon_cs_parser_init(struct radeon_cs_parser *p, void *data)
> {
> struct drm_radeon_cs *cs = data;
> uint64_t *chunk_array_ptr;
> - unsigned size, i;
> + u64 size, i;
Ok, once more: Please only change the type of the "size" variable" and
not the type of "i".
Otherwise the patch looks good to me,
Christian.
> u32 ring = RADEON_CS_RING_GFX;
> s32 priority = 0;
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-04-20 7:14 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-19 8:57 [PATCH v2 1/2] drm/radeon: Fix integer overflow in radeon_cs_parser_init hackyzh002
2023-04-19 8:57 ` hackyzh002
2023-04-19 8:57 ` hackyzh002
2023-04-19 8:59 ` Christian König
2023-04-19 8:59 ` Christian König
2023-04-19 8:59 ` Christian König
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.