From: Jakub Kicinski <kuba@kernel.org>
To: Alexander Lobakin <aleksander.lobakin@intel.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
intel-wired-lan@lists.osuosl.org
Subject: Re: [Intel-wired-lan] [PATCH net-next] iavf: remove double underscores from states names
Date: Thu, 20 Apr 2023 07:59:43 -0700 [thread overview]
Message-ID: <20230420075943.4ef9b68a@kernel.org> (raw)
In-Reply-To: <21b89328-8c74-596b-3cfe-e71affd193a8@intel.com>
On Thu, 20 Apr 2023 16:33:54 +0200 Alexander Lobakin wrote:
> > No need to prepend some states names with "__", especially that others do
> > not have these underscores.
>
> What's the value of this change, apart from 400 locs diffstat? I don't
> say having prefixes for general-purpose definitions is correct, but...
> Dunno. Would be nice to have as a part of some series with assorted
> improvements, but not standalone. Or it's just me =\
Yeah, I'm not sure it's bad enough to justify the code churn, either.
Up to you folks at Intel.
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Alexander Lobakin <aleksander.lobakin@intel.com>
Cc: Ahmed Zaki <ahmed.zaki@intel.com>,
<intel-wired-lan@lists.osuosl.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [Intel-wired-lan] [PATCH net-next] iavf: remove double underscores from states names
Date: Thu, 20 Apr 2023 07:59:43 -0700 [thread overview]
Message-ID: <20230420075943.4ef9b68a@kernel.org> (raw)
In-Reply-To: <21b89328-8c74-596b-3cfe-e71affd193a8@intel.com>
On Thu, 20 Apr 2023 16:33:54 +0200 Alexander Lobakin wrote:
> > No need to prepend some states names with "__", especially that others do
> > not have these underscores.
>
> What's the value of this change, apart from 400 locs diffstat? I don't
> say having prefixes for general-purpose definitions is correct, but...
> Dunno. Would be nice to have as a part of some series with assorted
> improvements, but not standalone. Or it's just me =\
Yeah, I'm not sure it's bad enough to justify the code churn, either.
Up to you folks at Intel.
next prev parent reply other threads:[~2023-04-20 14:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-19 23:17 [Intel-wired-lan] [PATCH net-next] iavf: remove double underscores from states names Ahmed Zaki
2023-04-20 14:33 ` Alexander Lobakin
2023-04-20 14:33 ` Alexander Lobakin
2023-04-20 14:59 ` Jakub Kicinski [this message]
2023-04-20 14:59 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230420075943.4ef9b68a@kernel.org \
--to=kuba@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.