From: "Michael S. Tsirkin" <mst@redhat.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: "Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
netdev@vger.kernel.org, "Björn Töpel" <bjorn@kernel.org>,
"Magnus Karlsson" <magnus.karlsson@intel.com>,
"Maciej Fijalkowski" <maciej.fijalkowski@intel.com>,
"Jonathan Lemon" <jonathan.lemon@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Jesper Dangaard Brouer" <hawk@kernel.org>,
"John Fastabend" <john.fastabend@gmail.com>,
bpf@vger.kernel.org, virtualization@lists.linux-foundation.org,
"Jason Wang" <jasowang@redhat.com>,
"Guenter Roeck" <linux@roeck-us.net>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Christoph Hellwig" <hch@infradead.org>
Subject: Re: [PATCH net-next v1] xsk: introduce xsk_dma_cbs
Date: Sun, 23 Apr 2023 16:42:07 -0400 [thread overview]
Message-ID: <20230423161828-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <ZETUAMqKc8iLhTk3@kroah.com>
On Sun, Apr 23, 2023 at 08:45:20AM +0200, Greg KH wrote:
> On Sun, Apr 23, 2023 at 02:25:45PM +0800, Xuan Zhuo wrote:
> > The purpose of this patch is to allow driver pass the own dma callbacks
> > to xsk.
> >
> > This is to cope with the scene of virtio-net. If virtio does not have
> > VIRTIO_F_ACCESS_PLATFORM, then virtio cannot use DMA API. In this case,
> > xsk cannot use DMA API directly to achieve DMA address. Based on this
> > scene, we must let xsk support driver to use the driver's dma callbacks.
>
> Why does virtio need to use dma? That seems to go against the overall
> goal of virtio's new security restrictions that are being proposed
> (where they do NOT want it to use dma as it is not secure).
Yes, they exactly use dma, specifically dma into bounce buffer.
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: "Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
"Maciej Fijalkowski" <maciej.fijalkowski@intel.com>,
"Jesper Dangaard Brouer" <hawk@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
netdev@vger.kernel.org,
"John Fastabend" <john.fastabend@gmail.com>,
"Eric Dumazet" <edumazet@google.com>,
"Alexei Starovoitov" <ast@kernel.org>,
"Christoph Hellwig" <hch@infradead.org>,
"Björn Töpel" <bjorn@kernel.org>,
"Guenter Roeck" <linux@roeck-us.net>,
"Jonathan Lemon" <jonathan.lemon@gmail.com>,
"Jakub Kicinski" <kuba@kernel.org>,
bpf@vger.kernel.org, "Paolo Abeni" <pabeni@redhat.com>,
virtualization@lists.linux-foundation.org,
"David S. Miller" <davem@davemloft.net>,
"Magnus Karlsson" <magnus.karlsson@intel.com>
Subject: Re: [PATCH net-next v1] xsk: introduce xsk_dma_cbs
Date: Sun, 23 Apr 2023 16:42:07 -0400 [thread overview]
Message-ID: <20230423161828-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <ZETUAMqKc8iLhTk3@kroah.com>
On Sun, Apr 23, 2023 at 08:45:20AM +0200, Greg KH wrote:
> On Sun, Apr 23, 2023 at 02:25:45PM +0800, Xuan Zhuo wrote:
> > The purpose of this patch is to allow driver pass the own dma callbacks
> > to xsk.
> >
> > This is to cope with the scene of virtio-net. If virtio does not have
> > VIRTIO_F_ACCESS_PLATFORM, then virtio cannot use DMA API. In this case,
> > xsk cannot use DMA API directly to achieve DMA address. Based on this
> > scene, we must let xsk support driver to use the driver's dma callbacks.
>
> Why does virtio need to use dma? That seems to go against the overall
> goal of virtio's new security restrictions that are being proposed
> (where they do NOT want it to use dma as it is not secure).
Yes, they exactly use dma, specifically dma into bounce buffer.
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2023-04-23 20:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-23 6:25 [PATCH net-next v1] xsk: introduce xsk_dma_cbs Xuan Zhuo
2023-04-23 6:25 ` Xuan Zhuo
2023-04-23 6:45 ` Greg KH
2023-04-23 6:45 ` Greg KH
2023-04-23 6:58 ` Xuan Zhuo
2023-04-23 6:58 ` Xuan Zhuo
2023-04-23 8:39 ` Greg KH
2023-04-23 8:39 ` Greg KH
2023-04-23 9:13 ` Xuan Zhuo
2023-04-23 9:13 ` Xuan Zhuo
2023-04-23 20:42 ` Michael S. Tsirkin [this message]
2023-04-23 20:42 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230423161828-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=ast@kernel.org \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hawk@kernel.org \
--cc=hch@infradead.org \
--cc=jasowang@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=jonathan.lemon@gmail.com \
--cc=kraxel@redhat.com \
--cc=kuba@kernel.org \
--cc=linux@roeck-us.net \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.