All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Parav Pandit <parav@nvidia.com>
Cc: "virtio-comment@lists.oasis-open.org"
	<virtio-comment@lists.oasis-open.org>,
	"virtio-dev@lists.oasis-open.org"
	<virtio-dev@lists.oasis-open.org>,
	"jasowang@redhat.com" <jasowang@redhat.com>,
	"cohuck@redhat.com" <cohuck@redhat.com>,
	"sgarzare@redhat.com" <sgarzare@redhat.com>,
	"stefanha@redhat.com" <stefanha@redhat.com>,
	"nrupal.jani@intel.com" <nrupal.jani@intel.com>,
	"Piotr.Uminski@intel.com" <Piotr.Uminski@intel.com>,
	"hang.yuan@intel.com" <hang.yuan@intel.com>,
	"virtio@lists.oasis-open.org" <virtio@lists.oasis-open.org>,
	Jiri Pirko <jiri@nvidia.com>,
	Zhu Lingshan <lingshan.zhu@intel.com>,
	"pasic@linux.ibm.com" <pasic@linux.ibm.com>,
	Shahaf Shuler <shahafs@nvidia.com>,
	Max Gurtovoy <mgurtovoy@nvidia.com>
Subject: [virtio-comment] Re: [PATCH v12 03/10] admin: introduce group administration commands
Date: Tue, 25 Apr 2023 16:04:57 -0400	[thread overview]
Message-ID: <20230425160346-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <PH0PR12MB5481BB7BCD1D9FF68395633BDC649@PH0PR12MB5481.namprd12.prod.outlook.com>

On Tue, Apr 25, 2023 at 01:38:21PM +0000, Parav Pandit wrote:
> 
> 
> > From: Michael S. Tsirkin <mst@redhat.com>
> > Sent: Tuesday, April 25, 2023 9:32 AM
> 
> > > I am requesting to drop the commit point that limits the usage of the AQ.
> > > Do you agree that AQ can be extended for use beyond VF and SIOV group
> > management commands?
> > > Or one should create a new VQ type?
> > > If it is the later, I don't see the need of multiple AQ.
> > 
> > not management. that is old term and indeed too narrow.
> > administration as in hypervisor (admin) access through PF while guest has
> > access through VF.
> > 
> > legacy access you link to below seems to fall within scope:
> > we access VF through a PF.
> > 
> > So what is the problem?
> >
> Commit log confused me. You clarified above.
> It is clear now. Hence no problem.
>  
> > maybe we'll change the meaning down the road. I do not see the immediate
> > need currently though.
> > 
> As long as we agree that it is open to widen the scope, it is acceptable.
> 
> > > [1]
> > > https://lists.oasis-open.org/archives/virtio-dev/202304/msg00511.html
> > 
> > Then I don't see a problem. It's just commit log, not spec. Let it slide is my
> > suggestion, this is spec text not code.
> 
> Ok. I feel it is still worth to have commit log updated. If you happen to revise v13, please do.
> Else its fine.
> 
> v12 surely doesn't merge cleanly. So v13 is needed anyway.
> 
> Can you please generate? Patch-5 of v12 fails to apply.

should apply on top of 985bbf397db4228faf3ec464e838687dc4cb4904.  master
will fail because of the file movement.  I will need to rebase to apply
on latest master, I will do it before we start voting.

-- 
MST


This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/


WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Parav Pandit <parav@nvidia.com>
Cc: "virtio-comment@lists.oasis-open.org"
	<virtio-comment@lists.oasis-open.org>,
	"virtio-dev@lists.oasis-open.org"
	<virtio-dev@lists.oasis-open.org>,
	"jasowang@redhat.com" <jasowang@redhat.com>,
	"cohuck@redhat.com" <cohuck@redhat.com>,
	"sgarzare@redhat.com" <sgarzare@redhat.com>,
	"stefanha@redhat.com" <stefanha@redhat.com>,
	"nrupal.jani@intel.com" <nrupal.jani@intel.com>,
	"Piotr.Uminski@intel.com" <Piotr.Uminski@intel.com>,
	"hang.yuan@intel.com" <hang.yuan@intel.com>,
	"virtio@lists.oasis-open.org" <virtio@lists.oasis-open.org>,
	Jiri Pirko <jiri@nvidia.com>,
	Zhu Lingshan <lingshan.zhu@intel.com>,
	"pasic@linux.ibm.com" <pasic@linux.ibm.com>,
	Shahaf Shuler <shahafs@nvidia.com>,
	Max Gurtovoy <mgurtovoy@nvidia.com>
Subject: [virtio-dev] Re: [PATCH v12 03/10] admin: introduce group administration commands
Date: Tue, 25 Apr 2023 16:04:57 -0400	[thread overview]
Message-ID: <20230425160346-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <PH0PR12MB5481BB7BCD1D9FF68395633BDC649@PH0PR12MB5481.namprd12.prod.outlook.com>

On Tue, Apr 25, 2023 at 01:38:21PM +0000, Parav Pandit wrote:
> 
> 
> > From: Michael S. Tsirkin <mst@redhat.com>
> > Sent: Tuesday, April 25, 2023 9:32 AM
> 
> > > I am requesting to drop the commit point that limits the usage of the AQ.
> > > Do you agree that AQ can be extended for use beyond VF and SIOV group
> > management commands?
> > > Or one should create a new VQ type?
> > > If it is the later, I don't see the need of multiple AQ.
> > 
> > not management. that is old term and indeed too narrow.
> > administration as in hypervisor (admin) access through PF while guest has
> > access through VF.
> > 
> > legacy access you link to below seems to fall within scope:
> > we access VF through a PF.
> > 
> > So what is the problem?
> >
> Commit log confused me. You clarified above.
> It is clear now. Hence no problem.
>  
> > maybe we'll change the meaning down the road. I do not see the immediate
> > need currently though.
> > 
> As long as we agree that it is open to widen the scope, it is acceptable.
> 
> > > [1]
> > > https://lists.oasis-open.org/archives/virtio-dev/202304/msg00511.html
> > 
> > Then I don't see a problem. It's just commit log, not spec. Let it slide is my
> > suggestion, this is spec text not code.
> 
> Ok. I feel it is still worth to have commit log updated. If you happen to revise v13, please do.
> Else its fine.
> 
> v12 surely doesn't merge cleanly. So v13 is needed anyway.
> 
> Can you please generate? Patch-5 of v12 fails to apply.

should apply on top of 985bbf397db4228faf3ec464e838687dc4cb4904.  master
will fail because of the file movement.  I will need to rebase to apply
on latest master, I will do it before we start voting.

-- 
MST


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


  reply	other threads:[~2023-04-25 20:06 UTC|newest]

Thread overview: 80+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-24 16:44 [virtio-comment] [PATCH v12 00/10] Introduce device group and device management Michael S. Tsirkin
2023-04-24 16:44 ` [virtio-dev] " Michael S. Tsirkin
2023-04-24 16:44 ` [virtio-comment] [PATCH v12 01/10] virtio: document forward compatibility guarantees Michael S. Tsirkin
2023-04-24 16:44   ` [virtio-dev] " Michael S. Tsirkin
2023-04-24 16:44 ` [virtio-comment] [PATCH v12 02/10] admin: introduce device group and related concepts Michael S. Tsirkin
2023-04-24 16:44   ` [virtio-dev] " Michael S. Tsirkin
2023-04-24 21:02   ` [virtio-comment] " Max Gurtovoy
2023-04-24 21:47   ` Parav Pandit
2023-04-24 21:47     ` [virtio-dev] " Parav Pandit
2023-04-24 16:44 ` [virtio-comment] [PATCH v12 03/10] admin: introduce group administration commands Michael S. Tsirkin
2023-04-24 16:44   ` [virtio-dev] " Michael S. Tsirkin
2023-04-24 21:29   ` [virtio-comment] " Max Gurtovoy
2023-04-24 21:33     ` Michael S. Tsirkin
2023-04-24 21:33       ` [virtio-dev] " Michael S. Tsirkin
2023-04-24 22:07   ` [virtio-comment] " Parav Pandit
2023-04-24 22:07     ` [virtio-dev] " Parav Pandit
2023-04-25  6:20     ` [virtio-comment] " Michael S. Tsirkin
2023-04-25  6:20       ` [virtio-dev] " Michael S. Tsirkin
2023-04-25 13:25       ` [virtio-comment] " Parav Pandit
2023-04-25 13:25         ` [virtio-dev] " Parav Pandit
2023-04-25 13:31         ` [virtio-comment] " Michael S. Tsirkin
2023-04-25 13:31           ` [virtio-dev] " Michael S. Tsirkin
2023-04-25 13:38           ` [virtio-comment] " Parav Pandit
2023-04-25 13:38             ` [virtio-dev] " Parav Pandit
2023-04-25 20:04             ` Michael S. Tsirkin [this message]
2023-04-25 20:04               ` [virtio-dev] " Michael S. Tsirkin
2023-04-25 20:18               ` [virtio-comment] " Parav Pandit
2023-04-25 20:18                 ` [virtio-dev] " Parav Pandit
2023-04-25 20:55                 ` [virtio-comment] " Michael S. Tsirkin
2023-04-25 20:55                   ` [virtio-dev] " Michael S. Tsirkin
2023-04-26 18:18                   ` [virtio-comment] " Parav Pandit
2023-04-26 18:18                     ` [virtio-dev] " Parav Pandit
2023-04-24 16:44 ` [virtio-comment] [PATCH v12 04/10] admin: introduce virtio admin virtqueues Michael S. Tsirkin
2023-04-24 16:44   ` [virtio-dev] " Michael S. Tsirkin
2023-04-24 22:32   ` [virtio-comment] " Parav Pandit
2023-04-24 22:32     ` [virtio-dev] " Parav Pandit
2023-04-24 16:44 ` [virtio-comment] [PATCH v12 05/10] pci: add admin vq registers to virtio over pci Michael S. Tsirkin
2023-04-24 16:44   ` [virtio-dev] " Michael S. Tsirkin
2023-04-24 22:06   ` [virtio-comment] " Max Gurtovoy
2023-04-24 22:14     ` Parav Pandit
2023-04-24 22:14       ` [virtio-dev] " Parav Pandit
2023-04-26 21:12       ` [virtio-comment] " Max Gurtovoy
2023-04-26 22:11         ` [virtio-comment] " Parav Pandit
2023-04-26 22:11           ` [virtio-dev] " Parav Pandit
2023-04-26 22:31           ` [virtio-comment] " Max Gurtovoy
2023-04-27  0:11             ` [virtio-comment] " Parav Pandit
2023-04-27  0:11               ` [virtio-dev] " Parav Pandit
2023-05-05 15:12               ` [virtio-comment] " Michael S. Tsirkin
2023-05-05 15:12                 ` [virtio-dev] " Michael S. Tsirkin
2023-05-05 15:14                 ` [virtio-comment] " Parav Pandit
2023-05-05 15:14                   ` [virtio-dev] " Parav Pandit
2023-04-27 17:57             ` [virtio-comment] " Michael S. Tsirkin
2023-04-27 17:57               ` [virtio-dev] " Michael S. Tsirkin
2023-04-27 18:50               ` [virtio-comment] " Max Gurtovoy
2023-05-05 15:22           ` Michael S. Tsirkin
2023-05-05 15:22             ` [virtio-dev] " Michael S. Tsirkin
2023-05-05 15:25             ` [virtio-comment] " Parav Pandit
2023-05-05 15:25               ` [virtio-dev] " Parav Pandit
2023-04-24 22:29   ` [virtio-comment] " Parav Pandit
2023-04-24 22:29     ` [virtio-dev] " Parav Pandit
2023-04-24 16:44 ` [virtio-comment] [PATCH v12 06/10] mmio: document ADMIN_VQ as reserved Michael S. Tsirkin
2023-04-24 16:44   ` [virtio-dev] " Michael S. Tsirkin
2023-04-24 22:08   ` [virtio-comment] " Max Gurtovoy
2023-04-24 16:44 ` [virtio-comment] [PATCH v12 07/10] ccw: " Michael S. Tsirkin
2023-04-24 16:44   ` [virtio-dev] " Michael S. Tsirkin
2023-04-24 22:09   ` [virtio-comment] " Max Gurtovoy
2023-04-24 16:44 ` [virtio-comment] [PATCH v12 08/10] admin: command list discovery Michael S. Tsirkin
2023-04-24 16:44   ` [virtio-dev] " Michael S. Tsirkin
2023-04-24 22:27   ` [virtio-comment] " Parav Pandit
2023-04-24 22:27     ` [virtio-dev] " Parav Pandit
2023-04-24 16:44 ` [virtio-comment] [PATCH v12 09/10] admin: conformance clauses Michael S. Tsirkin
2023-04-24 16:44   ` [virtio-dev] " Michael S. Tsirkin
2023-04-24 16:44 ` [virtio-comment] [PATCH v12 10/10] ccw: document more reserved features Michael S. Tsirkin
2023-04-24 16:44   ` [virtio-dev] " Michael S. Tsirkin
2023-04-24 22:17   ` [virtio-comment] " Parav Pandit
2023-04-24 22:17     ` [virtio-dev] " Parav Pandit
2023-04-24 21:34 ` [virtio-comment] Re: [PATCH v12 00/10] Introduce device group and device management Parav Pandit
2023-04-24 21:34   ` [virtio-dev] " Parav Pandit
2023-05-02  7:51 ` [virtio-comment] Re: [virtio] " David Edmondson
2023-05-02  7:51   ` [virtio-dev] " David Edmondson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230425160346-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=Piotr.Uminski@intel.com \
    --cc=cohuck@redhat.com \
    --cc=hang.yuan@intel.com \
    --cc=jasowang@redhat.com \
    --cc=jiri@nvidia.com \
    --cc=lingshan.zhu@intel.com \
    --cc=mgurtovoy@nvidia.com \
    --cc=nrupal.jani@intel.com \
    --cc=parav@nvidia.com \
    --cc=pasic@linux.ibm.com \
    --cc=sgarzare@redhat.com \
    --cc=shahafs@nvidia.com \
    --cc=stefanha@redhat.com \
    --cc=virtio-comment@lists.oasis-open.org \
    --cc=virtio-dev@lists.oasis-open.org \
    --cc=virtio@lists.oasis-open.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.