From: Chris Morgan <macroalpha82@gmail.com>
To: dri-devel@lists.freedesktop.org
Cc: devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org,
robh+dt@kernel.org, daniel@ffwll.ch, airlied@gmail.com,
sam@ravnborg.org, neil.armstrong@linaro.org, megous@megous.com,
kernel@puri.sm, agx@sigxcpu.org,
Chris Morgan <macromorgan@hotmail.com>
Subject: [PATCH V3 2/3] drm/panel: st7703: Rename CMD_UNKNOWN_C6 to CMD_SETECO
Date: Wed, 26 Apr 2023 09:32:12 -0500 [thread overview]
Message-ID: <20230426143213.4178586-3-macroalpha82@gmail.com> (raw)
In-Reply-To: <20230426143213.4178586-1-macroalpha82@gmail.com>
From: Chris Morgan <macromorgan@hotmail.com>
A later revision of the datasheet for the ST7703 refers to this command
as "SETECO".
Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
Reviewed-by: Guido Günther <agx@sigxcpu.org>
---
drivers/gpu/drm/panel/panel-sitronix-st7703.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7703.c b/drivers/gpu/drm/panel/panel-sitronix-st7703.c
index 6747ca237ced..fc55b5fbb67f 100644
--- a/drivers/gpu/drm/panel/panel-sitronix-st7703.c
+++ b/drivers/gpu/drm/panel/panel-sitronix-st7703.c
@@ -41,8 +41,8 @@
#define ST7703_CMD_UNKNOWN_BF 0xBF
#define ST7703_CMD_SETSCR 0xC0
#define ST7703_CMD_SETPOWER 0xC1
+#define ST7703_CMD_SETECO 0xC6
#define ST7703_CMD_SETPANEL 0xCC
-#define ST7703_CMD_UNKNOWN_C6 0xC6
#define ST7703_CMD_SETGAMMA 0xE0
#define ST7703_CMD_SETEQ 0xE3
#define ST7703_CMD_SETGIP1 0xE9
@@ -249,8 +249,7 @@ static int xbd599_init_sequence(struct st7703 *ctx)
* ESD_DET_TIME_SEL = 0 frames
*/);
- /* Undocumented command. */
- mipi_dsi_dcs_write_seq(dsi, ST7703_CMD_UNKNOWN_C6, 0x01, 0x00, 0xFF, 0xFF, 0x00);
+ mipi_dsi_dcs_write_seq(dsi, ST7703_CMD_SETECO, 0x01, 0x00, 0xFF, 0xFF, 0x00);
mipi_dsi_dcs_write_seq(dsi, ST7703_CMD_SETPOWER,
0x74, /* VBTHS, VBTLS: VGH = 17V, VBL = -11V */
--
2.34.1
WARNING: multiple messages have this Message-ID (diff)
From: Chris Morgan <macroalpha82@gmail.com>
To: dri-devel@lists.freedesktop.org
Cc: megous@megous.com, devicetree@vger.kernel.org,
krzysztof.kozlowski+dt@linaro.org, neil.armstrong@linaro.org,
agx@sigxcpu.org, Chris Morgan <macromorgan@hotmail.com>,
robh+dt@kernel.org, sam@ravnborg.org, kernel@puri.sm
Subject: [PATCH V3 2/3] drm/panel: st7703: Rename CMD_UNKNOWN_C6 to CMD_SETECO
Date: Wed, 26 Apr 2023 09:32:12 -0500 [thread overview]
Message-ID: <20230426143213.4178586-3-macroalpha82@gmail.com> (raw)
In-Reply-To: <20230426143213.4178586-1-macroalpha82@gmail.com>
From: Chris Morgan <macromorgan@hotmail.com>
A later revision of the datasheet for the ST7703 refers to this command
as "SETECO".
Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
Reviewed-by: Guido Günther <agx@sigxcpu.org>
---
drivers/gpu/drm/panel/panel-sitronix-st7703.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7703.c b/drivers/gpu/drm/panel/panel-sitronix-st7703.c
index 6747ca237ced..fc55b5fbb67f 100644
--- a/drivers/gpu/drm/panel/panel-sitronix-st7703.c
+++ b/drivers/gpu/drm/panel/panel-sitronix-st7703.c
@@ -41,8 +41,8 @@
#define ST7703_CMD_UNKNOWN_BF 0xBF
#define ST7703_CMD_SETSCR 0xC0
#define ST7703_CMD_SETPOWER 0xC1
+#define ST7703_CMD_SETECO 0xC6
#define ST7703_CMD_SETPANEL 0xCC
-#define ST7703_CMD_UNKNOWN_C6 0xC6
#define ST7703_CMD_SETGAMMA 0xE0
#define ST7703_CMD_SETEQ 0xE3
#define ST7703_CMD_SETGIP1 0xE9
@@ -249,8 +249,7 @@ static int xbd599_init_sequence(struct st7703 *ctx)
* ESD_DET_TIME_SEL = 0 frames
*/);
- /* Undocumented command. */
- mipi_dsi_dcs_write_seq(dsi, ST7703_CMD_UNKNOWN_C6, 0x01, 0x00, 0xFF, 0xFF, 0x00);
+ mipi_dsi_dcs_write_seq(dsi, ST7703_CMD_SETECO, 0x01, 0x00, 0xFF, 0xFF, 0x00);
mipi_dsi_dcs_write_seq(dsi, ST7703_CMD_SETPOWER,
0x74, /* VBTHS, VBTLS: VGH = 17V, VBL = -11V */
--
2.34.1
next prev parent reply other threads:[~2023-04-26 14:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 14:32 [PATCH V3 0/3] drm/panel: Add Anbernic RG353V-V2 Panel Chris Morgan
2023-04-26 14:32 ` Chris Morgan
2023-04-26 14:32 ` [PATCH V3 1/3] dt-bindings: panel: Add Anbernic RG353V-V2 panel compatible Chris Morgan
2023-04-26 14:32 ` Chris Morgan
2023-04-26 14:54 ` Guido Günther
2023-06-06 6:12 ` Frank Oltmanns
2023-08-06 12:41 ` Frank Oltmanns
2023-04-26 14:32 ` Chris Morgan [this message]
2023-04-26 14:32 ` [PATCH V3 2/3] drm/panel: st7703: Rename CMD_UNKNOWN_C6 to CMD_SETECO Chris Morgan
2023-04-26 14:32 ` [PATCH V3 3/3] drm/panel: st7703: Add Anbernic RG353V-V2 Panel Support Chris Morgan
2023-04-26 14:32 ` Chris Morgan
2023-04-27 11:47 ` [PATCH V3 0/3] drm/panel: Add Anbernic RG353V-V2 Panel Neil Armstrong
2023-04-27 11:47 ` Neil Armstrong
2023-04-27 11:49 ` Neil Armstrong
2023-04-27 11:49 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230426143213.4178586-3-macroalpha82@gmail.com \
--to=macroalpha82@gmail.com \
--cc=agx@sigxcpu.org \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@puri.sm \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=macromorgan@hotmail.com \
--cc=megous@megous.com \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.