From: Lee Jones <lee@kernel.org>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Xu Yilun <yilun.xu@intel.com>, Wu Hao <hao.wu@intel.com>,
Tom Rix <trix@redhat.com>, Moritz Fischer <mdf@kernel.org>,
linux-fpga@vger.kernel.org, Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Russ Weight <russell.h.weight@intel.com>,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/4] mfd: intel-m10-bmc: Move m10bmc_sys_read() away from header
Date: Thu, 27 Apr 2023 16:06:23 +0100 [thread overview]
Message-ID: <20230427150623.GU50521@google.com> (raw)
In-Reply-To: <20230417092653.16487-4-ilpo.jarvinen@linux.intel.com>
On Mon, 17 Apr 2023, Ilpo Järvinen wrote:
> Move m10bmc_sys_read() out from the header to prepare it for adding
> more code into the function which would make it too large to be a
> static inline any more.
>
> While at it, replace the vague wording in function comment with more
> precise statements.
>
> Reviewed-by: Russ Weight <russell.h.weight@intel.com>
> Acked-by: Guenter Roeck <linux@roeck-us.net> # For hwmon
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---
> drivers/hwmon/intel-m10-bmc-hwmon.c | 1 +
> drivers/mfd/intel-m10-bmc-core.c | 14 ++++++++++++++
> include/linux/mfd/intel-m10-bmc.h | 17 +----------------
> 3 files changed, 16 insertions(+), 16 deletions(-)
Applied, thanks
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2023-04-27 15:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 9:26 [PATCH v3 0/4] intel-m10-bmc: Manage register access to control delay during sec update Ilpo Järvinen
2023-04-17 9:26 ` [PATCH v3 1/4] mfd: intel-m10-bmc: Move core symbols to own namespace Ilpo Järvinen
2023-04-20 16:08 ` Xu Yilun
2023-04-27 15:05 ` Lee Jones
2023-04-17 9:26 ` [PATCH v3 2/4] mfd: intel-m10-bmc: Create m10bmc_sys_update_bits() Ilpo Järvinen
2023-04-20 16:09 ` Xu Yilun
2023-04-21 9:52 ` Xu Yilun
2023-04-27 15:05 ` Lee Jones
2023-04-17 9:26 ` [PATCH v3 3/4] mfd: intel-m10-bmc: Move m10bmc_sys_read() away from header Ilpo Järvinen
2023-04-20 16:10 ` Xu Yilun
2023-04-27 15:06 ` Lee Jones [this message]
2023-04-17 9:26 ` [PATCH v3 4/4] mfd: intel-m10-bmc: Manage access to MAX 10 fw handshake registers Ilpo Järvinen
2023-04-20 16:07 ` Xu Yilun
2023-04-20 11:13 ` Lee Jones
2023-04-21 9:52 ` Xu Yilun
2023-04-27 15:07 ` Lee Jones
2023-05-10 11:51 ` Ilpo Järvinen
2023-05-15 10:06 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230427150623.GU50521@google.com \
--to=lee@kernel.org \
--cc=hao.wu@intel.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jdelvare@suse.com \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mdf@kernel.org \
--cc=russell.h.weight@intel.com \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.