From: Tomas Mudrunka <tomas.mudrunka@gmail.com>
To: jeff@labundy.com
Cc: dmitry.torokhov@gmail.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, tomas.mudrunka@gmail.com
Subject: [PATCH v4] Fix freeze in lm8333 i2c keyboard driver
Date: Fri, 28 Apr 2023 12:20:15 +0200 [thread overview]
Message-ID: <20230428102015.810686-1-tomas.mudrunka@gmail.com> (raw)
In-Reply-To: <ZEnErxfnSn2JOpvm@nixie71>
LM8333 uses gpio interrupt line which is triggered by falling edge.
When button is pressed before driver is loaded,
driver will miss the edge and never respond again.
To fix this we run the interrupt handler after registering IRQ
to clear the interrupt via i2c command.
Signed-off-by: Tomas Mudrunka <tomas.mudrunka@gmail.com>
---
drivers/input/keyboard/lm8333.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/input/keyboard/lm8333.c b/drivers/input/keyboard/lm8333.c
index 7457c3220..9a810ca00 100644
--- a/drivers/input/keyboard/lm8333.c
+++ b/drivers/input/keyboard/lm8333.c
@@ -184,6 +184,8 @@ static int lm8333_probe(struct i2c_client *client)
if (err)
goto free_mem;
+ lm8333_irq_thread(client->irq, lm8333);
+
err = input_register_device(input);
if (err)
goto free_irq;
--
2.40.0
next prev parent reply other threads:[~2023-04-28 10:20 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-25 13:00 [PATCH] Fix freeze in lm8333 i2c keyboard driver Tomas Mudrunka
2023-04-25 15:39 ` Jeff LaBundy
2023-04-25 16:49 ` [PATCH v2] " Tomas Mudrunka
2023-04-27 0:41 ` Jeff LaBundy
2023-04-27 8:13 ` Tomáš Mudruňka
2023-04-27 18:47 ` Jeff LaBundy
2023-04-28 10:09 ` [PATCH v3] " Tomas Mudrunka
2023-04-28 10:20 ` Tomas Mudrunka [this message]
2023-05-03 3:02 ` [PATCH v4] " Jeff LaBundy
2023-05-03 8:54 ` Tomáš Mudruňka
2023-05-03 15:32 ` [PATCH v5] " Tomas Mudrunka
2023-05-04 1:44 ` Jeff LaBundy
2023-05-11 23:44 ` Dmitry Torokhov
2023-05-12 16:54 ` Jeff LaBundy
2023-05-12 16:55 ` Tomáš Mudruňka
2023-05-12 17:28 ` Jeff LaBundy
2023-11-14 12:30 ` [PATCH v6] " Tomas Mudrunka
2023-12-14 2:24 ` Jeff LaBundy
2023-12-15 15:56 ` [PATCH v7] " Tomas Mudrunka
2025-02-19 14:51 ` Tomas Mudrunka
2023-04-26 23:16 ` [PATCH] " Dmitry Torokhov
2023-04-27 0:27 ` Jeff LaBundy
2023-04-27 8:19 ` Tomáš Mudruňka
2023-04-27 18:54 ` Jeff LaBundy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230428102015.810686-1-tomas.mudrunka@gmail.com \
--to=tomas.mudrunka@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jeff@labundy.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.