All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Valentin Caron <valentin.caron@foss.st.com>
Cc: Mark Brown <broonie@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Alain Volmat <alain.volmat@foss.st.com>,
	linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/7] dt-bindings: spi: stm32: add bindings regarding stm32h7 spi slave
Date: Fri, 28 Apr 2023 16:46:07 -0500	[thread overview]
Message-ID: <20230428214607.GA326858-robh@kernel.org> (raw)
In-Reply-To: <20230428121524.2125832-5-valentin.caron@foss.st.com>

On Fri, Apr 28, 2023 at 02:15:21PM +0200, Valentin Caron wrote:
> From: Alain Volmat <alain.volmat@foss.st.com>
> 
> Update the spi-stm32 binding yaml regarding to the SPI slave support.

Why? What problem are you trying to solve.

> 
> Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
> Signed-off-by: Valentin Caron <valentin.caron@foss.st.com>
> ---
>  Documentation/devicetree/bindings/spi/st,stm32-spi.yaml | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml b/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml
> index c599eb359d56..1d26fa2658c5 100644
> --- a/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml
> +++ b/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml
> @@ -27,6 +27,7 @@ allOf:
>      then:
>        properties:
>          st,spi-midi-ns: false
> +        spi-slave: false
>  
>  properties:
>    "#address-cells": true
> @@ -62,6 +63,13 @@ properties:
>        - const: rx
>        - const: tx
>  
> +  cs-gpios:
> +    description:
> +      In case of spi-slave not defined, cs-gpios behave as defined in
> +      spi-controller.yaml.
> +      In case of spi-slave defined, if <0>, indicate that SS should be
> +      detected via the dedicated HW pin

I don't understand. I though cs-gpios was for master mode. You want to 
define 'cs-gpios = <0>;'? How would that be different than just omitting 
cs-gpios?

Rob

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Valentin Caron <valentin.caron@foss.st.com>
Cc: Mark Brown <broonie@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Alain Volmat <alain.volmat@foss.st.com>,
	linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/7] dt-bindings: spi: stm32: add bindings regarding stm32h7 spi slave
Date: Fri, 28 Apr 2023 16:46:07 -0500	[thread overview]
Message-ID: <20230428214607.GA326858-robh@kernel.org> (raw)
In-Reply-To: <20230428121524.2125832-5-valentin.caron@foss.st.com>

On Fri, Apr 28, 2023 at 02:15:21PM +0200, Valentin Caron wrote:
> From: Alain Volmat <alain.volmat@foss.st.com>
> 
> Update the spi-stm32 binding yaml regarding to the SPI slave support.

Why? What problem are you trying to solve.

> 
> Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
> Signed-off-by: Valentin Caron <valentin.caron@foss.st.com>
> ---
>  Documentation/devicetree/bindings/spi/st,stm32-spi.yaml | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml b/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml
> index c599eb359d56..1d26fa2658c5 100644
> --- a/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml
> +++ b/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml
> @@ -27,6 +27,7 @@ allOf:
>      then:
>        properties:
>          st,spi-midi-ns: false
> +        spi-slave: false
>  
>  properties:
>    "#address-cells": true
> @@ -62,6 +63,13 @@ properties:
>        - const: rx
>        - const: tx
>  
> +  cs-gpios:
> +    description:
> +      In case of spi-slave not defined, cs-gpios behave as defined in
> +      spi-controller.yaml.
> +      In case of spi-slave defined, if <0>, indicate that SS should be
> +      detected via the dedicated HW pin

I don't understand. I though cs-gpios was for master mode. You want to 
define 'cs-gpios = <0>;'? How would that be different than just omitting 
cs-gpios?

Rob

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-04-28 21:46 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-28 12:15 [PATCH 0/7] spi: stm32: add spi slave mode Valentin Caron
2023-04-28 12:15 ` Valentin Caron
2023-04-28 12:15 ` [PATCH 1/7] dt-bindings: spi: stm32: add address-cells and size-cells into yaml Valentin Caron
2023-04-28 12:15   ` Valentin Caron
2023-04-28 21:41   ` Rob Herring
2023-04-28 21:41     ` Rob Herring
2023-05-04 17:09     ` Valentin CARON
2023-05-04 17:09       ` Valentin CARON
2023-04-28 12:15 ` [PATCH 2/7] spi: stm32: renaming of spi_master into spi_controller Valentin Caron
2023-04-28 12:15   ` Valentin Caron
2023-04-28 12:15 ` [PATCH 3/7] spi: stm32: use dmaengine_terminate_{a}sync instead of _all Valentin Caron
2023-04-28 12:15   ` Valentin Caron
2023-04-28 12:15 ` [PATCH 4/7] dt-bindings: spi: stm32: add bindings regarding stm32h7 spi slave Valentin Caron
2023-04-28 12:15   ` Valentin Caron
2023-04-28 21:46   ` Rob Herring [this message]
2023-04-28 21:46     ` Rob Herring
2023-05-04 17:11     ` Valentin CARON
2023-05-04 17:11       ` Valentin CARON
2023-04-28 12:15 ` [PATCH 5/7] spi: stm32: introduction of stm32h7 SPI slave support Valentin Caron
2023-04-28 12:15   ` Valentin Caron
2023-04-28 12:15 ` [PATCH 6/7] dt-bindings: spi: stm32: add stm32h7 st,spi-slave-underrun property Valentin Caron
2023-04-28 12:15   ` Valentin Caron
2023-04-28 21:56   ` Rob Herring
2023-04-28 21:56     ` Rob Herring
2023-05-04 17:13     ` Valentin CARON
2023-05-04 17:13       ` Valentin CARON
2023-04-28 12:15 ` [PATCH 7/7] spi: stm32: add support for stm32h7 SPI slave underrun detection Valentin Caron
2023-04-28 12:15   ` Valentin Caron
2023-05-02  7:20   ` Alain Volmat
2023-05-02  7:20     ` Alain Volmat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230428214607.GA326858-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=alain.volmat@foss.st.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=valentin.caron@foss.st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.