All of lore.kernel.org
 help / color / mirror / Atom feed
* [android-common:android11-5.4 5610/25674] kernel/power/wakeup_reason.c:199:6: warning: no previous prototype for '__log_abort_or_abnormal_wake'
@ 2023-05-02 20:52 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2023-05-02 20:52 UTC (permalink / raw)
  To: cros-kernel-buildreports; +Cc: oe-kbuild-all

Hi Kelly,

FYI, the error/warning still remains.

tree:   https://android.googlesource.com/kernel/common android11-5.4
head:   edbf3d0e067c6c4acf19d8ede1aa69ef4b552fdc
commit: 189ced91cd7b0e440b0be876406fd36313a11c3f [5610/25674] ANDROID: power: wakeup_reason: wake reason enhancements
config: x86_64-defconfig (https://download.01.org/0day-ci/archive/20230503/202305030422.PU31fMGx-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-12) 11.3.0
reproduce (this is a W=1 build):
        git remote add android-common https://android.googlesource.com/kernel/common
        git fetch --no-tags android-common android11-5.4
        git checkout 189ced91cd7b0e440b0be876406fd36313a11c3f
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 olddefconfig
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash kernel/power/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202305030422.PU31fMGx-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> kernel/power/wakeup_reason.c:199:6: warning: no previous prototype for '__log_abort_or_abnormal_wake' [-Wmissing-prototypes]
     199 | void __log_abort_or_abnormal_wake(bool abort, const char *fmt, va_list args)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
   kernel/power/wakeup_reason.c: In function '__log_abort_or_abnormal_wake':
   kernel/power/wakeup_reason.c:213:9: warning: function '__log_abort_or_abnormal_wake' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
     213 |         vsnprintf(non_irq_wake_reason, MAX_SUSPEND_ABORT_LEN, fmt, args);
         |         ^~~~~~~~~
   kernel/power/wakeup_reason.c: At top level:
   kernel/power/wakeup_reason.c:378:12: warning: no previous prototype for 'wakeup_reason_init' [-Wmissing-prototypes]
     378 | int __init wakeup_reason_init(void)
         |            ^~~~~~~~~~~~~~~~~~


vim +/__log_abort_or_abnormal_wake +199 kernel/power/wakeup_reason.c

   198	
 > 199	void __log_abort_or_abnormal_wake(bool abort, const char *fmt, va_list args)
   200	{
   201		unsigned long flags;
   202	
   203		spin_lock_irqsave(&wakeup_reason_lock, flags);
   204	
   205		/* Suspend abort or abnormal wake reason has already been logged. */
   206		if (suspend_abort || abnormal_wake) {
   207			spin_unlock_irqrestore(&wakeup_reason_lock, flags);
   208			return;
   209		}
   210	
   211		suspend_abort = abort;
   212		abnormal_wake = !abort;
   213		vsnprintf(non_irq_wake_reason, MAX_SUSPEND_ABORT_LEN, fmt, args);
   214	
   215		spin_unlock_irqrestore(&wakeup_reason_lock, flags);
   216	}
   217	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-05-02 20:53 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-02 20:52 [android-common:android11-5.4 5610/25674] kernel/power/wakeup_reason.c:199:6: warning: no previous prototype for '__log_abort_or_abnormal_wake' kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.