From: Lukasz Majewski <lukma@denx.de>
To: Marek Vasut <marex@denx.de>
Cc: u-boot@lists.denx.de
Subject: Re: [PATCH] usb: gadget: Compile USB ethernet gadget only if NET is enabled
Date: Thu, 4 May 2023 11:04:45 +0200 [thread overview]
Message-ID: <20230504110445.733f58f5@wsk> (raw)
In-Reply-To: <20230430212035.379838-1-marex@denx.de>
[-- Attachment #1: Type: text/plain, Size: 1364 bytes --]
On Sun, 30 Apr 2023 23:20:35 +0200
Marek Vasut <marex@denx.de> wrote:
> In case NET networking is not enabled, it is not possible to compile
> the USB ethernet gadget. Protect the symbols in Makefile to avoid
> build failure. Such build failure may occur e.g. in case NET and USB
> ethernet gadget is enabled in U-Boot proper, but not in SPL.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> Cc: Lukasz Majewski <lukma@denx.de>
> ---
> drivers/usb/gadget/Makefile | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/usb/gadget/Makefile b/drivers/usb/gadget/Makefile
> index 6cfe0f3a041..36f65e7eb95 100644
> --- a/drivers/usb/gadget/Makefile
> +++ b/drivers/usb/gadget/Makefile
> @@ -34,8 +34,10 @@ endif
>
> obj-$(CONFIG_CI_UDC) += ci_udc.o
>
> +ifeq ($(CONFIG_$(SPL_TPL_)NET),y)
> obj-$(CONFIG_USB_ETHER) += ether.o
> obj-$(CONFIG_USB_ETH_RNDIS) += rndis.o
> +endif
>
> # Devices not related to the new gadget layer depend on
> CONFIG_USB_DEVICE # This is really only N900 and USBTTY now.
Reviewed-by: Lukasz Majewski <lukma@denx.de>
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-05-04 9:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-30 21:20 [PATCH] usb: gadget: Compile USB ethernet gadget only if NET is enabled Marek Vasut
2023-05-01 13:47 ` Tom Rini
2023-05-01 16:53 ` Marek Vasut
2023-05-01 17:23 ` Tom Rini
2023-05-01 17:40 ` Marek Vasut
2023-05-01 18:53 ` Tom Rini
2023-05-01 20:49 ` Marek Vasut
2023-05-01 21:18 ` Tom Rini
2023-05-03 21:43 ` Marek Vasut
2023-05-03 21:57 ` Tom Rini
2023-05-04 9:04 ` Lukasz Majewski [this message]
2023-05-04 9:17 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230504110445.733f58f5@wsk \
--to=lukma@denx.de \
--cc=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.