All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: Eugen Hristev <eugen.hristev@collabora.com>
Cc: u-boot@lists.denx.de, joe.hershberger@ni.com, jonas@kwiboo.se,
	jagan@edgeble.ai, kever.yang@rock-chips.com
Subject: Re: [PATCH 2/2] configs: rock5b-rk3588: add rtl8169 driver
Date: Fri, 5 May 2023 18:03:03 -0400	[thread overview]
Message-ID: <20230505220303.GA2499096@bill-the-cat> (raw)
In-Reply-To: <20230425130659.62361-2-eugen.hristev@collabora.com>

[-- Attachment #1: Type: text/plain, Size: 1151 bytes --]

On Tue, Apr 25, 2023 at 04:06:59PM +0300, Eugen Hristev wrote:
> Add the rtl8169 driver, which supports the rtl8125b device, which is
> connected on the pciE bus on this board.
> Enable also CONFIG_SYS_HAS_NONCACHED_MEMORY to have the descriptors stored.
> 
> Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com>
> ---
>  configs/rock5b-rk3588_defconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/configs/rock5b-rk3588_defconfig b/configs/rock5b-rk3588_defconfig
> index a14fcd2ee924..bfa48227aee2 100644
> --- a/configs/rock5b-rk3588_defconfig
> +++ b/configs/rock5b-rk3588_defconfig
> @@ -1,5 +1,6 @@
>  CONFIG_ARM=y
>  CONFIG_SKIP_LOWLEVEL_INIT=y
> +CONFIG_SYS_HAS_NONCACHED_MEMORY=y
>  CONFIG_COUNTER_FREQUENCY=24000000
>  CONFIG_ARCH_ROCKCHIP=y
>  CONFIG_TEXT_BASE=0x00a00000
> @@ -71,6 +72,7 @@ CONFIG_MMC_SDHCI_SDMA=y
>  CONFIG_MMC_SDHCI_ROCKCHIP=y
>  CONFIG_SPI_FLASH_MACRONIX=y
>  CONFIG_ETH_DESIGNWARE=y
> +CONFIG_RTL8169=y
>  CONFIG_GMAC_ROCKCHIP=y
>  CONFIG_PCI=y
>  CONFIG_PCIE_DW_ROCKCHIP=y

Does this depend on some series I missed where PCI is enabled on this
config?

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

  reply	other threads:[~2023-05-05 22:03 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-25 13:06 [PATCH 1/2] net: rtl8169: add minimal support for 8125B variant Eugen Hristev
2023-04-25 13:06 ` [PATCH 2/2] configs: rock5b-rk3588: add rtl8169 driver Eugen Hristev
2023-05-05 22:03   ` Tom Rini [this message]
2023-05-15 12:36     ` Eugen Hristev
2023-05-15 12:52       ` Tom Rini
2023-05-15 12:57         ` Eugen Hristev
2023-05-15 13:16           ` Tom Rini
2023-05-17 10:46             ` Eugen Hristev
2023-07-21  9:51               ` Eugen Hristev
2023-05-18  1:03   ` Kever Yang
2023-04-25 13:17 ` [PATCH 1/2] net: rtl8169: add minimal support for 8125B variant Eugen Hristev
2023-04-25 19:22   ` Ramon Fried
2023-04-25 19:47     ` Eugen Hristev
2023-04-30 19:44       ` Ramon Fried
2023-05-17 10:54         ` Eugen Hristev
2023-05-06 14:54 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230505220303.GA2499096@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=eugen.hristev@collabora.com \
    --cc=jagan@edgeble.ai \
    --cc=joe.hershberger@ni.com \
    --cc=jonas@kwiboo.se \
    --cc=kever.yang@rock-chips.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.