Re: [PATCH 1/2] net: rtl8169: add minimal support for 8125B variant

[Eugen Hristev <eugen.hristev@collabora.com>]

On 4/25/23 22:22, Ramon Fried wrote:
> On Tue, Apr 25, 2023 at 4:17 PM Eugen Hristev
> <eugen.hristev@collabora.com> wrote:
>>
>> On 4/25/23 16:06, Eugen Hristev wrote:
>>> Add minimal support for 8125B version.
>>> Changes are based on the Linux driver.
>>> Tested on Radxa Rock 5B Rk3588 board.
>>>
>>> Connection to a laptop worked fine in 100 Mbps mode.
>>> 1000 Mbps mode is not working at the moment.
>>>
>>> Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com>
>>> ---
>>
>> The one thing that impacts all the rtl chips is the way the pci BAR is
>> now mapped.
>> I could not test this on another platform so help on this matter is
>> appreciated.
>>
>> Thanks!
>> Eugen
> Let's wait a bit to see if someone can test it. why did you change the
> mapping of the BAR ?

It did not work with the old code. It provided a bad address, to some 
area which did not have the right registers.
I looked into similar drivers and they were using this call, which works 
perfectly for 8125b device

Eugen