* Re: [Buildroot] [PATCH 1/1] package/bat: bump version to 0.23.0
2023-05-07 19:50 [Buildroot] [PATCH 1/1] package/bat: bump version to 0.23.0 Leon Rinkel
@ 2023-05-07 20:23 ` Yann E. MORIN
2023-05-07 20:48 ` [Buildroot] [PATCH v2] " Leon Rinkel
1 sibling, 0 replies; 4+ messages in thread
From: Yann E. MORIN @ 2023-05-07 20:23 UTC (permalink / raw)
To: Leon Rinkel; +Cc: David Pierret, buildroot
Leon, All,
Thanks for this patch. However, I have a important comment about it, see
below...
On 2023-05-07 19:50 +0000, Leon Rinkel spake thusly:
> Signed-off-by: Leon Rinkel <leon@rinkel.me>
> ---
> package/bat/bat.hash | 4 ++--
> package/bat/bat.mk | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/package/bat/bat.hash b/package/bat/bat.hash
> index f4d3e32c34..a79cb8f9a3 100644
> --- a/package/bat/bat.hash
> +++ b/package/bat/bat.hash
> @@ -1,4 +1,4 @@
> # Locally generated
> -sha256 7940641baaa61cd3bcd1c3db4804d179609d6ccd955868928a129bf3f853e0b2 bat-0.19.0.tar.gz
> +sha256 b29af37f274019cf1a36d9483c6f30ff780d3be9d0a9e6a96a43737388b7e409 bat-0.23.0.tar.gz
> sha256 c71d239df91726fc519c6eb72d318ec65820627232b2f796219e87dcf35d0ab4 LICENSE-APACHE
> -sha256 64de710b6309a7db5e44ad0af382300c7fb6f6d116d8ae32f0164e05db033068 LICENSE-MIT
> +sha256 dccda9eb9533f5c65624a1106536c6cfde46008d58e60b3faf154e8b9fd5b46e LICENSE-MIT
When you update the hash for a license file, it merans the file has
changed. We have hashes for liocense files, explicitly to detect that
they have changed, so that we can assess whether the licensing terms
have changed (or not).
Silently updating the license hash without explaining what has changed,
defeats the purpose for what we have those hashes to begin with.
In this case, the change is due to an update in the copyright years, so
just state that in the commit log, something along the lines of:
Update hash for LICENSE-MIT, to account for an update in the
copyright years:
https://github.com/sharkdp/bat/commit/d43d241f5bac0fde7881b55f61644e0408181cf7
Care to respoin, please?
Regards,
Yann E. MORIN.
> diff --git a/package/bat/bat.mk b/package/bat/bat.mk
> index dc29a85429..395134df17 100644
> --- a/package/bat/bat.mk
> +++ b/package/bat/bat.mk
> @@ -4,7 +4,7 @@
> #
> ################################################################################
>
> -BAT_VERSION = 0.19.0
> +BAT_VERSION = 0.23.0
> BAT_SITE = $(call github,sharkdp,bat,v$(BAT_VERSION))
> BAT_LICENSE = Apache-2.0 or MIT
> BAT_LICENSE_FILES = LICENSE-APACHE LICENSE-MIT
> --
> 2.34.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread* [Buildroot] [PATCH v2] package/bat: bump version to 0.23.0
2023-05-07 19:50 [Buildroot] [PATCH 1/1] package/bat: bump version to 0.23.0 Leon Rinkel
2023-05-07 20:23 ` Yann E. MORIN
@ 2023-05-07 20:48 ` Leon Rinkel
2023-05-07 21:26 ` Yann E. MORIN
1 sibling, 1 reply; 4+ messages in thread
From: Leon Rinkel @ 2023-05-07 20:48 UTC (permalink / raw)
To: buildroot; +Cc: David Pierret, Leon Rinkel
Update hash for LICENSE-MIT, to account for an update in the copyright years:
https://github.com/sharkdp/bat/commit/d43d241f5bac0fde7881b55f61644e0408181cf7
Signed-off-by: Leon Rinkel <leon@rinkel.me>
---
Changes v1 -> v2:
- Justify license hash change in commit message (requested by Yann E. MORIN)
Signed-off-by: Leon Rinkel <leon@rinkel.me>
---
package/bat/bat.hash | 4 ++--
package/bat/bat.mk | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/package/bat/bat.hash b/package/bat/bat.hash
index f4d3e32c34..a79cb8f9a3 100644
--- a/package/bat/bat.hash
+++ b/package/bat/bat.hash
@@ -1,4 +1,4 @@
# Locally generated
-sha256 7940641baaa61cd3bcd1c3db4804d179609d6ccd955868928a129bf3f853e0b2 bat-0.19.0.tar.gz
+sha256 b29af37f274019cf1a36d9483c6f30ff780d3be9d0a9e6a96a43737388b7e409 bat-0.23.0.tar.gz
sha256 c71d239df91726fc519c6eb72d318ec65820627232b2f796219e87dcf35d0ab4 LICENSE-APACHE
-sha256 64de710b6309a7db5e44ad0af382300c7fb6f6d116d8ae32f0164e05db033068 LICENSE-MIT
+sha256 dccda9eb9533f5c65624a1106536c6cfde46008d58e60b3faf154e8b9fd5b46e LICENSE-MIT
diff --git a/package/bat/bat.mk b/package/bat/bat.mk
index dc29a85429..395134df17 100644
--- a/package/bat/bat.mk
+++ b/package/bat/bat.mk
@@ -4,7 +4,7 @@
#
################################################################################
-BAT_VERSION = 0.19.0
+BAT_VERSION = 0.23.0
BAT_SITE = $(call github,sharkdp,bat,v$(BAT_VERSION))
BAT_LICENSE = Apache-2.0 or MIT
BAT_LICENSE_FILES = LICENSE-APACHE LICENSE-MIT
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 4+ messages in thread