From: Al Viro <viro@zeniv.linux.org.uk>
To: ye.xingchen@zte.com.cn
Cc: kvm@vger.kernel.org, mst@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] vhost_net: Use fdget() and fdput()
Date: Thu, 11 May 2023 06:31:25 +0100 [thread overview]
Message-ID: <20230511053125.GI3390869@ZenIV> (raw)
In-Reply-To: <202305051424047152799@zte.com.cn>
On Fri, May 05, 2023 at 02:24:04PM +0800, ye.xingchen@zte.com.cn wrote:
> From: Ye Xingchen <ye.xingchen@zte.com.cn>
>
> convert the fget()/fput() uses to fdget()/fdput().
>
> Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>
> ---
> drivers/vhost/net.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c
> index ae2273196b0c..5b3fe4805182 100644
> --- a/drivers/vhost/net.c
> +++ b/drivers/vhost/net.c
> @@ -1466,17 +1466,17 @@ static struct ptr_ring *get_tap_ptr_ring(struct file *file)
>
> static struct socket *get_tap_socket(int fd)
> {
> - struct file *file = fget(fd);
> + struct fd f = fdget(fd);
> struct socket *sock;
>
> - if (!file)
> + if (!f.file)
> return ERR_PTR(-EBADF);
> - sock = tun_get_socket(file);
> + sock = tun_get_socket(f.file);
> if (!IS_ERR(sock))
> return sock;
> - sock = tap_get_socket(file);
> + sock = tap_get_socket(f.file);
> if (IS_ERR(sock))
> - fput(file);
> + fdput(f);
> return sock;
NAK. For the same reason why the sockfd_lookup() counterpart of that
patch is broken. After your change there's no way for the caller
to tell whether we have bumped the refcount of file in question;
this can't possibly work.
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
WARNING: multiple messages have this Message-ID (diff)
From: Al Viro <viro@zeniv.linux.org.uk>
To: ye.xingchen@zte.com.cn
Cc: mst@redhat.com, jasowang@redhat.com, kvm@vger.kernel.org,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vhost_net: Use fdget() and fdput()
Date: Thu, 11 May 2023 06:31:25 +0100 [thread overview]
Message-ID: <20230511053125.GI3390869@ZenIV> (raw)
In-Reply-To: <202305051424047152799@zte.com.cn>
On Fri, May 05, 2023 at 02:24:04PM +0800, ye.xingchen@zte.com.cn wrote:
> From: Ye Xingchen <ye.xingchen@zte.com.cn>
>
> convert the fget()/fput() uses to fdget()/fdput().
>
> Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>
> ---
> drivers/vhost/net.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c
> index ae2273196b0c..5b3fe4805182 100644
> --- a/drivers/vhost/net.c
> +++ b/drivers/vhost/net.c
> @@ -1466,17 +1466,17 @@ static struct ptr_ring *get_tap_ptr_ring(struct file *file)
>
> static struct socket *get_tap_socket(int fd)
> {
> - struct file *file = fget(fd);
> + struct fd f = fdget(fd);
> struct socket *sock;
>
> - if (!file)
> + if (!f.file)
> return ERR_PTR(-EBADF);
> - sock = tun_get_socket(file);
> + sock = tun_get_socket(f.file);
> if (!IS_ERR(sock))
> return sock;
> - sock = tap_get_socket(file);
> + sock = tap_get_socket(f.file);
> if (IS_ERR(sock))
> - fput(file);
> + fdput(f);
> return sock;
NAK. For the same reason why the sockfd_lookup() counterpart of that
patch is broken. After your change there's no way for the caller
to tell whether we have bumped the refcount of file in question;
this can't possibly work.
next prev parent reply other threads:[~2023-05-11 5:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-05 6:24 [PATCH] vhost_net: Use fdget() and fdput() ye.xingchen
2023-05-05 6:45 ` Jason Wang
2023-05-05 6:45 ` Jason Wang
2023-05-05 8:41 ` ye xingchen
2023-05-05 14:59 ` Michael S. Tsirkin
2023-05-05 14:59 ` Michael S. Tsirkin
2023-05-11 5:31 ` Al Viro [this message]
2023-05-11 5:31 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230511053125.GI3390869@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=ye.xingchen@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.