From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
To: Yu Kuai <yukuai1-XF6JlduFytWkHkcT6e4Xnw@public.gmane.org>
Cc: hch-jcswGhMUV9g@public.gmane.org,
tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
josef-DigfWCa+lFGyeJad7bwFQA@public.gmane.org,
axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org,
yukuai3-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
yi.zhang-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
yangerkun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH -next 3/6] blk-wbt: don't enable wbt for bio based device
Date: Thu, 11 May 2023 17:21:23 +0200 [thread overview]
Message-ID: <20230511152123.GC7880@lst.de> (raw)
In-Reply-To: <20230511014509.679482-4-yukuai1-XF6JlduFytWkHkcT6e4Xnw@public.gmane.org>
On Thu, May 11, 2023 at 09:45:06AM +0800, Yu Kuai wrote:
> From: Yu Kuai <yukuai3-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
>
> Because rq_qos only make sense for rq based device. Instead of fail
> from sysfs configuration, make wbt sysfs dentry invisible directly.
This looks ok, bt I would be better to just have a separate attr
group just for blk-mq based devices?
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Yu Kuai <yukuai1@huaweicloud.com>
Cc: hch@lst.de, tj@kernel.org, josef@toxicpanda.com, axboe@kernel.dk,
yukuai3@huawei.com, cgroups@vger.kernel.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
yi.zhang@huawei.com, yangerkun@huawei.com
Subject: Re: [PATCH -next 3/6] blk-wbt: don't enable wbt for bio based device
Date: Thu, 11 May 2023 17:21:23 +0200 [thread overview]
Message-ID: <20230511152123.GC7880@lst.de> (raw)
In-Reply-To: <20230511014509.679482-4-yukuai1@huaweicloud.com>
On Thu, May 11, 2023 at 09:45:06AM +0800, Yu Kuai wrote:
> From: Yu Kuai <yukuai3@huawei.com>
>
> Because rq_qos only make sense for rq based device. Instead of fail
> from sysfs configuration, make wbt sysfs dentry invisible directly.
This looks ok, bt I would be better to just have a separate attr
group just for blk-mq based devices?
next prev parent reply other threads:[~2023-05-11 15:21 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-11 1:45 [PATCH -next 0/6] blk-wbt: minor fix and cleanup Yu Kuai
2023-05-11 1:45 ` Yu Kuai
2023-05-11 1:45 ` [PATCH -next 2/6] blk-wbt: don't create wbt sysfs entry if CONFIG_BLK_WBT is disabled Yu Kuai
2023-05-11 15:19 ` Christoph Hellwig
[not found] ` <20230511014509.679482-1-yukuai1-XF6JlduFytWkHkcT6e4Xnw@public.gmane.org>
2023-05-11 1:45 ` [PATCH -next 1/6] blk-wbt: fix that wbt can't be disabled by default Yu Kuai
2023-05-11 1:45 ` Yu Kuai
[not found] ` <20230511014509.679482-2-yukuai1-XF6JlduFytWkHkcT6e4Xnw@public.gmane.org>
2023-05-11 15:19 ` Christoph Hellwig
2023-05-11 15:19 ` Christoph Hellwig
[not found] ` <20230511151919.GA7880-jcswGhMUV9g@public.gmane.org>
2023-05-12 7:03 ` Yu Kuai
2023-05-12 7:03 ` Yu Kuai
2023-05-11 1:45 ` [PATCH -next 3/6] blk-wbt: don't enable wbt for bio based device Yu Kuai
2023-05-11 1:45 ` Yu Kuai
[not found] ` <20230511014509.679482-4-yukuai1-XF6JlduFytWkHkcT6e4Xnw@public.gmane.org>
2023-05-11 15:21 ` Christoph Hellwig [this message]
2023-05-11 15:21 ` Christoph Hellwig
[not found] ` <20230511152123.GC7880-jcswGhMUV9g@public.gmane.org>
2023-05-12 7:06 ` Yu Kuai
2023-05-12 7:06 ` Yu Kuai
2023-05-11 1:45 ` [PATCH -next 4/6] blk-wbt: remove deadcode to handle wbt enable/disable with io inflight Yu Kuai
2023-05-11 1:45 ` Yu Kuai
[not found] ` <20230511014509.679482-5-yukuai1-XF6JlduFytWkHkcT6e4Xnw@public.gmane.org>
2023-05-11 15:21 ` Christoph Hellwig
2023-05-11 15:21 ` Christoph Hellwig
2023-05-11 1:45 ` [PATCH -next 6/6] blk-iocost: move wbt_enable/disable_default() out of spinlock Yu Kuai
2023-05-11 1:45 ` Yu Kuai
2023-05-11 15:25 ` Christoph Hellwig
2023-05-11 1:45 ` [PATCH -next 5/6] blk-wbt: cleanup rwb_enabled() and wbt_disabled() Yu Kuai
[not found] ` <20230511014509.679482-6-yukuai1-XF6JlduFytWkHkcT6e4Xnw@public.gmane.org>
2023-05-11 15:23 ` Christoph Hellwig
2023-05-11 15:23 ` Christoph Hellwig
[not found] ` <20230511152327.GE7880-jcswGhMUV9g@public.gmane.org>
2023-05-12 7:07 ` Yu Kuai
2023-05-12 7:07 ` Yu Kuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230511152123.GC7880@lst.de \
--to=hch-jcswghmuv9g@public.gmane.org \
--cc=axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=josef-DigfWCa+lFGyeJad7bwFQA@public.gmane.org \
--cc=linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=yangerkun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=yi.zhang-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=yukuai1-XF6JlduFytWkHkcT6e4Xnw@public.gmane.org \
--cc=yukuai3-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.