From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Alistair Francis <alistair23@gmail.com>
Cc: Alistair Francis <alistair.francis@wdc.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/cmocka: Ensure we always build static libs
Date: Sat, 13 May 2023 18:09:34 +0200 [thread overview]
Message-ID: <20230513160934.GU2582048@scaer> (raw)
In-Reply-To: <20230503023926.587412-1-alistair.francis@wdc.com>
Alistair, All,
On 2023-05-03 12:39 +1000, Alistair Francis spake thusly:
> Some packages that use cmocka as a dependency will link against the
> static libs, so let's build them by default.
What packages? Are they in Buildroot? Why can't they link to the shared
library?
Regards,
Yann E. MORIN.
> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> ---
> package/cmocka/cmocka.mk | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/package/cmocka/cmocka.mk b/package/cmocka/cmocka.mk
> index eafb4898e1..e21296921d 100644
> --- a/package/cmocka/cmocka.mk
> +++ b/package/cmocka/cmocka.mk
> @@ -15,10 +15,6 @@ CMOCKA_CONF_OPTS = -DWITH_EXAMPLES=OFF
> # cmocka only supports out of source builds
> CMOCKA_SUPPORTS_IN_SOURCE_BUILD = NO
>
> -# cmocka always builds a shared library, but you can optionally build a static
> -# library as well
> -ifeq ($(BR2_SHARED_STATIC_LIBS),y)
> CMOCKA_CONF_OPTS += -DWITH_STATIC_LIB=ON
> -endif
>
> $(eval $(cmake-package))
> --
> 2.39.2
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-05-13 16:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-03 2:39 [Buildroot] [PATCH] package/cmocka: Ensure we always build static libs Alistair Francis
2023-05-13 16:09 ` Yann E. MORIN [this message]
2023-05-17 4:58 ` Alistair Francis
2023-05-21 15:40 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230513160934.GU2582048@scaer \
--to=yann.morin.1998@free.fr \
--cc=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=buildroot@buildroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.