* [Buildroot] [PATCH] package/cmocka: Ensure we always build static libs
@ 2023-05-03 2:39 Alistair Francis
2023-05-13 16:09 ` Yann E. MORIN
0 siblings, 1 reply; 4+ messages in thread
From: Alistair Francis @ 2023-05-03 2:39 UTC (permalink / raw)
To: buildroot; +Cc: Alistair Francis
Some packages that use cmocka as a dependency will link against the
static libs, so let's build them by default.
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
---
package/cmocka/cmocka.mk | 4 ----
1 file changed, 4 deletions(-)
diff --git a/package/cmocka/cmocka.mk b/package/cmocka/cmocka.mk
index eafb4898e1..e21296921d 100644
--- a/package/cmocka/cmocka.mk
+++ b/package/cmocka/cmocka.mk
@@ -15,10 +15,6 @@ CMOCKA_CONF_OPTS = -DWITH_EXAMPLES=OFF
# cmocka only supports out of source builds
CMOCKA_SUPPORTS_IN_SOURCE_BUILD = NO
-# cmocka always builds a shared library, but you can optionally build a static
-# library as well
-ifeq ($(BR2_SHARED_STATIC_LIBS),y)
CMOCKA_CONF_OPTS += -DWITH_STATIC_LIB=ON
-endif
$(eval $(cmake-package))
--
2.39.2
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH] package/cmocka: Ensure we always build static libs
2023-05-03 2:39 [Buildroot] [PATCH] package/cmocka: Ensure we always build static libs Alistair Francis
@ 2023-05-13 16:09 ` Yann E. MORIN
2023-05-17 4:58 ` Alistair Francis
0 siblings, 1 reply; 4+ messages in thread
From: Yann E. MORIN @ 2023-05-13 16:09 UTC (permalink / raw)
To: Alistair Francis; +Cc: Alistair Francis, buildroot
Alistair, All,
On 2023-05-03 12:39 +1000, Alistair Francis spake thusly:
> Some packages that use cmocka as a dependency will link against the
> static libs, so let's build them by default.
What packages? Are they in Buildroot? Why can't they link to the shared
library?
Regards,
Yann E. MORIN.
> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> ---
> package/cmocka/cmocka.mk | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/package/cmocka/cmocka.mk b/package/cmocka/cmocka.mk
> index eafb4898e1..e21296921d 100644
> --- a/package/cmocka/cmocka.mk
> +++ b/package/cmocka/cmocka.mk
> @@ -15,10 +15,6 @@ CMOCKA_CONF_OPTS = -DWITH_EXAMPLES=OFF
> # cmocka only supports out of source builds
> CMOCKA_SUPPORTS_IN_SOURCE_BUILD = NO
>
> -# cmocka always builds a shared library, but you can optionally build a static
> -# library as well
> -ifeq ($(BR2_SHARED_STATIC_LIBS),y)
> CMOCKA_CONF_OPTS += -DWITH_STATIC_LIB=ON
> -endif
>
> $(eval $(cmake-package))
> --
> 2.39.2
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH] package/cmocka: Ensure we always build static libs
2023-05-13 16:09 ` Yann E. MORIN
@ 2023-05-17 4:58 ` Alistair Francis
2023-05-21 15:40 ` Yann E. MORIN
0 siblings, 1 reply; 4+ messages in thread
From: Alistair Francis @ 2023-05-17 4:58 UTC (permalink / raw)
To: Yann E. MORIN; +Cc: Alistair Francis, buildroot
On Sun, May 14, 2023 at 2:09 AM Yann E. MORIN <yann.morin.1998@free.fr> wrote:
>
> Alistair, All,
>
> On 2023-05-03 12:39 +1000, Alistair Francis spake thusly:
> > Some packages that use cmocka as a dependency will link against the
> > static libs, so let's build them by default.
>
> What packages? Are they in Buildroot? Why can't they link to the shared
> library?
I should have kept this patch as part of a series, but it's for
libspdm: https://lists.buildroot.org/pipermail/buildroot/2023-May/667064.html
Alistair
>
> Regards,
> Yann E. MORIN.
>
> > Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> > ---
> > package/cmocka/cmocka.mk | 4 ----
> > 1 file changed, 4 deletions(-)
> >
> > diff --git a/package/cmocka/cmocka.mk b/package/cmocka/cmocka.mk
> > index eafb4898e1..e21296921d 100644
> > --- a/package/cmocka/cmocka.mk
> > +++ b/package/cmocka/cmocka.mk
> > @@ -15,10 +15,6 @@ CMOCKA_CONF_OPTS = -DWITH_EXAMPLES=OFF
> > # cmocka only supports out of source builds
> > CMOCKA_SUPPORTS_IN_SOURCE_BUILD = NO
> >
> > -# cmocka always builds a shared library, but you can optionally build a static
> > -# library as well
> > -ifeq ($(BR2_SHARED_STATIC_LIBS),y)
> > CMOCKA_CONF_OPTS += -DWITH_STATIC_LIB=ON
> > -endif
> >
> > $(eval $(cmake-package))
> > --
> > 2.39.2
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot@buildroot.org
> > https://lists.buildroot.org/mailman/listinfo/buildroot
>
> --
> .-----------------.--------------------.------------------.--------------------.
> | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
> | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
> '------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH] package/cmocka: Ensure we always build static libs
2023-05-17 4:58 ` Alistair Francis
@ 2023-05-21 15:40 ` Yann E. MORIN
0 siblings, 0 replies; 4+ messages in thread
From: Yann E. MORIN @ 2023-05-21 15:40 UTC (permalink / raw)
To: Alistair Francis; +Cc: Alistair Francis, buildroot
Alistair, All,
On 2023-05-17 14:58 +1000, Alistair Francis spake thusly:
> On Sun, May 14, 2023 at 2:09 AM Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> > On 2023-05-03 12:39 +1000, Alistair Francis spake thusly:
> > > Some packages that use cmocka as a dependency will link against the
> > > static libs, so let's build them by default.
> > What packages? Are they in Buildroot? Why can't they link to the shared
> > library?
> I should have kept this patch as part of a series, but it's for
> libspdm: https://lists.buildroot.org/pipermail/buildroot/2023-May/667064.html
But then, why does libspdm require the static cmlocka library?
And given the huge amount of patching you already added, this could also
include changes to accept the shared variant.
Which brings me to the fact that, with huge patches against libspdm, it
is going to be quite some work to maintain those patches when we want to
update libspdm.... I'll reply further there...
Regards,
Yann E. MORIN.
> Alistair
>
> >
> > Regards,
> > Yann E. MORIN.
> >
> > > Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> > > ---
> > > package/cmocka/cmocka.mk | 4 ----
> > > 1 file changed, 4 deletions(-)
> > >
> > > diff --git a/package/cmocka/cmocka.mk b/package/cmocka/cmocka.mk
> > > index eafb4898e1..e21296921d 100644
> > > --- a/package/cmocka/cmocka.mk
> > > +++ b/package/cmocka/cmocka.mk
> > > @@ -15,10 +15,6 @@ CMOCKA_CONF_OPTS = -DWITH_EXAMPLES=OFF
> > > # cmocka only supports out of source builds
> > > CMOCKA_SUPPORTS_IN_SOURCE_BUILD = NO
> > >
> > > -# cmocka always builds a shared library, but you can optionally build a static
> > > -# library as well
> > > -ifeq ($(BR2_SHARED_STATIC_LIBS),y)
> > > CMOCKA_CONF_OPTS += -DWITH_STATIC_LIB=ON
> > > -endif
> > >
> > > $(eval $(cmake-package))
> > > --
> > > 2.39.2
> > >
> > > _______________________________________________
> > > buildroot mailing list
> > > buildroot@buildroot.org
> > > https://lists.buildroot.org/mailman/listinfo/buildroot
> >
> > --
> > .-----------------.--------------------.------------------.--------------------.
> > | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> > | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
> > | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
> > | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
> > '------------------------------^-------^------------------^--------------------'
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-05-21 15:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-03 2:39 [Buildroot] [PATCH] package/cmocka: Ensure we always build static libs Alistair Francis
2023-05-13 16:09 ` Yann E. MORIN
2023-05-17 4:58 ` Alistair Francis
2023-05-21 15:40 ` Yann E. MORIN
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.