All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@kernel.org>
To: soc@kernel.org
Cc: Arnd Bergmann <arnd@arndb.de>,
	Russell King <linux@armlinux.org.uk>,
	Bartosz Golaszewski <brgl@bgdev.pl>,
	Hartley Sweeten <hsweeten@visionengravers.com>,
	Alexander Sverdlin <alexander.sverdlin@gmail.com>,
	Andre Przywara <andre.przywara@arm.com>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	Vladimir Zapolskiy <vz@mleia.com>,
	Aaro Koskinen <aaro.koskinen@iki.fi>,
	Janusz Krzysztofik <jmkrzyszt@gmail.com>,
	Tony Lindgren <tony@atomide.com>, Andrew Lunn <andrew@lunn.ch>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Gregory Clement <gregory.clement@bootlin.com>,
	Daniel Mack <daniel@zonque.org>,
	Haojian Zhuang <haojian.zhuang@gmail.com>,
	Robert Jarzmik <robert.jarzmik@free.fr>,
	Viresh Kumar <vireshk@kernel.org>,
	Shiraz Hashim <shiraz.linux.kernel@gmail.com>,
	Sudeep Holla <sudeep.holla@arm.com>,
	Lorenzo Pieralisi <lpieralisi@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Alan Stern <stern@rowland.harvard.edu>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-clk@vger.kernel.org, linux-usb@vger.kernel.org
Subject: [PATCH 05/13] ARM: imx: remove unused mx25_revision()
Date: Tue, 16 May 2023 17:31:01 +0200	[thread overview]
Message-ID: <20230516153109.514251-6-arnd@kernel.org> (raw)
In-Reply-To: <20230516153109.514251-1-arnd@kernel.org>

From: Arnd Bergmann <arnd@arndb.de>

This function has no prototype and no callers:

arm/mach-imx/cpu-imx25.c:43:5: error: no previous prototype for 'mx25_revision' [-Werror=missing-prototypes]

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 arch/arm/mach-imx/Makefile    |  2 +-
 arch/arm/mach-imx/cpu-imx25.c | 50 -----------------------------------
 2 files changed, 1 insertion(+), 51 deletions(-)
 delete mode 100644 arch/arm/mach-imx/cpu-imx25.c

diff --git a/arch/arm/mach-imx/Makefile b/arch/arm/mach-imx/Makefile
index 5c650bf40e02..35a99888f54a 100644
--- a/arch/arm/mach-imx/Makefile
+++ b/arch/arm/mach-imx/Makefile
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0
 obj-y := cpu.o system.o irq-common.o
 
-obj-$(CONFIG_SOC_IMX25) += cpu-imx25.o mach-imx25.o pm-imx25.o
+obj-$(CONFIG_SOC_IMX25) += mach-imx25.o pm-imx25.o
 
 obj-$(CONFIG_SOC_IMX27) += cpu-imx27.o pm-imx27.o mach-imx27.o
 
diff --git a/arch/arm/mach-imx/cpu-imx25.c b/arch/arm/mach-imx/cpu-imx25.c
deleted file mode 100644
index cc86977d0a34..000000000000
--- a/arch/arm/mach-imx/cpu-imx25.c
+++ /dev/null
@@ -1,50 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0-or-later
-/*
- * MX25 CPU type detection
- *
- * Copyright (c) 2009 Daniel Mack <daniel@caiaq.de>
- * Copyright (C) 2011 Freescale Semiconductor, Inc. All Rights Reserved
- */
-#include <linux/module.h>
-#include <linux/io.h>
-#include <linux/of.h>
-#include <linux/of_address.h>
-
-#include "iim.h"
-#include "hardware.h"
-
-static int mx25_cpu_rev = -1;
-
-static int mx25_read_cpu_rev(void)
-{
-	u32 rev;
-	void __iomem *iim_base;
-	struct device_node *np;
-
-	np = of_find_compatible_node(NULL, NULL, "fsl,imx25-iim");
-	iim_base = of_iomap(np, 0);
-	of_node_put(np);
-	BUG_ON(!iim_base);
-	rev = readl(iim_base + MXC_IIMSREV);
-	iounmap(iim_base);
-
-	switch (rev) {
-	case 0x00:
-		return IMX_CHIP_REVISION_1_0;
-	case 0x01:
-		return IMX_CHIP_REVISION_1_1;
-	case 0x02:
-		return IMX_CHIP_REVISION_1_2;
-	default:
-		return IMX_CHIP_REVISION_UNKNOWN;
-	}
-}
-
-int mx25_revision(void)
-{
-	if (mx25_cpu_rev == -1)
-		mx25_cpu_rev = mx25_read_cpu_rev();
-
-	return mx25_cpu_rev;
-}
-EXPORT_SYMBOL(mx25_revision);
-- 
2.39.2


WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@kernel.org>
To: soc@kernel.org
Cc: Arnd Bergmann <arnd@arndb.de>,
	Russell King <linux@armlinux.org.uk>,
	Bartosz Golaszewski <brgl@bgdev.pl>,
	Hartley Sweeten <hsweeten@visionengravers.com>,
	Alexander Sverdlin <alexander.sverdlin@gmail.com>,
	Andre Przywara <andre.przywara@arm.com>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	Vladimir Zapolskiy <vz@mleia.com>,
	Aaro Koskinen <aaro.koskinen@iki.fi>,
	Janusz Krzysztofik <jmkrzyszt@gmail.com>,
	Tony Lindgren <tony@atomide.com>, Andrew Lunn <andrew@lunn.ch>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Gregory Clement <gregory.clement@bootlin.com>,
	Daniel Mack <daniel@zonque.org>,
	Haojian Zhuang <haojian.zhuang@gmail.com>,
	Robert Jarzmik <robert.jarzmik@free.fr>,
	Viresh Kumar <vireshk@kernel.org>,
	Shiraz Hashim <shiraz.linux.kernel@gmail.com>,
	Sudeep Holla <sudeep.holla@arm.com>,
	Lorenzo Pieralisi <lpieralisi@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Alan Stern <stern@rowland.harvard.edu>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-clk@vger.kernel.org, linux-usb@vger.kernel.org
Subject: [PATCH 05/13] ARM: imx: remove unused mx25_revision()
Date: Tue, 16 May 2023 17:31:01 +0200	[thread overview]
Message-ID: <20230516153109.514251-6-arnd@kernel.org> (raw)
In-Reply-To: <20230516153109.514251-1-arnd@kernel.org>

From: Arnd Bergmann <arnd@arndb.de>

This function has no prototype and no callers:

arm/mach-imx/cpu-imx25.c:43:5: error: no previous prototype for 'mx25_revision' [-Werror=missing-prototypes]

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 arch/arm/mach-imx/Makefile    |  2 +-
 arch/arm/mach-imx/cpu-imx25.c | 50 -----------------------------------
 2 files changed, 1 insertion(+), 51 deletions(-)
 delete mode 100644 arch/arm/mach-imx/cpu-imx25.c

diff --git a/arch/arm/mach-imx/Makefile b/arch/arm/mach-imx/Makefile
index 5c650bf40e02..35a99888f54a 100644
--- a/arch/arm/mach-imx/Makefile
+++ b/arch/arm/mach-imx/Makefile
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0
 obj-y := cpu.o system.o irq-common.o
 
-obj-$(CONFIG_SOC_IMX25) += cpu-imx25.o mach-imx25.o pm-imx25.o
+obj-$(CONFIG_SOC_IMX25) += mach-imx25.o pm-imx25.o
 
 obj-$(CONFIG_SOC_IMX27) += cpu-imx27.o pm-imx27.o mach-imx27.o
 
diff --git a/arch/arm/mach-imx/cpu-imx25.c b/arch/arm/mach-imx/cpu-imx25.c
deleted file mode 100644
index cc86977d0a34..000000000000
--- a/arch/arm/mach-imx/cpu-imx25.c
+++ /dev/null
@@ -1,50 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0-or-later
-/*
- * MX25 CPU type detection
- *
- * Copyright (c) 2009 Daniel Mack <daniel@caiaq.de>
- * Copyright (C) 2011 Freescale Semiconductor, Inc. All Rights Reserved
- */
-#include <linux/module.h>
-#include <linux/io.h>
-#include <linux/of.h>
-#include <linux/of_address.h>
-
-#include "iim.h"
-#include "hardware.h"
-
-static int mx25_cpu_rev = -1;
-
-static int mx25_read_cpu_rev(void)
-{
-	u32 rev;
-	void __iomem *iim_base;
-	struct device_node *np;
-
-	np = of_find_compatible_node(NULL, NULL, "fsl,imx25-iim");
-	iim_base = of_iomap(np, 0);
-	of_node_put(np);
-	BUG_ON(!iim_base);
-	rev = readl(iim_base + MXC_IIMSREV);
-	iounmap(iim_base);
-
-	switch (rev) {
-	case 0x00:
-		return IMX_CHIP_REVISION_1_0;
-	case 0x01:
-		return IMX_CHIP_REVISION_1_1;
-	case 0x02:
-		return IMX_CHIP_REVISION_1_2;
-	default:
-		return IMX_CHIP_REVISION_UNKNOWN;
-	}
-}
-
-int mx25_revision(void)
-{
-	if (mx25_cpu_rev == -1)
-		mx25_cpu_rev = mx25_read_cpu_rev();
-
-	return mx25_cpu_rev;
-}
-EXPORT_SYMBOL(mx25_revision);
-- 
2.39.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2023-05-16 15:32 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-16 15:30 [PATCH 00/13] ARM: SoC: address -Wmissing-prototype warnings Arnd Bergmann
2023-05-16 15:30 ` Arnd Bergmann
2023-05-16 15:30 ` [PATCH 01/13] ARM: davinci: fix davinci_cpufreq_init() declaration Arnd Bergmann
2023-05-16 15:30   ` Arnd Bergmann
2023-05-16 15:41   ` Bartosz Golaszewski
2023-05-16 15:41     ` Bartosz Golaszewski
2023-05-16 15:30 ` [PATCH 02/13] ARM: ep93xx: fix missing-prototype warnings Arnd Bergmann
2023-05-16 15:30   ` Arnd Bergmann
2023-05-16 15:51   ` Alexander Sverdlin
2023-05-16 15:51     ` Alexander Sverdlin
2023-05-16 15:30 ` [PATCH 03/13] ARM: highbank: add missing include Arnd Bergmann
2023-05-16 15:30   ` Arnd Bergmann
2023-05-16 15:58   ` Andre Przywara
2023-05-16 15:58     ` Andre Przywara
2023-05-16 15:31 ` [PATCH 04/13] ARM: imx: " Arnd Bergmann
2023-05-16 15:31   ` Arnd Bergmann
2023-05-16 15:31 ` Arnd Bergmann [this message]
2023-05-16 15:31   ` [PATCH 05/13] ARM: imx: remove unused mx25_revision() Arnd Bergmann
2023-05-16 23:34   ` Fabio Estevam
2023-05-16 23:34     ` Fabio Estevam
2023-05-17  6:39     ` Arnd Bergmann
2023-05-17  6:39       ` Arnd Bergmann
2023-05-17 15:45       ` Martin Kaiser
2023-05-17 15:45         ` Martin Kaiser
2023-07-28 15:59         ` Arnd Bergmann
2023-07-28 15:59           ` Arnd Bergmann
2023-07-30 16:26           ` Martin Kaiser
2023-07-30 16:26             ` Martin Kaiser
2023-05-16 15:31 ` [PATCH 06/13] ARM: lpc32xx: add missing include Arnd Bergmann
2023-05-16 15:31   ` Arnd Bergmann
2023-05-23 20:17   ` Vladimir Zapolskiy
2023-05-23 20:17     ` Vladimir Zapolskiy
2023-05-16 15:31 ` [PATCH 07/13] ARM: omap1: " Arnd Bergmann
2023-05-16 15:31   ` Arnd Bergmann
2023-05-16 23:18   ` Aaro Koskinen
2023-05-16 23:18     ` Aaro Koskinen
2023-05-17  5:58     ` Tony Lindgren
2023-05-17  5:58       ` Tony Lindgren
2023-05-17  5:58     ` Tony Lindgren
2023-05-17  5:58       ` Tony Lindgren
2023-05-16 15:31 ` [PATCH 08/13] ARM: omap2: fix missing tick_broadcast() prototype Arnd Bergmann
2023-05-16 15:31   ` Arnd Bergmann
2023-05-16 23:20   ` Aaro Koskinen
2023-05-16 23:20     ` Aaro Koskinen
2023-05-16 15:31 ` [PATCH 09/13] ARM: orion5x: fix d2net gpio initialization Arnd Bergmann
2023-05-16 15:31   ` Arnd Bergmann
2023-05-16 16:17   ` Andrew Lunn
2023-05-16 16:17     ` Andrew Lunn
2023-05-16 15:31 ` [PATCH 10/13] ARM: pxa: fix missing-prototypes warnings Arnd Bergmann
2023-05-16 15:31   ` Arnd Bergmann
2023-05-18 20:10   ` Stephen Boyd
2023-05-18 20:10     ` Stephen Boyd
2023-05-28 11:46   ` Greg Kroah-Hartman
2023-05-28 11:46     ` Greg Kroah-Hartman
2023-05-16 15:31 ` [PATCH 11/13] ARM: sa1100: address missing prototype warnings Arnd Bergmann
2023-05-16 15:31   ` Arnd Bergmann
2023-05-16 15:31 ` [PATCH 12/13] ARM: spear: include "pl080.h" for pl080_get_signal() prototype Arnd Bergmann
2023-05-16 15:31   ` Arnd Bergmann
2023-05-17  4:34   ` Viresh Kumar
2023-05-17  4:34     ` Viresh Kumar
2023-05-16 15:31 ` [PATCH 13/13] ARM: versatile: mark mmc_status() static Arnd Bergmann
2023-05-16 15:31   ` Arnd Bergmann
2023-05-26 11:50 ` [PATCH 00/13] ARM: SoC: address -Wmissing-prototype warnings patchwork-bot+linux-soc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230516153109.514251-6-arnd@kernel.org \
    --to=arnd@kernel.org \
    --cc=aaro.koskinen@iki.fi \
    --cc=alexander.sverdlin@gmail.com \
    --cc=andre.przywara@arm.com \
    --cc=andrew@lunn.ch \
    --cc=arnd@arndb.de \
    --cc=brgl@bgdev.pl \
    --cc=daniel@zonque.org \
    --cc=festevam@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=gregory.clement@bootlin.com \
    --cc=haojian.zhuang@gmail.com \
    --cc=hsweeten@visionengravers.com \
    --cc=jmkrzyszt@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=lpieralisi@kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=robert.jarzmik@free.fr \
    --cc=s.hauer@pengutronix.de \
    --cc=sboyd@kernel.org \
    --cc=sebastian.hesselbarth@gmail.com \
    --cc=shawnguo@kernel.org \
    --cc=shiraz.linux.kernel@gmail.com \
    --cc=soc@kernel.org \
    --cc=stern@rowland.harvard.edu \
    --cc=sudeep.holla@arm.com \
    --cc=tony@atomide.com \
    --cc=vireshk@kernel.org \
    --cc=vz@mleia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.