All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@kernel.org>
To: Russell King <linux@armlinux.org.uk>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Steven Rostedt <rostedt@goodmis.org>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Oleg Nesterov <oleg@redhat.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Pavel Machek <pavel@ucw.cz>,
	Linus Walleij <linus.walleij@linaro.org>,
	Ard Biesheuvel <ardb@kernel.org>,
	Kees Cook <keescook@chromium.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: [PATCH 00/16] ARM: address -Wmissing-prototype warnings
Date: Tue, 16 May 2023 17:45:49 +0200	[thread overview]
Message-ID: <20230516154605.517690-1-arnd@kernel.org> (raw)

From: Arnd Bergmann <arnd@arndb.de>

This addresses all arm specific warnings outside of the mach-*/ code,
which I've submitted separately. The majority of the patches should be
straightforward, either adding an #include statement to get the right
header, or ensuring that an unused global function is left out of the
build when the prototype is hidden.

The ones that are a bit awkward are those that just add a prototype to
shut up the warning, but the prototypes are never used for calling the
function because the only caller is in assembler code. I tried to come
up with other ways to shut up the compiler, and ideally this would be
triggered by the 'asmlinkage' keyword as Ard suggested in the past, but
I could not come up with a way to do this.

All of the warnings have to be addressed in some form before the
warning can be enabled by default.

    Arnd

Link: https://people.kernel.org/arnd/missing-prototype-warnings-in-the-kernel

Arnd Bergmann (16):
  ARM: dma-mapping: hide unused dma_contiguous_early_fixup function
  ARM: traps: hide unused functions on NOMMU
  ARM: vfp: include asm/neon.h in vfpmodule.c
  ARM: vdso: add missing prototypes
  ARM: kprobes: avoid missing-declaration warnings
  ARM: tcm: move tcm_init() prototype to asm/tcm.h
  ARM: add prototype for function called only from asm
  ARM: add clear/copy_user_highpage declarations
  ARM: cacheflush: avoid __flush_anon_page() missing-prototype warning
  ARM: nommu: include asm/idmap.h
  ARM: move setup functions to header
  ARM: fiq: include asm/mach/irq.h for prototypes
  ARM: vfp: add vfp_entry prototype
  ARM: add missing syscall prototypes
  ARM: decompressor: move function prototypes to misc.h
  ARM: xip-kernel: add __inflate_kernel_data prototype

 arch/arm/boot/compressed/atags_to_fdt.c       |  1 +
 .../arm/boot/compressed/fdt_check_mem_start.c |  1 +
 arch/arm/boot/compressed/misc.c               |  6 ---
 arch/arm/boot/compressed/misc.h               | 11 ++++
 arch/arm/include/asm/ftrace.h                 |  4 ++
 arch/arm/include/asm/page.h                   | 22 ++++++++
 arch/arm/include/asm/ptrace.h                 |  3 ++
 arch/arm/include/asm/setup.h                  |  7 +++
 arch/arm/include/asm/signal.h                 |  5 ++
 arch/arm/include/asm/spectre.h                |  4 ++
 arch/arm/include/asm/suspend.h                |  1 +
 arch/arm/include/asm/syscalls.h               | 51 +++++++++++++++++++
 arch/arm/include/asm/tcm.h                    | 11 ++--
 arch/arm/include/asm/traps.h                  |  9 ++++
 arch/arm/include/asm/unwind.h                 |  4 ++
 arch/arm/include/asm/vdso.h                   |  5 ++
 arch/arm/include/asm/vfp.h                    |  1 +
 arch/arm/kernel/fiq.c                         |  1 +
 arch/arm/kernel/head-inflate-data.c           |  5 +-
 arch/arm/kernel/head.h                        |  8 +++
 arch/arm/kernel/setup.c                       |  7 ---
 arch/arm/kernel/signal.c                      |  1 +
 arch/arm/kernel/sys_arm.c                     |  1 +
 arch/arm/kernel/sys_oabi-compat.c             |  2 +
 arch/arm/kernel/traps.c                       |  2 +
 arch/arm/mm/dma-mapping.c                     |  2 +
 arch/arm/mm/fault.h                           |  4 ++
 arch/arm/mm/flush.c                           |  1 +
 arch/arm/mm/mmu.c                             |  2 +-
 arch/arm/mm/nommu.c                           |  1 +
 arch/arm/mm/tcm.h                             | 17 -------
 arch/arm/probes/kprobes/checkers-common.c     |  2 +-
 arch/arm/probes/kprobes/core.c                |  2 +-
 arch/arm/probes/kprobes/opt-arm.c             |  2 -
 arch/arm/probes/kprobes/test-core.c           |  2 +-
 arch/arm/probes/kprobes/test-core.h           |  4 ++
 arch/arm/vdso/vgettimeofday.c                 |  2 +
 arch/arm/vfp/vfp.h                            |  3 ++
 arch/arm/vfp/vfpmodule.c                      |  1 +
 39 files changed, 175 insertions(+), 43 deletions(-)
 create mode 100644 arch/arm/include/asm/syscalls.h
 create mode 100644 arch/arm/kernel/head.h
 delete mode 100644 arch/arm/mm/tcm.h

To: Russell King <linux@armlinux.org.uk>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Ard Biesheuvel <ardb@kernel.org>
Cc: Kees Cook <keescook@chromium.org>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-trace-kernel@vger.kernel.org
Cc: linux-pm@vger.kernel.org


-- 
2.39.2


WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@kernel.org>
To: Russell King <linux@armlinux.org.uk>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Steven Rostedt <rostedt@goodmis.org>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Oleg Nesterov <oleg@redhat.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Pavel Machek <pavel@ucw.cz>,
	Linus Walleij <linus.walleij@linaro.org>,
	Ard Biesheuvel <ardb@kernel.org>,
	Kees Cook <keescook@chromium.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: [PATCH 00/16] ARM: address -Wmissing-prototype warnings
Date: Tue, 16 May 2023 17:45:49 +0200	[thread overview]
Message-ID: <20230516154605.517690-1-arnd@kernel.org> (raw)

From: Arnd Bergmann <arnd@arndb.de>

This addresses all arm specific warnings outside of the mach-*/ code,
which I've submitted separately. The majority of the patches should be
straightforward, either adding an #include statement to get the right
header, or ensuring that an unused global function is left out of the
build when the prototype is hidden.

The ones that are a bit awkward are those that just add a prototype to
shut up the warning, but the prototypes are never used for calling the
function because the only caller is in assembler code. I tried to come
up with other ways to shut up the compiler, and ideally this would be
triggered by the 'asmlinkage' keyword as Ard suggested in the past, but
I could not come up with a way to do this.

All of the warnings have to be addressed in some form before the
warning can be enabled by default.

    Arnd

Link: https://people.kernel.org/arnd/missing-prototype-warnings-in-the-kernel

Arnd Bergmann (16):
  ARM: dma-mapping: hide unused dma_contiguous_early_fixup function
  ARM: traps: hide unused functions on NOMMU
  ARM: vfp: include asm/neon.h in vfpmodule.c
  ARM: vdso: add missing prototypes
  ARM: kprobes: avoid missing-declaration warnings
  ARM: tcm: move tcm_init() prototype to asm/tcm.h
  ARM: add prototype for function called only from asm
  ARM: add clear/copy_user_highpage declarations
  ARM: cacheflush: avoid __flush_anon_page() missing-prototype warning
  ARM: nommu: include asm/idmap.h
  ARM: move setup functions to header
  ARM: fiq: include asm/mach/irq.h for prototypes
  ARM: vfp: add vfp_entry prototype
  ARM: add missing syscall prototypes
  ARM: decompressor: move function prototypes to misc.h
  ARM: xip-kernel: add __inflate_kernel_data prototype

 arch/arm/boot/compressed/atags_to_fdt.c       |  1 +
 .../arm/boot/compressed/fdt_check_mem_start.c |  1 +
 arch/arm/boot/compressed/misc.c               |  6 ---
 arch/arm/boot/compressed/misc.h               | 11 ++++
 arch/arm/include/asm/ftrace.h                 |  4 ++
 arch/arm/include/asm/page.h                   | 22 ++++++++
 arch/arm/include/asm/ptrace.h                 |  3 ++
 arch/arm/include/asm/setup.h                  |  7 +++
 arch/arm/include/asm/signal.h                 |  5 ++
 arch/arm/include/asm/spectre.h                |  4 ++
 arch/arm/include/asm/suspend.h                |  1 +
 arch/arm/include/asm/syscalls.h               | 51 +++++++++++++++++++
 arch/arm/include/asm/tcm.h                    | 11 ++--
 arch/arm/include/asm/traps.h                  |  9 ++++
 arch/arm/include/asm/unwind.h                 |  4 ++
 arch/arm/include/asm/vdso.h                   |  5 ++
 arch/arm/include/asm/vfp.h                    |  1 +
 arch/arm/kernel/fiq.c                         |  1 +
 arch/arm/kernel/head-inflate-data.c           |  5 +-
 arch/arm/kernel/head.h                        |  8 +++
 arch/arm/kernel/setup.c                       |  7 ---
 arch/arm/kernel/signal.c                      |  1 +
 arch/arm/kernel/sys_arm.c                     |  1 +
 arch/arm/kernel/sys_oabi-compat.c             |  2 +
 arch/arm/kernel/traps.c                       |  2 +
 arch/arm/mm/dma-mapping.c                     |  2 +
 arch/arm/mm/fault.h                           |  4 ++
 arch/arm/mm/flush.c                           |  1 +
 arch/arm/mm/mmu.c                             |  2 +-
 arch/arm/mm/nommu.c                           |  1 +
 arch/arm/mm/tcm.h                             | 17 -------
 arch/arm/probes/kprobes/checkers-common.c     |  2 +-
 arch/arm/probes/kprobes/core.c                |  2 +-
 arch/arm/probes/kprobes/opt-arm.c             |  2 -
 arch/arm/probes/kprobes/test-core.c           |  2 +-
 arch/arm/probes/kprobes/test-core.h           |  4 ++
 arch/arm/vdso/vgettimeofday.c                 |  2 +
 arch/arm/vfp/vfp.h                            |  3 ++
 arch/arm/vfp/vfpmodule.c                      |  1 +
 39 files changed, 175 insertions(+), 43 deletions(-)
 create mode 100644 arch/arm/include/asm/syscalls.h
 create mode 100644 arch/arm/kernel/head.h
 delete mode 100644 arch/arm/mm/tcm.h

To: Russell King <linux@armlinux.org.uk>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Ard Biesheuvel <ardb@kernel.org>
Cc: Kees Cook <keescook@chromium.org>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-trace-kernel@vger.kernel.org
Cc: linux-pm@vger.kernel.org


-- 
2.39.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

             reply	other threads:[~2023-05-16 15:47 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-16 15:45 Arnd Bergmann [this message]
2023-05-16 15:45 ` [PATCH 00/16] ARM: address -Wmissing-prototype warnings Arnd Bergmann
2023-05-16 15:45 ` [PATCH 01/16] ARM: dma-mapping: hide unused dma_contiguous_early_fixup function Arnd Bergmann
2023-05-16 15:45   ` Arnd Bergmann
2023-05-16 15:45 ` [PATCH 02/16] ARM: traps: hide unused functions on NOMMU Arnd Bergmann
2023-05-16 15:45   ` Arnd Bergmann
2023-05-16 15:45 ` [PATCH 03/16] ARM: vfp: include asm/neon.h in vfpmodule.c Arnd Bergmann
2023-05-16 15:45   ` Arnd Bergmann
2023-05-16 15:45 ` [PATCH 04/16] ARM: vdso: add missing prototypes Arnd Bergmann
2023-05-16 15:45   ` Arnd Bergmann
2023-05-16 15:45 ` [PATCH 05/16] ARM: kprobes: avoid missing-declaration warnings Arnd Bergmann
2023-05-16 15:45   ` Arnd Bergmann
2023-05-17  1:29   ` Masami Hiramatsu
2023-05-17  1:29     ` Masami Hiramatsu
2023-05-16 15:45 ` [PATCH 06/16] ARM: tcm: move tcm_init() prototype to asm/tcm.h Arnd Bergmann
2023-05-16 15:45   ` Arnd Bergmann
2023-05-22  7:34   ` Linus Walleij
2023-05-22  7:34     ` Linus Walleij
2023-05-16 15:45 ` [PATCH 07/16] ARM: add prototype for function called only from asm Arnd Bergmann
2023-05-16 15:45   ` Arnd Bergmann
2023-05-16 15:45 ` [PATCH 08/16] ARM: add clear/copy_user_highpage declarations Arnd Bergmann
2023-05-16 15:45   ` Arnd Bergmann
2023-05-16 15:45 ` [PATCH 09/16] ARM: cacheflush: avoid __flush_anon_page() missing-prototype warning Arnd Bergmann
2023-05-16 15:45   ` Arnd Bergmann
2023-05-16 15:45 ` [PATCH 10/16] ARM: nommu: include asm/idmap.h Arnd Bergmann
2023-05-16 15:45   ` Arnd Bergmann
2023-05-16 15:46 ` [PATCH 11/16] ARM: move setup functions to header Arnd Bergmann
2023-05-16 15:46   ` Arnd Bergmann
2023-05-22  7:35   ` Linus Walleij
2023-05-22  7:35     ` Linus Walleij
2023-05-16 15:46 ` [PATCH 12/16] ARM: fiq: include asm/mach/irq.h for prototypes Arnd Bergmann
2023-05-16 15:46   ` Arnd Bergmann
2023-05-16 15:46 ` [PATCH 13/16] ARM: vfp: add vfp_entry prototype Arnd Bergmann
2023-05-16 15:46   ` Arnd Bergmann
2023-05-17 11:13   ` Ard Biesheuvel
2023-05-17 11:13     ` Ard Biesheuvel
2023-05-16 15:46 ` [PATCH 14/16] ARM: add missing syscall prototypes Arnd Bergmann
2023-05-16 15:46   ` Arnd Bergmann
2023-05-16 15:46 ` [PATCH 15/16] ARM: decompressor: move function prototypes to misc.h Arnd Bergmann
2023-05-16 15:46   ` Arnd Bergmann
2023-05-16 15:46 ` [PATCH 16/16] ARM: xip-kernel: add __inflate_kernel_data prototype Arnd Bergmann
2023-05-16 15:46   ` Arnd Bergmann
2023-05-16 19:56 ` [PATCH 00/16] ARM: address -Wmissing-prototype warnings Kees Cook
2023-05-16 19:56   ` Kees Cook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230516154605.517690-1-arnd@kernel.org \
    --to=arnd@kernel.org \
    --cc=ardb@kernel.org \
    --cc=arnd@arndb.de \
    --cc=keescook@chromium.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=mhiramat@kernel.org \
    --cc=oleg@redhat.com \
    --cc=pavel@ucw.cz \
    --cc=rafael@kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.