All of lore.kernel.org
 help / color / mirror / Atom feed
* Logic error in rsa_private
@ 2023-05-16 15:54 Olaf Hering
  0 siblings, 0 replies; only message in thread
From: Olaf Hering @ 2023-05-16 15:54 UTC (permalink / raw)
  To: Daniel De Graaf, Quan Xu; +Cc: xen-devel

[-- Attachment #1: Type: text/plain, Size: 440 bytes --]

Hello,

as shown in 'build.log' at
https://gitlab.com/xen-project/xen/-/jobs/4284741850/artifacts/browse
there is a logic error spotted by gcc 13.

crypto/rsa.c: In function 'rsa_private':
crypto/rsa.c:56:7: error: the comparison will always evaluate as 'true' for the address of 'p' will never be NUL
   56 |   if (!key->p || !key->q || !key->u) {

None of p/q/u are pointers. Please have a look at some point.

Thanks,
Olaf

[-- Attachment #2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-05-16 15:55 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-16 15:54 Logic error in rsa_private Olaf Hering

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.