From: "Michael Büsch" <m@bues.ch>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Kalle Valo <kvalo@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Tom Rix <trix@redhat.com>,
linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev
Subject: Re: [PATCH] wifi: b43: fix incorrect __packed annotation
Date: Tue, 16 May 2023 19:12:45 +0200 [thread overview]
Message-ID: <20230516191245.4149c51a@barney> (raw)
In-Reply-To: <20230516074554.1674536-1-arnd@kernel.org>
[-- Attachment #1.1: Type: text/plain, Size: 402 bytes --]
On Tue, 16 May 2023 09:45:42 +0200
Arnd Bergmann <arnd@kernel.org> wrote:
> b43_iv { union {
> __be16 d16;
> __be32 d32;
> - } data __packed;
> + } __packed data;
> } __packed;
>
>
Oh, interesting. This has probably been there forever.
Did you check if the b43legacy driver has the same issue?
Acked-by: Michael Büsch <m@bues.ch>
--
Michael Büsch
https://bues.ch/
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 149 bytes --]
_______________________________________________
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev
WARNING: multiple messages have this Message-ID (diff)
From: "Michael Büsch" <m@bues.ch>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Kalle Valo <kvalo@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Tom Rix <trix@redhat.com>,
linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev
Subject: Re: [PATCH] wifi: b43: fix incorrect __packed annotation
Date: Tue, 16 May 2023 19:12:45 +0200 [thread overview]
Message-ID: <20230516191245.4149c51a@barney> (raw)
In-Reply-To: <20230516074554.1674536-1-arnd@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 402 bytes --]
On Tue, 16 May 2023 09:45:42 +0200
Arnd Bergmann <arnd@kernel.org> wrote:
> b43_iv { union {
> __be16 d16;
> __be32 d32;
> - } data __packed;
> + } __packed data;
> } __packed;
>
>
Oh, interesting. This has probably been there forever.
Did you check if the b43legacy driver has the same issue?
Acked-by: Michael Büsch <m@bues.ch>
--
Michael Büsch
https://bues.ch/
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-05-16 17:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-16 7:45 [PATCH] wifi: b43: fix incorrect __packed annotation Arnd Bergmann
2023-05-16 7:45 ` Arnd Bergmann
2023-05-16 11:00 ` Simon Horman
2023-05-16 11:00 ` Simon Horman
2023-05-16 17:12 ` Michael Büsch [this message]
2023-05-16 17:12 ` Michael Büsch
2023-05-16 17:45 ` Arnd Bergmann
2023-05-16 17:45 ` Arnd Bergmann
2023-05-16 17:47 ` Michael Büsch
2023-05-16 17:47 ` Michael Büsch
2023-05-16 17:53 ` Larry Finger
2023-05-16 17:53 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230516191245.4149c51a@barney \
--to=m@bues.ch \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=b43-dev@lists.infradead.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.