* [PATCH] platform/x86: lenovo-yogabook: add I2C dependency
@ 2023-05-19 8:25 Arnd Bergmann
2023-05-23 11:09 ` Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2023-05-19 8:25 UTC (permalink / raw)
To: Hans de Goede, Mark Gross
Cc: Arnd Bergmann, Andy Shevchenko, platform-driver-x86, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The added platform_driver support fails to link when I2C core support is
not rechable:
x86_64-linux-ld: drivers/platform/x86/lenovo-yogabook.o: in function `yogabook_pdev_probe':
lenovo-yogabook.c:(.text+0x5a5): undefined reference to `i2c_bus_type'
Add a Kconfig dependency to enforce a working configuration.
Fixes: 6df1523fa0b7 ("platform/x86: lenovo-yogabook: Add platform driver support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/platform/x86/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 9fe974d5f645..63637ea99c2f 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -125,6 +125,7 @@ config YOGABOOK
tristate "Lenovo Yoga Book tablet key driver"
depends on ACPI_WMI
depends on INPUT
+ depends on I2C
select LEDS_CLASS
select NEW_LEDS
help
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] platform/x86: lenovo-yogabook: add I2C dependency
2023-05-19 8:25 [PATCH] platform/x86: lenovo-yogabook: add I2C dependency Arnd Bergmann
@ 2023-05-23 11:09 ` Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2023-05-23 11:09 UTC (permalink / raw)
To: Arnd Bergmann, Mark Gross
Cc: Arnd Bergmann, Andy Shevchenko, platform-driver-x86, linux-kernel
Hi Arnd,
On 5/19/23 10:25, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The added platform_driver support fails to link when I2C core support is
> not rechable:
>
> x86_64-linux-ld: drivers/platform/x86/lenovo-yogabook.o: in function `yogabook_pdev_probe':
> lenovo-yogabook.c:(.text+0x5a5): undefined reference to `i2c_bus_type'
>
> Add a Kconfig dependency to enforce a working configuration.
>
> Fixes: 6df1523fa0b7 ("platform/x86: lenovo-yogabook: Add platform driver support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thank you I have pushed this to pdx86/for-next now.
Regards,
Hans
> ---
> drivers/platform/x86/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 9fe974d5f645..63637ea99c2f 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -125,6 +125,7 @@ config YOGABOOK
> tristate "Lenovo Yoga Book tablet key driver"
> depends on ACPI_WMI
> depends on INPUT
> + depends on I2C
> select LEDS_CLASS
> select NEW_LEDS
> help
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-23 11:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-19 8:25 [PATCH] platform/x86: lenovo-yogabook: add I2C dependency Arnd Bergmann
2023-05-23 11:09 ` Hans de Goede
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.