From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Clark Wang <xiaoning.wang@nxp.com>
Cc: conor.culhane@silvaco.com, alexandre.belloni@bootlin.com,
linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i3c: master: svc: fix cpu schedule in spin lock
Date: Mon, 22 May 2023 10:32:38 +0200 [thread overview]
Message-ID: <20230522103238.31e17e5d@xps-13> (raw)
In-Reply-To: <20230517033030.3068085-2-xiaoning.wang@nxp.com>
Hi Clark,
xiaoning.wang@nxp.com wrote on Wed, 17 May 2023 11:30:29 +0800:
> pm_runtime_resume_and_get() may call sleep(). It cannot be used in
> svc_i3c_master_start_xfer_locked(), because it is in a spin lock.
>
> Move the pm runtime operations to svc_i3c_master_enqueue_xfer().
>
> Signed-off-by: Clark Wang <xiaoning.wang@nxp.com>
> Fixes: 05be23ef78f7 ("i3c: master: svc: add runtime pm support")
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Thanks,
Miquèl
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Clark Wang <xiaoning.wang@nxp.com>
Cc: conor.culhane@silvaco.com, alexandre.belloni@bootlin.com,
linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i3c: master: svc: fix cpu schedule in spin lock
Date: Mon, 22 May 2023 10:32:38 +0200 [thread overview]
Message-ID: <20230522103238.31e17e5d@xps-13> (raw)
In-Reply-To: <20230517033030.3068085-2-xiaoning.wang@nxp.com>
Hi Clark,
xiaoning.wang@nxp.com wrote on Wed, 17 May 2023 11:30:29 +0800:
> pm_runtime_resume_and_get() may call sleep(). It cannot be used in
> svc_i3c_master_start_xfer_locked(), because it is in a spin lock.
>
> Move the pm runtime operations to svc_i3c_master_enqueue_xfer().
>
> Signed-off-by: Clark Wang <xiaoning.wang@nxp.com>
> Fixes: 05be23ef78f7 ("i3c: master: svc: add runtime pm support")
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Thanks,
Miquèl
next prev parent reply other threads:[~2023-05-22 8:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 3:30 [PATCH] i3c: master: svc: fix i3c suspend/resume issue Clark Wang
2023-05-17 3:30 ` Clark Wang
2023-05-17 3:30 ` [PATCH] i3c: master: svc: fix cpu schedule in spin lock Clark Wang
2023-05-17 3:30 ` Clark Wang
2023-05-22 8:32 ` Miquel Raynal [this message]
2023-05-22 8:32 ` Miquel Raynal
2023-06-04 22:52 ` (subset) " Alexandre Belloni
2023-06-04 22:52 ` Alexandre Belloni
2023-05-17 3:30 ` [PATCH] i3c: master: svc: add NACK check after start byte sent Clark Wang
2023-05-17 3:30 ` Clark Wang
2023-05-22 8:33 ` Miquel Raynal
2023-05-22 8:33 ` Miquel Raynal
2023-05-22 8:31 ` [PATCH] i3c: master: svc: fix i3c suspend/resume issue Miquel Raynal
2023-05-22 8:31 ` Miquel Raynal
2023-06-04 22:52 ` (subset) " Alexandre Belloni
2023-06-04 22:52 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230522103238.31e17e5d@xps-13 \
--to=miquel.raynal@bootlin.com \
--cc=alexandre.belloni@bootlin.com \
--cc=conor.culhane@silvaco.com \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.