From: Kees Cook <keescook@chromium.org>
To: Wyes Karny <wyes.karny@amd.com>
Cc: robert.moore@intel.com, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org,
acpica-devel@lists.linuxfoundation.org, lenb@kernel.org
Subject: Re: [Acpica-devel] [PATCH] acpi: Replace struct acpi_table_slit 1-element array with flex-array
Date: Tue, 23 May 2023 09:44:20 -0700 [thread overview]
Message-ID: <202305230943.0B7B2F73F@keescook> (raw)
In-Reply-To: <20230523161815.3083-1-wyes.karny@amd.com>
On Tue, May 23, 2023 at 04:18:15PM +0000, Wyes Karny wrote:
> struct acpi_table_slit is used for copying System Locality Information
> Table data from ACPI tables. Here `entry` is a flex array but it was
> using ancient 1-element fake flexible array, which has been deprecated.
> Replace it with a C99 flexible array.
>
> Signed-off-by: Wyes Karny <wyes.karny@amd.com>
Eek, thanks. I missed one! :)
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
WARNING: multiple messages have this Message-ID (diff)
From: Kees Cook <keescook@chromium.org>
To: Wyes Karny <wyes.karny@amd.com>
Cc: rafael@kernel.org, lenb@kernel.org, robert.moore@intel.com,
linux-acpi@vger.kernel.org,
acpica-devel@lists.linuxfoundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] acpi: Replace struct acpi_table_slit 1-element array with flex-array
Date: Tue, 23 May 2023 09:44:20 -0700 [thread overview]
Message-ID: <202305230943.0B7B2F73F@keescook> (raw)
In-Reply-To: <20230523161815.3083-1-wyes.karny@amd.com>
On Tue, May 23, 2023 at 04:18:15PM +0000, Wyes Karny wrote:
> struct acpi_table_slit is used for copying System Locality Information
> Table data from ACPI tables. Here `entry` is a flex array but it was
> using ancient 1-element fake flexible array, which has been deprecated.
> Replace it with a C99 flexible array.
>
> Signed-off-by: Wyes Karny <wyes.karny@amd.com>
Eek, thanks. I missed one! :)
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
next prev parent reply other threads:[~2023-05-23 16:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 16:18 [Acpica-devel] [PATCH] acpi: Replace struct acpi_table_slit 1-element array with flex-array Wyes Karny
2023-05-23 16:18 ` Wyes Karny
2023-05-23 16:44 ` Kees Cook [this message]
2023-05-23 16:44 ` Kees Cook
2023-06-01 16:56 ` [Acpica-devel] " Kees Cook
2023-06-01 16:56 ` Kees Cook
2023-06-01 18:21 ` [Acpica-devel] " Rafael J. Wysocki
2023-06-01 18:21 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202305230943.0B7B2F73F@keescook \
--to=keescook@chromium.org \
--cc=acpica-devel@lists.linuxfoundation.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robert.moore@intel.com \
--cc=wyes.karny@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.