Re: [Buildroot] [v1 1/2] package/bootpc: new package

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Colin Foster <colin.foster@in-advantage.com>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [v1 1/2] package/bootpc: new package
Date: Tue, 23 May 2023 22:43:35 +0200	[thread overview]
Message-ID: <20230523204335.GK621937@scaer> (raw)
In-Reply-To: <20230523172120.1948573-2-colin.foster@in-advantage.com>

Colin, All,

On 2023-05-23 10:21 -0700, Colin Foster spake thusly:
> Add the ability to select, build, and run bootpc - a client program for
> BOOTP requests.

Thanks for this new package.

Here is a purely mechanical review:

    $ ./utils/docker-run make check-package
    package/bootpc/0001-main-fix-build.patch:4: generate your patches with 'git format-patch -N'
    package/bootpc/0001-main-fix-build.patch:0: missing Signed-off-by in the header (http://nightly.buildroot.org/#_format_and_licensing_of_the_package_patches)
    package/bootpc/0001-main-fix-build.patch:0: missing Upstream in the header (http://nightly.buildroot.org/#_additional_patch_documentation)
    package/bootpc/0002-Makefile-remove-strip-from-the-build.patch:4: generate your patches with 'git format-patch -N'
    package/bootpc/0002-Makefile-remove-strip-from-the-build.patch:0: missing Signed-off-by in the header (http://nightly.buildroot.org/#_format_and_licensing_of_the_package_patches)
    package/bootpc/0002-Makefile-remove-strip-from-the-build.patch:0: missing Upstream in the header (http://nightly.buildroot.org/#_additional_patch_documentation)
    package/bootpc/Config.in:4: help text: <tab><2 spaces><62 chars> (http://nightly.buildroot.org/#writing-rules-config-in)
    package/bootpc/Config.in:5: empty line at end of file

Also, see below for a few additional comments...

> Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
> ---
>  package/Config.in                             |  1 +
>  package/bootpc/0001-main-fix-build.patch      | 37 +++++++++++++++++++
>  ...Makefile-remove-strip-from-the-build.patch | 28 ++++++++++++++
>  package/bootpc/Config.in                      |  5 +++
>  package/bootpc/bootpc.mk                      | 19 ++++++++++
>  5 files changed, 90 insertions(+)
>  create mode 100644 package/bootpc/0001-main-fix-build.patch
>  create mode 100644 package/bootpc/0002-Makefile-remove-strip-from-the-build.patch
>  create mode 100644 package/bootpc/Config.in
>  create mode 100644 package/bootpc/bootpc.mk
> 
> diff --git a/package/Config.in b/package/Config.in
> index 420ebaa370..07de6500bf 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -2273,6 +2273,7 @@ endif
>  	source "package/bmon/Config.in"
>  	source "package/bmx7/Config.in"
>  	source "package/boinc/Config.in"
> +    source "package/bootpc/Config.in"

Indentation with TAB, not spaces.

(not sure why this one did not get caught by check-package...)

[--SNIP--]
> diff --git a/package/bootpc/bootpc.mk b/package/bootpc/bootpc.mk
> new file mode 100644
> index 0000000000..d3c5ce5198
> --- /dev/null
> +++ b/package/bootpc/bootpc.mk
> @@ -0,0 +1,19 @@
> +################################################################################
> +#
> +# bootpc package
> +#
> +################################################################################
> +
> +BOOTPC_VERSION = 80c0811dc69f9f3923661be4f9f9c09a44313f62
> +BOOTPC_SITE_METHOD = git
> +BOOTPC_SITE = https://salsa.debian.org/debian/bootpc.git

Nit-picking, but we usually put _SITE and _SITE_METHOD in that order:

    BOOTPC_SITE = https://salsa.debian.org/debian/bootpc.git
    BOOTPC_SITE_METHOD = git

You need to also provide the licening terms. It looks like:

    BOOTPC_LICENSE = GPL-2.0-or-later
    BOOTPC_LICENSE_FILES = LICENSE NOTICE

Also, please provide a hash file with hashes for the source tarball [0]
and for each license files; see:
    https://buildroot.org/downloads/manual/manual.html#adding-packages-hash

[0] source tarballs generated from a git checkout have been reproducible
for quite some time now, so we can, and have to, check their hashes.

Also, the upstream README states:

    I'll repeat that.  set up /etc/host.conf or this bit won't work.

We do not provide such a file in Buildroot, so:
 1. is the comment above still valide nowadays?
 2. should the bootpc package install an /etc/host.conf file?

Regards,
Yann E. MORIN.

> +define BOOTPC_BUILD_CMDS
> +	$(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) all
> +endef
> +
> +define BOOTPC_INSTALL_TARGET_CMDS
> +	$(INSTALL) -D -m 0755 $(@D)/bootpc $(TARGET_DIR)/sbin
> +endef
> +
> +$(eval $(generic-package))
> -- 
> 2.25.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot