Re: [Buildroot] [v1 2/2] bootpc: add dhcp-like configuration ability

[Colin Foster <colin.foster@in-advantage.com>]

Hi Yann,

On Tue, May 23, 2023 at 11:18:51PM +0200, Yann E. MORIN wrote:
> Colin, All,
> 
> On 2023-05-23 10:21 -0700, Colin Foster spake thusly:
> > bootpc only works on interfaces that are up. If BOOTP is desired to get
> > an IP address to a running kernel, bootpc won't work.
> > 
> > This scenario was brought up as a bug in Debian forums [1] in 2007. The
> > response was to run the attached script to bring up the network without
> > an IP address. Sure enough, it still works!
> > 
> > Implement this bootpc script to allow IP configuration by way of
> > "iface eth0 inet bootp" in /etc/network/interfaces.
> 
> Can't one just use a pre-up command ?
> 
>     iface eth0 inet bootp
>         pre-up ip l set dev eth0 up
>         pre-up ip r add default dev eth0
>         post-up ip r del default dev eth0
> 
> Not sure that would work, but maybe worth a try?

I'll give it a shot. I tried a bunch of pre-up / post-up commands before
I found the script, but can't say I tried exactly this. I fully agree
though, if the script + rename implementation isn't needed, it should be
avoided.

> 
> Ditto as for patch 1/2: run check-package.

Apologies again. I'll clean up v2 and appreciate the feedback! And I'm
ack-ing everything you said below.

> 
> [--SNIP--]
> > diff --git a/package/bootpc/bootpc.mk b/package/bootpc/bootpc.mk
> > index d3c5ce5198..ebd7490ea1 100644
> > --- a/package/bootpc/bootpc.mk
> > +++ b/package/bootpc/bootpc.mk
> > @@ -8,12 +8,28 @@ BOOTPC_VERSION = 80c0811dc69f9f3923661be4f9f9c09a44313f62
> >  BOOTPC_SITE_METHOD = git
> >  BOOTPC_SITE = https://salsa.debian.org/debian/bootpc.git
> >  
> > +ifeq ($(BR2_PACKAGE_BOOTPC_FULL_CONFIG),y)
> > +BOOTPC_TARGET_BIN_NAME = bootpc-bin
> > +else
> > +BOOTPC_TARGET_BIN_NAME = bootpc
> > +endif
> > +
> >  define BOOTPC_BUILD_CMDS
> > -	$(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) all
> > +	$(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) PROG=$(BOOTPC_TARGET_BIN_NAME) -C $(@D) all
> 
> Please keep lines below the ~80 char limit, e.g.:
> 
>         $(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) \
>             -C $(@D) \
>             PROG=$(BOOTPC_TARGET_BIN_NAME) \
>             all
> 
> (I like to see '-C $(@D)' to be the first thing right after the call to
> make).
> 
> > +endef
> > +
> > +ifeq ($(BR2_PACKAGE_BOOTPC_FULL_CONFIG),y)
> > +define BOOTPC_INSTALL_CONFIG_SCRIPT
> > +	$(INSTALL) -m 0755 $(BR2_EXTERNAL_BR2INADVANTAGE_PATH)/package/bootpc/bootpc_dhcp_script $(TARGET_DIR)/sbin/bootpc
> > +endef
> > +else
> > +define BOOTPC_INSTALL_CONFIG_SCRIPT ""
> >  endef
> 
> No need to define an empty macro.
> 
> Regards,
> Yann E. MORIN.
> 
> -- 
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> | +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> '------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot