From: Jakub Kicinski <kuba@kernel.org>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: netdev@vger.kernel.org, Abaci Robot <abaci@linux.alibaba.com>,
jesse.brandeburg@intel.com, linux-kernel@vger.kernel.org,
edumazet@google.com, intel-wired-lan@lists.osuosl.org,
anthony.l.nguyen@intel.com, pabeni@redhat.com,
davem@davemloft.net
Subject: Re: [Intel-wired-lan] [PATCH v2] iavf: Remove useless else if
Date: Wed, 24 May 2023 08:51:57 -0700 [thread overview]
Message-ID: <20230524085157.59aeebea@kernel.org> (raw)
In-Reply-To: <20230524100203.28645-1-jiapeng.chong@linux.alibaba.com>
On Wed, 24 May 2023 18:02:03 +0800 Jiapeng Chong wrote:
> The assignment of the else and if branches is the same, so the if else
> here is redundant, so we remove it.
>
> ./drivers/net/ethernet/intel/iavf/iavf_main.c:2203:6-8: WARNING: possible condition with no effect (if == else).
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5255
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Looking thru git history most of the patches you send for this check
are converting perfectly valid code. Please change the check to ignore
if (cond)
/*A*/
else if (cond2)
/*B*/
else
/*B*/
--
pw-bot: reject
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH v2] iavf: Remove useless else if
Date: Wed, 24 May 2023 08:51:57 -0700 [thread overview]
Message-ID: <20230524085157.59aeebea@kernel.org> (raw)
In-Reply-To: <20230524100203.28645-1-jiapeng.chong@linux.alibaba.com>
On Wed, 24 May 2023 18:02:03 +0800 Jiapeng Chong wrote:
> The assignment of the else and if branches is the same, so the if else
> here is redundant, so we remove it.
>
> ./drivers/net/ethernet/intel/iavf/iavf_main.c:2203:6-8: WARNING: possible condition with no effect (if == else).
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5255
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Looking thru git history most of the patches you send for this check
are converting perfectly valid code. Please change the check to ignore
if (cond)
/*A*/
else if (cond2)
/*B*/
else
/*B*/
--
pw-bot: reject
next prev parent reply other threads:[~2023-05-24 15:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 10:02 [Intel-wired-lan] [PATCH v2] iavf: Remove useless else if Jiapeng Chong
2023-05-24 10:02 ` Jiapeng Chong
2023-05-24 15:51 ` Jakub Kicinski [this message]
2023-05-24 15:51 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230524085157.59aeebea@kernel.org \
--to=kuba@kernel.org \
--cc=abaci@linux.alibaba.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.