Re: [PATCH tests 2/5] tests: add a new test for rdev lifetime

[Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>]

On Tue, 23 May 2023 21:38:57 +0800
Yu Kuai <yukuai1@huaweicloud.com> wrote:

> From: Yu Kuai <yukuai3@huawei.com>
> 
> This test add and remove a underlying disk to raid concurretly, verify
> that the following problem is fixed:

As in previous patch, feel free to move it into separate directory.

This test is limited only to this particular problem you resolved because you
are verifying error message in dmesg. It has no additional value because
probability that this issue will ever more occur in the same shape is
minimal.

IMO you should check how "remove" and "add" are handled, if errors are
returned, if there is no trace in dmesg or if processes are not blocked in
kernel.
You can check for this error message as a additional step at the end of test
but not as a mandatory test pass criteria.

In current form it gives as a knowledge that particular kernel doesn't have your
fix, that is all. Because it is race, probably it is not impacting real life
scenarios, so that gives a weak motivation to backport the fix (only security
reasons matters).

I don't see that this particular scenario requires test. You need to make it
more valuable for the future.
 
Thanks,
Mariusz