From: "Michael S. Tsirkin" <mst@redhat.com>
To: Mike Christie <michael.christie@oracle.com>
Cc: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
stefanha@redhat.com, jasowang@redhat.com, sgarzare@redhat.com,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH 0/3] vhost-scsi: Fix IO hangs when using windows
Date: Thu, 25 May 2023 03:59:39 -0400 [thread overview]
Message-ID: <20230525035847-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20230524233407.41432-1-michael.christie@oracle.com>
On Wed, May 24, 2023 at 06:34:04PM -0500, Mike Christie wrote:
> The following patches were made over Linus's tree and fix an issue
> where windows guests will send iovecs with offset/lengths that result
> in IOs that are not aligned to 512. The LIO layer will then send them
> to Linux's block layer but it requires 512 byte alignment, so depending
> on the block driver being used we will get IO errors or hung IO.
>
> The following patches have vhost-scsi detect when windows sends these
> IOs and copy them to a bounce buffer. It then does some cleanup in
> the related code.
Normally with virtio we'd have a feature bit that allows skipping alignment
checks. Teach linux to set it. Stefan, WDYT?
--
MST
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Mike Christie <michael.christie@oracle.com>
Cc: linux-scsi@vger.kernel.org,
virtualization@lists.linux-foundation.org,
target-devel@vger.kernel.org, stefanha@redhat.com
Subject: Re: [PATCH 0/3] vhost-scsi: Fix IO hangs when using windows
Date: Thu, 25 May 2023 03:59:39 -0400 [thread overview]
Message-ID: <20230525035847-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20230524233407.41432-1-michael.christie@oracle.com>
On Wed, May 24, 2023 at 06:34:04PM -0500, Mike Christie wrote:
> The following patches were made over Linus's tree and fix an issue
> where windows guests will send iovecs with offset/lengths that result
> in IOs that are not aligned to 512. The LIO layer will then send them
> to Linux's block layer but it requires 512 byte alignment, so depending
> on the block driver being used we will get IO errors or hung IO.
>
> The following patches have vhost-scsi detect when windows sends these
> IOs and copy them to a bounce buffer. It then does some cleanup in
> the related code.
Normally with virtio we'd have a feature bit that allows skipping alignment
checks. Teach linux to set it. Stefan, WDYT?
--
MST
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2023-05-25 8:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 23:34 [PATCH 0/3] vhost-scsi: Fix IO hangs when using windows Mike Christie
2023-05-24 23:34 ` Mike Christie
2023-05-24 23:34 ` [PATCH 1/3] vhost-scsi: Fix alignment handling with windows Mike Christie
2023-05-24 23:34 ` Mike Christie
2023-05-25 7:57 ` Michael S. Tsirkin
2023-05-25 7:57 ` Michael S. Tsirkin
2023-05-25 15:43 ` Mike Christie
2023-05-25 15:43 ` Mike Christie
2023-05-25 19:05 ` kernel test robot
2023-05-25 19:05 ` kernel test robot
2023-05-24 23:34 ` [PATCH 2/3] vhost-scsi: Remove unused write argument Mike Christie
2023-05-24 23:34 ` Mike Christie
2023-05-24 23:34 ` [PATCH 3/3] vhost-scsi: Rename vhost_scsi_iov_to_sgl Mike Christie
2023-05-24 23:34 ` Mike Christie
2023-05-25 7:59 ` Michael S. Tsirkin [this message]
2023-05-25 7:59 ` [PATCH 0/3] vhost-scsi: Fix IO hangs when using windows Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230525035847-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=jasowang@redhat.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michael.christie@oracle.com \
--cc=sgarzare@redhat.com \
--cc=stefanha@redhat.com \
--cc=target-devel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.