From: Lee Jones <lee@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Daniel Thompson <daniel.thompson@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>,
Michael Hennerich <michael.hennerich@analog.com>,
Helge Deller <deller@gmx.de>, Jianhua Lu <lujianhua000@gmail.com>,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH] backlight: Switch i2c drivers back to use .probe()
Date: Thu, 25 May 2023 12:24:41 +0100 [thread overview]
Message-ID: <20230525112441.GA423913@google.com> (raw)
In-Reply-To: <20230521143844.375244-1-u.kleine-koenig@pengutronix.de>
On Sun, 21 May 2023, Uwe Kleine-König wrote:
> After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
> call-back type"), all drivers being converted to .probe_new() and then
> 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter") convert
> back to (the new) .probe() to be able to eventually drop .probe_new() from
> struct i2c_driver.
>
> Also fix two indention inconsistencies in the neighbourhood.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Hello,
>
> this patch was generated using coccinelle, but I aligned the result to
> the per-file indention.
>
> This is one patch for the whole backlight subsystem. If you want it
> split per driver for improved patch count numbers, please tell me.
>
> Currently there are no changes to drivers/video/backlight in next, so
> the change should apply fine. If however there are other changes that
> result in conflicts, feel free to just drop the hunks in the relevant
> files and apply anyhow. I'll care about the fallout later.
>
> Best regards
> Uwe
>
>
> drivers/video/backlight/adp8860_bl.c | 4 ++--
> drivers/video/backlight/adp8870_bl.c | 4 ++--
> drivers/video/backlight/arcxcnn_bl.c | 2 +-
> drivers/video/backlight/bd6107.c | 2 +-
> drivers/video/backlight/ktz8866.c | 2 +-
> drivers/video/backlight/lm3630a_bl.c | 2 +-
> drivers/video/backlight/lm3639_bl.c | 2 +-
> drivers/video/backlight/lp855x_bl.c | 2 +-
> drivers/video/backlight/lv5207lp.c | 2 +-
> 9 files changed, 11 insertions(+), 11 deletions(-)
Applied, thanks
--
Lee Jones [李琼斯]
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Daniel Thompson <daniel.thompson@linaro.org>,
Michael Hennerich <michael.hennerich@analog.com>,
Jingoo Han <jingoohan1@gmail.com>, Helge Deller <deller@gmx.de>,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
Jianhua Lu <lujianhua000@gmail.com>,
kernel@pengutronix.de
Subject: Re: [PATCH] backlight: Switch i2c drivers back to use .probe()
Date: Thu, 25 May 2023 12:24:41 +0100 [thread overview]
Message-ID: <20230525112441.GA423913@google.com> (raw)
In-Reply-To: <20230521143844.375244-1-u.kleine-koenig@pengutronix.de>
On Sun, 21 May 2023, Uwe Kleine-König wrote:
> After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
> call-back type"), all drivers being converted to .probe_new() and then
> 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter") convert
> back to (the new) .probe() to be able to eventually drop .probe_new() from
> struct i2c_driver.
>
> Also fix two indention inconsistencies in the neighbourhood.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Hello,
>
> this patch was generated using coccinelle, but I aligned the result to
> the per-file indention.
>
> This is one patch for the whole backlight subsystem. If you want it
> split per driver for improved patch count numbers, please tell me.
>
> Currently there are no changes to drivers/video/backlight in next, so
> the change should apply fine. If however there are other changes that
> result in conflicts, feel free to just drop the hunks in the relevant
> files and apply anyhow. I'll care about the fallout later.
>
> Best regards
> Uwe
>
>
> drivers/video/backlight/adp8860_bl.c | 4 ++--
> drivers/video/backlight/adp8870_bl.c | 4 ++--
> drivers/video/backlight/arcxcnn_bl.c | 2 +-
> drivers/video/backlight/bd6107.c | 2 +-
> drivers/video/backlight/ktz8866.c | 2 +-
> drivers/video/backlight/lm3630a_bl.c | 2 +-
> drivers/video/backlight/lm3639_bl.c | 2 +-
> drivers/video/backlight/lp855x_bl.c | 2 +-
> drivers/video/backlight/lv5207lp.c | 2 +-
> 9 files changed, 11 insertions(+), 11 deletions(-)
Applied, thanks
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2023-05-25 11:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-21 14:38 [PATCH] backlight: Switch i2c drivers back to use .probe() Uwe Kleine-König
2023-05-21 14:38 ` Uwe Kleine-König
2023-05-25 11:24 ` Lee Jones [this message]
2023-05-25 11:24 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230525112441.GA423913@google.com \
--to=lee@kernel.org \
--cc=daniel.thompson@linaro.org \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-fbdev@vger.kernel.org \
--cc=lujianhua000@gmail.com \
--cc=michael.hennerich@analog.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.