From: Luis Chamberlain <mcgrof@kernel.org>
To: axboe@kernel.dk, agk@redhat.com, snitzer@kernel.org,
philipp.reisner@linbit.com, lars.ellenberg@linbit.com,
christoph.boehmwalder@linbit.com, hch@infradead.org,
djwong@kernel.org, minchan@kernel.org, senozhatsky@chromium.org
Cc: p.raghav@samsung.com, linux-xfs@vger.kernel.org,
rohan.puri@samsung.com, da.gomez@samsung.com, mcgrof@kernel.org,
patches@lists.linux.dev, willy@infradead.org,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
linux-mm@kvack.org, dm-devel@redhat.com,
linux-fsdevel@vger.kernel.org, rpuri.linux@gmail.com,
kbusch@kernel.org, drbd-dev@lists.linbit.com
Subject: [dm-devel] [PATCH v2 4/5] dm bufio: simplify by using PAGE_SECTORS_SHIFT
Date: Fri, 26 May 2023 00:33:35 -0700 [thread overview]
Message-ID: <20230526073336.344543-5-mcgrof@kernel.org> (raw)
In-Reply-To: <20230526073336.344543-1-mcgrof@kernel.org>
The PAGE_SHIFT - SECTOR_SHIFT constant be replaced with PAGE_SECTORS_SHIFT
defined in linux/blt_types.h, which is included by linux/blkdev.h.
This produces no functional changes.
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
drivers/md/dm-bufio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/md/dm-bufio.c b/drivers/md/dm-bufio.c
index eea977662e81..08c4730e1819 100644
--- a/drivers/md/dm-bufio.c
+++ b/drivers/md/dm-bufio.c
@@ -1152,7 +1152,7 @@ static void *alloc_buffer_data(struct dm_bufio_client *c, gfp_t gfp_mask,
gfp_mask & __GFP_NORETRY) {
*data_mode = DATA_MODE_GET_FREE_PAGES;
return (void *)__get_free_pages(gfp_mask,
- c->sectors_per_block_bits - (PAGE_SHIFT - SECTOR_SHIFT));
+ c->sectors_per_block_bits - (PAGE_SECTORS_SHIFT));
}
*data_mode = DATA_MODE_VMALLOC;
@@ -1190,7 +1190,7 @@ static void free_buffer_data(struct dm_bufio_client *c,
case DATA_MODE_GET_FREE_PAGES:
free_pages((unsigned long)data,
- c->sectors_per_block_bits - (PAGE_SHIFT - SECTOR_SHIFT));
+ c->sectors_per_block_bits - (PAGE_SECTORS_SHIFT));
break;
case DATA_MODE_VMALLOC:
--
2.39.2
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
WARNING: multiple messages have this Message-ID (diff)
From: Luis Chamberlain <mcgrof@kernel.org>
To: axboe@kernel.dk, agk@redhat.com, snitzer@kernel.org,
philipp.reisner@linbit.com, lars.ellenberg@linbit.com,
christoph.boehmwalder@linbit.com, hch@infradead.org,
djwong@kernel.org, minchan@kernel.org, senozhatsky@chromium.org
Cc: patches@lists.linux.dev, linux-block@vger.kernel.org,
linux-mm@kvack.org, linux-xfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, dm-devel@redhat.com,
drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org,
willy@infradead.org, hare@suse.de, p.raghav@samsung.com,
da.gomez@samsung.com, rohan.puri@samsung.com,
rpuri.linux@gmail.com, kbusch@kernel.org, mcgrof@kernel.org
Subject: [PATCH v2 4/5] dm bufio: simplify by using PAGE_SECTORS_SHIFT
Date: Fri, 26 May 2023 00:33:35 -0700 [thread overview]
Message-ID: <20230526073336.344543-5-mcgrof@kernel.org> (raw)
In-Reply-To: <20230526073336.344543-1-mcgrof@kernel.org>
The PAGE_SHIFT - SECTOR_SHIFT constant be replaced with PAGE_SECTORS_SHIFT
defined in linux/blt_types.h, which is included by linux/blkdev.h.
This produces no functional changes.
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
drivers/md/dm-bufio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/md/dm-bufio.c b/drivers/md/dm-bufio.c
index eea977662e81..08c4730e1819 100644
--- a/drivers/md/dm-bufio.c
+++ b/drivers/md/dm-bufio.c
@@ -1152,7 +1152,7 @@ static void *alloc_buffer_data(struct dm_bufio_client *c, gfp_t gfp_mask,
gfp_mask & __GFP_NORETRY) {
*data_mode = DATA_MODE_GET_FREE_PAGES;
return (void *)__get_free_pages(gfp_mask,
- c->sectors_per_block_bits - (PAGE_SHIFT - SECTOR_SHIFT));
+ c->sectors_per_block_bits - (PAGE_SECTORS_SHIFT));
}
*data_mode = DATA_MODE_VMALLOC;
@@ -1190,7 +1190,7 @@ static void free_buffer_data(struct dm_bufio_client *c,
case DATA_MODE_GET_FREE_PAGES:
free_pages((unsigned long)data,
- c->sectors_per_block_bits - (PAGE_SHIFT - SECTOR_SHIFT));
+ c->sectors_per_block_bits - (PAGE_SECTORS_SHIFT));
break;
case DATA_MODE_VMALLOC:
--
2.39.2
WARNING: multiple messages have this Message-ID (diff)
From: Luis Chamberlain <mcgrof@kernel.org>
To: axboe@kernel.dk, agk@redhat.com, snitzer@kernel.org,
philipp.reisner@linbit.com, lars.ellenberg@linbit.com,
christoph.boehmwalder@linbit.com, hch@infradead.org,
djwong@kernel.org, minchan@kernel.org, senozhatsky@chromium.org
Cc: p.raghav@samsung.com, linux-xfs@vger.kernel.org,
rohan.puri@samsung.com, da.gomez@samsung.com, mcgrof@kernel.org,
patches@lists.linux.dev, willy@infradead.org,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
linux-mm@kvack.org, dm-devel@redhat.com, hare@suse.de,
linux-fsdevel@vger.kernel.org, rpuri.linux@gmail.com,
kbusch@kernel.org, drbd-dev@lists.linbit.com
Subject: [Drbd-dev] [PATCH v2 4/5] dm bufio: simplify by using PAGE_SECTORS_SHIFT
Date: Fri, 26 May 2023 00:33:35 -0700 [thread overview]
Message-ID: <20230526073336.344543-5-mcgrof@kernel.org> (raw)
In-Reply-To: <20230526073336.344543-1-mcgrof@kernel.org>
The PAGE_SHIFT - SECTOR_SHIFT constant be replaced with PAGE_SECTORS_SHIFT
defined in linux/blt_types.h, which is included by linux/blkdev.h.
This produces no functional changes.
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
drivers/md/dm-bufio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/md/dm-bufio.c b/drivers/md/dm-bufio.c
index eea977662e81..08c4730e1819 100644
--- a/drivers/md/dm-bufio.c
+++ b/drivers/md/dm-bufio.c
@@ -1152,7 +1152,7 @@ static void *alloc_buffer_data(struct dm_bufio_client *c, gfp_t gfp_mask,
gfp_mask & __GFP_NORETRY) {
*data_mode = DATA_MODE_GET_FREE_PAGES;
return (void *)__get_free_pages(gfp_mask,
- c->sectors_per_block_bits - (PAGE_SHIFT - SECTOR_SHIFT));
+ c->sectors_per_block_bits - (PAGE_SECTORS_SHIFT));
}
*data_mode = DATA_MODE_VMALLOC;
@@ -1190,7 +1190,7 @@ static void free_buffer_data(struct dm_bufio_client *c,
case DATA_MODE_GET_FREE_PAGES:
free_pages((unsigned long)data,
- c->sectors_per_block_bits - (PAGE_SHIFT - SECTOR_SHIFT));
+ c->sectors_per_block_bits - (PAGE_SECTORS_SHIFT));
break;
case DATA_MODE_VMALLOC:
--
2.39.2
next prev parent reply other threads:[~2023-05-26 7:34 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-26 7:33 [dm-devel] [PATCH v2 0/5] block: simplify with PAGE_SECTORS_SHIFT Luis Chamberlain
2023-05-26 7:33 ` [Drbd-dev] " Luis Chamberlain
2023-05-26 7:33 ` Luis Chamberlain
2023-05-26 7:33 ` [dm-devel] [PATCH v2 1/5] block: annotate bdev_disk_changed() deprecation with a symbol namespace Luis Chamberlain
2023-05-26 7:33 ` [Drbd-dev] " Luis Chamberlain
2023-05-26 7:33 ` Luis Chamberlain
2023-05-26 8:13 ` [dm-devel] " Christoph Hellwig
2023-05-26 8:13 ` [Drbd-dev] " Christoph Hellwig
2023-05-26 8:13 ` Christoph Hellwig
2023-05-26 8:20 ` [dm-devel] " Luis Chamberlain
2023-05-26 8:20 ` [Drbd-dev] " Luis Chamberlain
2023-05-26 8:20 ` Luis Chamberlain
2023-05-26 7:33 ` [dm-devel] [PATCH v2 2/5] drbd: use PAGE_SECTORS_SHIFT and PAGE_SECTORS Luis Chamberlain
2023-05-26 7:33 ` [Drbd-dev] " Luis Chamberlain
2023-05-26 7:33 ` Luis Chamberlain
2023-05-26 9:20 ` [dm-devel] " Johannes Thumshirn
2023-05-26 9:20 ` [Drbd-dev] " Johannes Thumshirn
2023-05-26 9:20 ` Johannes Thumshirn
2023-05-26 7:33 ` [dm-devel] [PATCH v2 3/5] iomap: simplify iomap_init() with PAGE_SECTORS Luis Chamberlain
2023-05-26 7:33 ` [Drbd-dev] " Luis Chamberlain
2023-05-26 7:33 ` Luis Chamberlain
2023-05-26 8:13 ` [dm-devel] " Christoph Hellwig
2023-05-26 8:13 ` [Drbd-dev] " Christoph Hellwig
2023-05-26 8:13 ` Christoph Hellwig
2023-05-26 9:20 ` [dm-devel] " Johannes Thumshirn
2023-05-26 9:20 ` [Drbd-dev] " Johannes Thumshirn
2023-05-26 9:20 ` Johannes Thumshirn
2023-05-26 7:33 ` Luis Chamberlain [this message]
2023-05-26 7:33 ` [Drbd-dev] [PATCH v2 4/5] dm bufio: simplify by using PAGE_SECTORS_SHIFT Luis Chamberlain
2023-05-26 7:33 ` Luis Chamberlain
2023-05-26 9:21 ` [dm-devel] " Johannes Thumshirn
2023-05-26 9:21 ` [Drbd-dev] " Johannes Thumshirn
2023-05-26 9:21 ` Johannes Thumshirn
2023-05-26 7:33 ` [dm-devel] [PATCH v2 5/5] zram: use generic PAGE_SECTORS and PAGE_SECTORS_SHIFT Luis Chamberlain
2023-05-26 7:33 ` [Drbd-dev] " Luis Chamberlain
2023-05-26 7:33 ` Luis Chamberlain
2023-05-26 9:24 ` [dm-devel] " Johannes Thumshirn
2023-05-26 9:24 ` [Drbd-dev] " Johannes Thumshirn
2023-05-26 9:24 ` Johannes Thumshirn
2023-05-26 9:26 ` [dm-devel] [PATCH v2 0/5] block: simplify with PAGE_SECTORS_SHIFT Johannes Thumshirn
2023-05-26 9:26 ` [Drbd-dev] " Johannes Thumshirn
2023-05-26 9:26 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230526073336.344543-5-mcgrof@kernel.org \
--to=mcgrof@kernel.org \
--cc=agk@redhat.com \
--cc=axboe@kernel.dk \
--cc=christoph.boehmwalder@linbit.com \
--cc=da.gomez@samsung.com \
--cc=djwong@kernel.org \
--cc=dm-devel@redhat.com \
--cc=drbd-dev@lists.linbit.com \
--cc=hch@infradead.org \
--cc=kbusch@kernel.org \
--cc=lars.ellenberg@linbit.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=p.raghav@samsung.com \
--cc=patches@lists.linux.dev \
--cc=philipp.reisner@linbit.com \
--cc=rohan.puri@samsung.com \
--cc=rpuri.linux@gmail.com \
--cc=senozhatsky@chromium.org \
--cc=snitzer@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.