From: Daniel Thompson <daniel.thompson@linaro.org>
To: Alexandru Ardelean <alex@shruggie.ro>
Cc: dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fbdev@vger.kernel.org, lee@kernel.org,
jingoohan1@gmail.com, pavel@ucw.cz, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
deller@gmx.de, Yannick Fertre <yannick.fertre@foss.st.com>,
Philippe CORNU <philippe.cornu@foss.st.com>
Subject: Re: [PATCH 1/2] backlight: gpio_backlight: add new property default-brightness-level
Date: Fri, 26 May 2023 11:27:08 +0100 [thread overview]
Message-ID: <20230526102708.GC626291@aspen.lan> (raw)
In-Reply-To: <20230519200520.10657-1-alex@shruggie.ro>
On Fri, May 19, 2023 at 11:05:19PM +0300, Alexandru Ardelean wrote:
> From: Yannick Fertre <yannick.fertre@foss.st.com>
>
> Add new property to set a brightness by default at probe.
>
> Reviewed-by: Philippe CORNU <philippe.cornu@foss.st.com>
> Signed-off-by: Yannick Fertre <yannick.fertre@foss.st.com>
> Signed-off-by: Alexandru Ardelean <alex@shruggie.ro>
Patch order should be reversed for v2. Nevertheless:
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Daniel.
> struct backlight_device *bl;
> struct gpio_backlight *gbl;
> int ret, init_brightness, def_value;
> + u32 value;
>
> gbl = devm_kzalloc(dev, sizeof(*gbl), GFP_KERNEL);
> if (gbl == NULL)
> @@ -93,7 +94,11 @@ static int gpio_backlight_probe(struct platform_device *pdev)
> else
> bl->props.power = FB_BLANK_UNBLANK;
>
> - bl->props.brightness = 1;
> + ret = device_property_read_u32(dev, "default-brightness-level", &value);
> + if (!ret && value <= props.max_brightness)
> + bl->props.brightness = value;
> + else
> + bl->props.brightness = 1;
>
> init_brightness = backlight_get_brightness(bl);
> ret = gpiod_direction_output(gbl->gpiod, init_brightness);
> --
> 2.40.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Thompson <daniel.thompson@linaro.org>
To: Alexandru Ardelean <alex@shruggie.ro>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org,
linux-fbdev@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org,
jingoohan1@gmail.com, deller@gmx.de, lee@kernel.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
robh+dt@kernel.org, Philippe CORNU <philippe.cornu@foss.st.com>,
pavel@ucw.cz, Yannick Fertre <yannick.fertre@foss.st.com>,
linux-leds@vger.kernel.org
Subject: Re: [PATCH 1/2] backlight: gpio_backlight: add new property default-brightness-level
Date: Fri, 26 May 2023 11:27:08 +0100 [thread overview]
Message-ID: <20230526102708.GC626291@aspen.lan> (raw)
In-Reply-To: <20230519200520.10657-1-alex@shruggie.ro>
On Fri, May 19, 2023 at 11:05:19PM +0300, Alexandru Ardelean wrote:
> From: Yannick Fertre <yannick.fertre@foss.st.com>
>
> Add new property to set a brightness by default at probe.
>
> Reviewed-by: Philippe CORNU <philippe.cornu@foss.st.com>
> Signed-off-by: Yannick Fertre <yannick.fertre@foss.st.com>
> Signed-off-by: Alexandru Ardelean <alex@shruggie.ro>
Patch order should be reversed for v2. Nevertheless:
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Daniel.
> struct backlight_device *bl;
> struct gpio_backlight *gbl;
> int ret, init_brightness, def_value;
> + u32 value;
>
> gbl = devm_kzalloc(dev, sizeof(*gbl), GFP_KERNEL);
> if (gbl == NULL)
> @@ -93,7 +94,11 @@ static int gpio_backlight_probe(struct platform_device *pdev)
> else
> bl->props.power = FB_BLANK_UNBLANK;
>
> - bl->props.brightness = 1;
> + ret = device_property_read_u32(dev, "default-brightness-level", &value);
> + if (!ret && value <= props.max_brightness)
> + bl->props.brightness = value;
> + else
> + bl->props.brightness = 1;
>
> init_brightness = backlight_get_brightness(bl);
> ret = gpiod_direction_output(gbl->gpiod, init_brightness);
> --
> 2.40.1
>
next prev parent reply other threads:[~2023-05-26 10:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-19 20:05 [PATCH 1/2] backlight: gpio_backlight: add new property default-brightness-level Alexandru Ardelean
2023-05-19 20:05 ` Alexandru Ardelean
2023-05-19 20:05 ` [PATCH 2/2] dt-bindings: backlight: document " Alexandru Ardelean
2023-05-19 20:05 ` Alexandru Ardelean
2023-05-26 10:20 ` Daniel Thompson
2023-05-26 10:20 ` Daniel Thompson
2023-05-29 7:03 ` Alexandru Ardelean
2023-05-29 7:03 ` Alexandru Ardelean
2023-05-26 12:05 ` Philippe CORNU
2023-05-26 12:05 ` Philippe CORNU
2023-05-29 7:03 ` Alexandru Ardelean
2023-05-29 7:03 ` Alexandru Ardelean
2023-05-26 10:27 ` Daniel Thompson [this message]
2023-05-26 10:27 ` [PATCH 1/2] backlight: gpio_backlight: add " Daniel Thompson
2023-05-26 12:04 ` Philippe CORNU
2023-05-26 12:04 ` Philippe CORNU
2023-05-29 7:02 ` Alexandru Ardelean
2023-05-29 7:02 ` Alexandru Ardelean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230526102708.GC626291@aspen.lan \
--to=daniel.thompson@linaro.org \
--cc=alex@shruggie.ro \
--cc=conor+dt@kernel.org \
--cc=deller@gmx.de \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=philippe.cornu@foss.st.com \
--cc=robh+dt@kernel.org \
--cc=yannick.fertre@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.