From: Aravind Iddamsetty <aravind.iddamsetty@intel.com>
To: intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: alexander.deucher@amd.com, joonas.lahtinen@linux.intel.com,
airlied@gmail.com, daniel@ffwll.ch
Subject: [Intel-xe] [RFC 5/5] drm/xe/RAS: send multicast event on occurrence of an error
Date: Fri, 26 May 2023 21:50:16 +0530 [thread overview]
Message-ID: <20230526162016.428357-6-aravind.iddamsetty@intel.com> (raw)
In-Reply-To: <20230526162016.428357-1-aravind.iddamsetty@intel.com>
Whenever a correctable or an uncorrectable error happens an event is sent
to the corresponding listeners of these groups.
Signed-off-by: Aravind Iddamsetty <aravind.iddamsetty@intel.com>
---
drivers/gpu/drm/xe/xe_irq.c | 32 ++++++++++++++++++++++++++++++++
drivers/gpu/drm/xe/xe_netlink.c | 2 ++
2 files changed, 34 insertions(+)
diff --git a/drivers/gpu/drm/xe/xe_irq.c b/drivers/gpu/drm/xe/xe_irq.c
index 226be96e341a..1b415c8585a4 100644
--- a/drivers/gpu/drm/xe/xe_irq.c
+++ b/drivers/gpu/drm/xe/xe_irq.c
@@ -1073,6 +1073,37 @@ xe_gsc_hw_error_handler(struct xe_gt *gt, const enum hardware_error hw_err)
xe_mmio_write32(gt, GSC_HEC_CORR_UNCORR_ERR_STATUS(base, hw_err).reg, err_status);
}
+static void generate_netlink_event(struct xe_gt *gt, const enum hardware_error hw_err)
+{
+ struct xe_device *xe = gt->xe;
+ struct sk_buff *msg;
+ void *hdr;
+
+ if (!xe->xe_genl_family.module)
+ return;
+
+ msg = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_ATOMIC);
+ if (!msg) {
+ drm_dbg_driver(&xe->drm, "couldn't allocate memory for error multicast event\n");
+ return;
+ }
+
+ hdr = genlmsg_put(msg, 0, 0, &xe->xe_genl_family, 0, DRM_CMD_ERROR_EVENT);
+ if (!hdr) {
+ drm_dbg_driver(&xe->drm, "mutlicast msg buffer is small\n");
+ nlmsg_free(msg);
+ return;
+ }
+
+ genlmsg_end(msg, hdr);
+
+ genlmsg_multicast(&xe->xe_genl_family, msg, 0,
+ hw_err ?
+ DRM_GENL_MCAST_UNCORR_ERR
+ : DRM_GENL_MCAST_CORR_ERR,
+ GFP_ATOMIC);
+}
+
static void
xe_hw_error_source_handler(struct xe_gt *gt, const enum hardware_error hw_err)
{
@@ -1103,6 +1134,7 @@ xe_hw_error_source_handler(struct xe_gt *gt, const enum hardware_error hw_err)
xe_mmio_write32(gt, DEV_ERR_STAT_REG(hw_err).reg, errsrc);
+ generate_netlink_event(gt, hw_err);
out_unlock:
spin_unlock_irqrestore(>_to_xe(gt)->irq.lock, flags);
}
diff --git a/drivers/gpu/drm/xe/xe_netlink.c b/drivers/gpu/drm/xe/xe_netlink.c
index 2a6965f5cde9..0c1d51e1a9a5 100644
--- a/drivers/gpu/drm/xe/xe_netlink.c
+++ b/drivers/gpu/drm/xe/xe_netlink.c
@@ -490,6 +490,8 @@ static void xe_genl_family_init(struct xe_device *xe)
xe->xe_genl_family.ops = xe_genl_ops;
xe->xe_genl_family.n_ops = ARRAY_SIZE(xe_genl_ops);
xe->xe_genl_family.maxattr = DRM_ATTR_MAX;
+ xe->xe_genl_family.mcgrps = drm_event_mcgrps;
+ xe->xe_genl_family.n_mcgrps = ARRAY_SIZE(drm_event_mcgrps);
xe->xe_genl_family.module = THIS_MODULE;
}
--
2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Aravind Iddamsetty <aravind.iddamsetty@intel.com>
To: intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: alexander.deucher@amd.com, ogabbay@kernel.org
Subject: [RFC 5/5] drm/xe/RAS: send multicast event on occurrence of an error
Date: Fri, 26 May 2023 21:50:16 +0530 [thread overview]
Message-ID: <20230526162016.428357-6-aravind.iddamsetty@intel.com> (raw)
In-Reply-To: <20230526162016.428357-1-aravind.iddamsetty@intel.com>
Whenever a correctable or an uncorrectable error happens an event is sent
to the corresponding listeners of these groups.
Signed-off-by: Aravind Iddamsetty <aravind.iddamsetty@intel.com>
---
drivers/gpu/drm/xe/xe_irq.c | 32 ++++++++++++++++++++++++++++++++
drivers/gpu/drm/xe/xe_netlink.c | 2 ++
2 files changed, 34 insertions(+)
diff --git a/drivers/gpu/drm/xe/xe_irq.c b/drivers/gpu/drm/xe/xe_irq.c
index 226be96e341a..1b415c8585a4 100644
--- a/drivers/gpu/drm/xe/xe_irq.c
+++ b/drivers/gpu/drm/xe/xe_irq.c
@@ -1073,6 +1073,37 @@ xe_gsc_hw_error_handler(struct xe_gt *gt, const enum hardware_error hw_err)
xe_mmio_write32(gt, GSC_HEC_CORR_UNCORR_ERR_STATUS(base, hw_err).reg, err_status);
}
+static void generate_netlink_event(struct xe_gt *gt, const enum hardware_error hw_err)
+{
+ struct xe_device *xe = gt->xe;
+ struct sk_buff *msg;
+ void *hdr;
+
+ if (!xe->xe_genl_family.module)
+ return;
+
+ msg = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_ATOMIC);
+ if (!msg) {
+ drm_dbg_driver(&xe->drm, "couldn't allocate memory for error multicast event\n");
+ return;
+ }
+
+ hdr = genlmsg_put(msg, 0, 0, &xe->xe_genl_family, 0, DRM_CMD_ERROR_EVENT);
+ if (!hdr) {
+ drm_dbg_driver(&xe->drm, "mutlicast msg buffer is small\n");
+ nlmsg_free(msg);
+ return;
+ }
+
+ genlmsg_end(msg, hdr);
+
+ genlmsg_multicast(&xe->xe_genl_family, msg, 0,
+ hw_err ?
+ DRM_GENL_MCAST_UNCORR_ERR
+ : DRM_GENL_MCAST_CORR_ERR,
+ GFP_ATOMIC);
+}
+
static void
xe_hw_error_source_handler(struct xe_gt *gt, const enum hardware_error hw_err)
{
@@ -1103,6 +1134,7 @@ xe_hw_error_source_handler(struct xe_gt *gt, const enum hardware_error hw_err)
xe_mmio_write32(gt, DEV_ERR_STAT_REG(hw_err).reg, errsrc);
+ generate_netlink_event(gt, hw_err);
out_unlock:
spin_unlock_irqrestore(>_to_xe(gt)->irq.lock, flags);
}
diff --git a/drivers/gpu/drm/xe/xe_netlink.c b/drivers/gpu/drm/xe/xe_netlink.c
index 2a6965f5cde9..0c1d51e1a9a5 100644
--- a/drivers/gpu/drm/xe/xe_netlink.c
+++ b/drivers/gpu/drm/xe/xe_netlink.c
@@ -490,6 +490,8 @@ static void xe_genl_family_init(struct xe_device *xe)
xe->xe_genl_family.ops = xe_genl_ops;
xe->xe_genl_family.n_ops = ARRAY_SIZE(xe_genl_ops);
xe->xe_genl_family.maxattr = DRM_ATTR_MAX;
+ xe->xe_genl_family.mcgrps = drm_event_mcgrps;
+ xe->xe_genl_family.n_mcgrps = ARRAY_SIZE(drm_event_mcgrps);
xe->xe_genl_family.module = THIS_MODULE;
}
--
2.25.1
next prev parent reply other threads:[~2023-05-26 16:21 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-26 16:20 [Intel-xe] [RFC 0/5] Proposal to use netlink for RAS and Telemetry across drm subsystem Aravind Iddamsetty
2023-05-26 16:20 ` Aravind Iddamsetty
2023-05-26 16:20 ` [Intel-xe] [RFC 1/5] drm/netlink: Add netlink infrastructure Aravind Iddamsetty
2023-05-26 16:20 ` Aravind Iddamsetty
2023-06-04 17:07 ` [Intel-xe] " Tomer Tayar
2023-06-04 17:07 ` Tomer Tayar
2023-06-05 17:18 ` Iddamsetty, Aravind
2023-06-05 17:18 ` Iddamsetty, Aravind
2023-06-06 14:04 ` Tomer Tayar
2023-06-06 14:04 ` Tomer Tayar
2023-06-21 6:40 ` Iddamsetty, Aravind
2023-06-21 6:40 ` Iddamsetty, Aravind
2023-05-26 16:20 ` [Intel-xe] [RFC 2/5] drm/xe/RAS: Register a genl netlink family Aravind Iddamsetty
2023-05-26 16:20 ` Aravind Iddamsetty
2023-06-04 17:09 ` [Intel-xe] " Tomer Tayar
2023-06-04 17:09 ` Tomer Tayar
2023-06-05 17:21 ` Iddamsetty, Aravind
2023-06-05 17:21 ` Iddamsetty, Aravind
2023-05-26 16:20 ` [Intel-xe] [RFC 3/5] drm/xe/RAS: Expose the error counters Aravind Iddamsetty
2023-05-26 16:20 ` Aravind Iddamsetty
2023-05-26 16:20 ` [Intel-xe] [RFC 4/5] drm/netlink: define multicast groups Aravind Iddamsetty
2023-05-26 16:20 ` Aravind Iddamsetty
2023-05-26 16:20 ` Aravind Iddamsetty [this message]
2023-05-26 16:20 ` [RFC 5/5] drm/xe/RAS: send multicast event on occurrence of an error Aravind Iddamsetty
2023-05-26 16:54 ` [Intel-xe] ✗ CI.Patch_applied: failure for Proposal to use netlink for RAS and Telemetry across drm subsystem Patchwork
2023-06-04 17:07 ` [Intel-xe] [RFC 0/5] " Tomer Tayar
2023-06-04 17:07 ` Tomer Tayar
2023-06-05 17:17 ` Iddamsetty, Aravind
2023-06-05 17:17 ` Iddamsetty, Aravind
2023-06-05 16:47 ` Alex Deucher
2023-06-05 16:47 ` Alex Deucher
2023-06-06 11:56 ` [Intel-xe] " Iddamsetty, Aravind
2023-06-06 11:56 ` Iddamsetty, Aravind
2023-06-21 17:24 ` [Intel-xe] " Sebastian Wick
2023-06-21 17:24 ` Sebastian Wick
2023-07-17 12:02 ` [Intel-xe] " Oded Gabbay
2023-07-17 12:02 ` Oded Gabbay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230526162016.428357-6-aravind.iddamsetty@intel.com \
--to=aravind.iddamsetty@intel.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.