All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: kernel test robot <lkp@intel.com>
Cc: Liang Chen <liangchen.linux@gmail.com>,
	jasowang@redhat.com, oe-kbuild-all@lists.linux.dev,
	virtualization@lists.linux-foundation.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	xuanzhuo@linux.alibaba.com, kuba@kernel.org, edumazet@google.com,
	davem@davemloft.net, pabeni@redhat.com,
	alexander.duyck@gmail.com
Subject: Re: [PATCH net-next 2/5] virtio_net: Add page_pool support to improve performance
Date: Sun, 28 May 2023 02:27:17 -0400	[thread overview]
Message-ID: <20230528022658-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <202305262334.GiFQ3wpG-lkp@intel.com>

On Sat, May 27, 2023 at 12:11:25AM +0800, kernel test robot wrote:
> Hi Liang,
> 
> kernel test robot noticed the following build errors:
> 
> [auto build test ERROR on net-next/main]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Liang-Chen/virtio_net-Add-page_pool-support-to-improve-performance/20230526-135805
> base:   net-next/main
> patch link:    https://lore.kernel.org/r/20230526054621.18371-2-liangchen.linux%40gmail.com
> patch subject: [PATCH net-next 2/5] virtio_net: Add page_pool support to improve performance
> config: x86_64-defconfig (https://download.01.org/0day-ci/archive/20230526/202305262334.GiFQ3wpG-lkp@intel.com/config)
> compiler: gcc-11 (Debian 11.3.0-12) 11.3.0
> reproduce (this is a W=1 build):
>         # https://github.com/intel-lab-lkp/linux/commit/bfba563f43bba37181d8502cb2e566c32f96ec9e
>         git remote add linux-review https://github.com/intel-lab-lkp/linux
>         git fetch --no-tags linux-review Liang-Chen/virtio_net-Add-page_pool-support-to-improve-performance/20230526-135805
>         git checkout bfba563f43bba37181d8502cb2e566c32f96ec9e
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         make W=1 O=build_dir ARCH=x86_64 olddefconfig
>         make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
> 
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202305262334.GiFQ3wpG-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
>    ld: vmlinux.o: in function `virtnet_find_vqs':
> >> virtio_net.c:(.text+0x901fb5): undefined reference to `page_pool_create'
>    ld: vmlinux.o: in function `add_recvbuf_mergeable.isra.0':
> >> virtio_net.c:(.text+0x905618): undefined reference to `page_pool_alloc_pages'
>    ld: vmlinux.o: in function `xdp_linearize_page':
>    virtio_net.c:(.text+0x906b6b): undefined reference to `page_pool_alloc_pages'
>    ld: vmlinux.o: in function `mergeable_xdp_get_buf.isra.0':
>    virtio_net.c:(.text+0x90728f): undefined reference to `page_pool_alloc_pages'


you need to tweak Kconfig to select PAGE_POOL I think.

> -- 
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki


WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: kernel test robot <lkp@intel.com>
Cc: xuanzhuo@linux.alibaba.com, oe-kbuild-all@lists.linux.dev,
	linux-kernel@vger.kernel.org, alexander.duyck@gmail.com,
	virtualization@lists.linux-foundation.org, edumazet@google.com,
	netdev@vger.kernel.org, kuba@kernel.org, pabeni@redhat.com,
	davem@davemloft.net
Subject: Re: [PATCH net-next 2/5] virtio_net: Add page_pool support to improve performance
Date: Sun, 28 May 2023 02:27:17 -0400	[thread overview]
Message-ID: <20230528022658-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <202305262334.GiFQ3wpG-lkp@intel.com>

On Sat, May 27, 2023 at 12:11:25AM +0800, kernel test robot wrote:
> Hi Liang,
> 
> kernel test robot noticed the following build errors:
> 
> [auto build test ERROR on net-next/main]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Liang-Chen/virtio_net-Add-page_pool-support-to-improve-performance/20230526-135805
> base:   net-next/main
> patch link:    https://lore.kernel.org/r/20230526054621.18371-2-liangchen.linux%40gmail.com
> patch subject: [PATCH net-next 2/5] virtio_net: Add page_pool support to improve performance
> config: x86_64-defconfig (https://download.01.org/0day-ci/archive/20230526/202305262334.GiFQ3wpG-lkp@intel.com/config)
> compiler: gcc-11 (Debian 11.3.0-12) 11.3.0
> reproduce (this is a W=1 build):
>         # https://github.com/intel-lab-lkp/linux/commit/bfba563f43bba37181d8502cb2e566c32f96ec9e
>         git remote add linux-review https://github.com/intel-lab-lkp/linux
>         git fetch --no-tags linux-review Liang-Chen/virtio_net-Add-page_pool-support-to-improve-performance/20230526-135805
>         git checkout bfba563f43bba37181d8502cb2e566c32f96ec9e
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         make W=1 O=build_dir ARCH=x86_64 olddefconfig
>         make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
> 
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202305262334.GiFQ3wpG-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
>    ld: vmlinux.o: in function `virtnet_find_vqs':
> >> virtio_net.c:(.text+0x901fb5): undefined reference to `page_pool_create'
>    ld: vmlinux.o: in function `add_recvbuf_mergeable.isra.0':
> >> virtio_net.c:(.text+0x905618): undefined reference to `page_pool_alloc_pages'
>    ld: vmlinux.o: in function `xdp_linearize_page':
>    virtio_net.c:(.text+0x906b6b): undefined reference to `page_pool_alloc_pages'
>    ld: vmlinux.o: in function `mergeable_xdp_get_buf.isra.0':
>    virtio_net.c:(.text+0x90728f): undefined reference to `page_pool_alloc_pages'


you need to tweak Kconfig to select PAGE_POOL I think.

> -- 
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

  reply	other threads:[~2023-05-28  6:27 UTC|newest]

Thread overview: 101+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-26  5:46 [PATCH net-next 1/5] virtio_net: Fix an unsafe reference to the page chain Liang Chen
2023-05-26  5:46 ` Liang Chen
2023-05-26  5:46 ` [PATCH net-next 2/5] virtio_net: Add page_pool support to improve performance Liang Chen
2023-05-26  5:46   ` Liang Chen
2023-05-26  6:50   ` Jason Wang
2023-05-26  6:50     ` Jason Wang
2023-05-27 12:35     ` Liang Chen
2023-05-27 12:35       ` Liang Chen
2023-05-28  6:40       ` Michael S. Tsirkin
2023-05-28  6:40         ` Michael S. Tsirkin
2023-05-29  7:28         ` Liang Chen
2023-05-29  7:28           ` Liang Chen
2023-05-31  3:10           ` Xuan Zhuo
2023-05-31  3:10             ` Xuan Zhuo
2023-06-07  9:11             ` Liang Chen
2023-06-07  9:11               ` Liang Chen
2023-06-07  9:33               ` Xuan Zhuo
2023-06-07  9:33                 ` Xuan Zhuo
2023-05-26 16:11   ` kernel test robot
2023-05-26 16:11     ` kernel test robot
2023-05-28  6:27     ` Michael S. Tsirkin [this message]
2023-05-28  6:27       ` Michael S. Tsirkin
2023-05-29  7:28       ` Liang Chen
2023-05-29  7:28         ` Liang Chen
2023-05-28  6:20   ` Michael S. Tsirkin
2023-05-28  6:20     ` Michael S. Tsirkin
2023-05-29  7:27     ` Liang Chen
2023-05-29  7:27       ` Liang Chen
2023-05-29  9:55       ` Michael S. Tsirkin
2023-05-29  9:55         ` Michael S. Tsirkin
2023-05-30  1:19         ` Liang Chen
2023-05-30  1:19           ` Liang Chen
2023-06-07  9:08           ` Liang Chen
2023-06-07  9:08             ` Liang Chen
2023-06-07  9:35             ` Xuan Zhuo
2023-06-07  9:35               ` Xuan Zhuo
2023-06-07 13:58               ` Liang Chen
2023-06-07 13:58                 ` Liang Chen
2023-06-07 20:17             ` Michael S. Tsirkin
2023-06-07 20:17               ` Michael S. Tsirkin
2023-06-08  0:38               ` Jason Wang
2023-06-08  0:38                 ` Jason Wang
2023-06-08  3:54                 ` Xuan Zhuo
2023-06-08  3:54                   ` Xuan Zhuo
2023-06-09  2:57                 ` Liang Chen
2023-06-09  2:57                   ` Liang Chen
2023-07-05  5:41                   ` Liang Chen
2023-07-05  5:41                     ` Liang Chen
2023-07-05  6:04                     ` Jason Wang
2023-07-05  6:04                       ` Jason Wang
2023-07-06  1:01                       ` Liang Chen
2023-07-06  1:01                         ` Liang Chen
2023-06-09  2:57               ` Liang Chen
2023-06-09  2:57                 ` Liang Chen
2023-11-29 14:50   ` Zhu Yanjun
2023-11-29 14:59     ` Michael S. Tsirkin
2023-11-29 15:22       ` Zhu Yanjun
2023-11-29 15:29         ` Zhu Yanjun
2023-11-30  2:34           ` Xuan Zhuo
2023-11-30  5:30             ` Zhu Yanjun
2023-12-01  1:38               ` Xuan Zhuo
2023-12-04  5:24                 ` Zhu Yanjun
2023-11-30  7:17   ` Zhu Yanjun
2023-05-26  5:46 ` [PATCH net-next 3/5] virtio_net: Add page pool fragmentation support Liang Chen
2023-05-26  5:46   ` Liang Chen
2023-05-26  8:29   ` Horatiu Vultur
2023-05-27 12:36     ` Liang Chen
2023-05-27 12:36       ` Liang Chen
2023-05-26 17:44   ` kernel test robot
2023-05-26 17:44     ` kernel test robot
2023-05-28  6:25   ` Michael S. Tsirkin
2023-05-28  6:25     ` Michael S. Tsirkin
2023-05-29  7:29     ` Liang Chen
2023-05-29  7:29       ` Liang Chen
2023-05-29  1:33   ` Yunsheng Lin
2023-05-29  7:30     ` Liang Chen
2023-05-29  7:30       ` Liang Chen
2023-05-26  5:46 ` [PATCH net-next 4/5] virtio_ring: Introduce DMA pre-handler Liang Chen
2023-05-26  5:46   ` Liang Chen
2023-05-26  6:57   ` Jason Wang
2023-05-26  6:57     ` Jason Wang
2023-05-26  5:46 ` [PATCH net-next 5/5] virtio_net: Implement " Liang Chen
2023-05-26  5:46   ` Liang Chen
2023-05-26  7:06   ` Jason Wang
2023-05-26  7:06     ` Jason Wang
2023-05-27 12:35     ` Liang Chen
2023-05-27 12:35       ` Liang Chen
2023-05-26 17:34   ` kernel test robot
2023-05-26 17:34     ` kernel test robot
2023-05-26  6:38 ` [PATCH net-next 1/5] virtio_net: Fix an unsafe reference to the page chain Jason Wang
2023-05-26  6:38   ` Jason Wang
2023-05-27 12:33   ` Liang Chen
2023-05-27 12:33     ` Liang Chen
2023-05-28  6:29   ` Michael S. Tsirkin
2023-05-28  6:29     ` Michael S. Tsirkin
2023-05-29  7:25     ` Liang Chen
2023-05-29  7:25       ` Liang Chen
2023-05-28  6:16 ` Michael S. Tsirkin
2023-05-28  6:16   ` Michael S. Tsirkin
2023-05-29  7:25   ` Liang Chen
2023-05-29  7:25     ` Liang Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230528022658-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=alexander.duyck@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=jasowang@redhat.com \
    --cc=kuba@kernel.org \
    --cc=liangchen.linux@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=pabeni@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=xuanzhuo@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.