All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luca Ceresoli <luca.ceresoli@bootlin.com>
To: Jun Li <jun.li@nxp.com>
Cc: Francesco Dolcini <francesco@dolcini.it>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"festevam@gmail.com" <festevam@gmail.com>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	dl-linux-imx <linux-imx@nxp.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Francesco Dolcini <francesco.dolcini@toradex.com>,
	Xu Yang <xu.yang_2@nxp.com>
Subject: Re: [PATCH v2 2/3] usb: chipidea: imx: support disabling runtime-pm
Date: Mon, 29 May 2023 12:18:25 +0200	[thread overview]
Message-ID: <20230529121825.71e9b6d6@booty> (raw)
In-Reply-To: <20230508151756.785ec07e@booty>

Hello Jun,

On Mon, 8 May 2023 15:17:56 +0200
Luca Ceresoli <luca.ceresoli@bootlin.com> wrote:

> Hello Jun, Francesco,
> 
> On Mon, 8 May 2023 13:17:11 +0200
> Francesco Dolcini <francesco@dolcini.it> wrote:
> 
> > On Sat, May 06, 2023 at 09:02:39AM +0000, Jun Li wrote:  
> > > > -----Original Message-----
> > > > From: Francesco Dolcini <francesco@dolcini.it>
> > > > Sent: Friday, May 5, 2023 7:00 PM
> > > > To: Luca Ceresoli <luca.ceresoli@bootlin.com>; Jun Li <jun.li@nxp.com>
> > > > Cc: Francesco Dolcini <francesco@dolcini.it>; devicetree@vger.kernel.org;
> > > > festevam@gmail.com; gregkh@linuxfoundation.org; kernel@pengutronix.de;
> > > > linux-arm-kernel@lists.infradead.org; dl-linux-imx <linux-imx@nxp.com>;
> > > > linux-kernel@vger.kernel.org; linux-usb@vger.kernel.org;
> > > > peter.chen@nxp.com; robh+dt@kernel.org; s.hauer@pengutronix.de;
> > > > shawnguo@kernel.org; Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>;
> > > > Francesco Dolcini <francesco.dolcini@toradex.com>
> > > > Subject: Re: [PATCH v2 2/3] usb: chipidea: imx: support disabling runtime-pm
> > > > 
> > > > On Fri, May 05, 2023 at 12:06:18PM +0200, Luca Ceresoli wrote:    
> > > > > On Fri, 5 May 2023 09:49:16 +0000
> > > > > Jun Li <jun.li@nxp.com> wrote:    
> > > > > > Is your board design similar like Francesco's as below?    
> > > > >
> > > > > Possibly, but I'm afraid I can't say: I am using the Toradex Colibri
> > > > > i.MX6ULL SoM, whose schematics are not public.    
> > > > 
> > > > I can confirm that it's the same.    
> > > 
> > > Thanks Francesco for the confirmation, had a check with design team,
> > > there is no status bit which can be used to judge the VDD_USB_CAP is
> > > powered or not, so we have to add a board level dts property to tell
> > > this usb phy driver to bypass MXS_PHY_DISCONNECT_LINE_WITHOUT_VBUS.
> > > 
> > > Before send a formal patch, I want to confirm this should work for your
> > > HW design, like below simple hack:    
> > 
> > Thanks Li Jun, I tested it with v6.3.1 kernel and it's all good.
> > I would be happy to test the patch as soon as you send it.  
> 
> Thanks Jun, it works here as well, on 6.1.27!

Have you managed to make progress on the patch after Francesco's and my
tests?

As I see it, a proper fix for mainline could be as simple as a new DT
property to describe this specific hardware configuration and a patch
to ignore the flag when the property is present. Is my understanding
correct?

Best regards,
Luca

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

WARNING: multiple messages have this Message-ID (diff)
From: Luca Ceresoli <luca.ceresoli@bootlin.com>
To: Jun Li <jun.li@nxp.com>
Cc: Francesco Dolcini <francesco@dolcini.it>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"festevam@gmail.com" <festevam@gmail.com>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	dl-linux-imx <linux-imx@nxp.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Francesco Dolcini <francesco.dolcini@toradex.com>,
	Xu Yang <xu.yang_2@nxp.com>
Subject: Re: [PATCH v2 2/3] usb: chipidea: imx: support disabling runtime-pm
Date: Mon, 29 May 2023 12:18:25 +0200	[thread overview]
Message-ID: <20230529121825.71e9b6d6@booty> (raw)
In-Reply-To: <20230508151756.785ec07e@booty>

Hello Jun,

On Mon, 8 May 2023 15:17:56 +0200
Luca Ceresoli <luca.ceresoli@bootlin.com> wrote:

> Hello Jun, Francesco,
> 
> On Mon, 8 May 2023 13:17:11 +0200
> Francesco Dolcini <francesco@dolcini.it> wrote:
> 
> > On Sat, May 06, 2023 at 09:02:39AM +0000, Jun Li wrote:  
> > > > -----Original Message-----
> > > > From: Francesco Dolcini <francesco@dolcini.it>
> > > > Sent: Friday, May 5, 2023 7:00 PM
> > > > To: Luca Ceresoli <luca.ceresoli@bootlin.com>; Jun Li <jun.li@nxp.com>
> > > > Cc: Francesco Dolcini <francesco@dolcini.it>; devicetree@vger.kernel.org;
> > > > festevam@gmail.com; gregkh@linuxfoundation.org; kernel@pengutronix.de;
> > > > linux-arm-kernel@lists.infradead.org; dl-linux-imx <linux-imx@nxp.com>;
> > > > linux-kernel@vger.kernel.org; linux-usb@vger.kernel.org;
> > > > peter.chen@nxp.com; robh+dt@kernel.org; s.hauer@pengutronix.de;
> > > > shawnguo@kernel.org; Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>;
> > > > Francesco Dolcini <francesco.dolcini@toradex.com>
> > > > Subject: Re: [PATCH v2 2/3] usb: chipidea: imx: support disabling runtime-pm
> > > > 
> > > > On Fri, May 05, 2023 at 12:06:18PM +0200, Luca Ceresoli wrote:    
> > > > > On Fri, 5 May 2023 09:49:16 +0000
> > > > > Jun Li <jun.li@nxp.com> wrote:    
> > > > > > Is your board design similar like Francesco's as below?    
> > > > >
> > > > > Possibly, but I'm afraid I can't say: I am using the Toradex Colibri
> > > > > i.MX6ULL SoM, whose schematics are not public.    
> > > > 
> > > > I can confirm that it's the same.    
> > > 
> > > Thanks Francesco for the confirmation, had a check with design team,
> > > there is no status bit which can be used to judge the VDD_USB_CAP is
> > > powered or not, so we have to add a board level dts property to tell
> > > this usb phy driver to bypass MXS_PHY_DISCONNECT_LINE_WITHOUT_VBUS.
> > > 
> > > Before send a formal patch, I want to confirm this should work for your
> > > HW design, like below simple hack:    
> > 
> > Thanks Li Jun, I tested it with v6.3.1 kernel and it's all good.
> > I would be happy to test the patch as soon as you send it.  
> 
> Thanks Jun, it works here as well, on 6.1.27!

Have you managed to make progress on the patch after Francesco's and my
tests?

As I see it, a proper fix for mainline could be as simple as a new DT
property to describe this specific hardware configuration and a patch
to ignore the flag when the property is present. Is my understanding
correct?

Best regards,
Luca

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-05-29 10:18 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-14 15:18 [PATCH v2 1/3] dt-bindings: usb: ci-hdrc-usb2: add property disable-runtime-pm Philippe Schenker
2020-07-14 15:18 ` [PATCH v2 2/3] usb: chipidea: imx: support disabling runtime-pm Philippe Schenker
2020-07-14 15:18   ` Philippe Schenker
2020-07-15  0:51   ` Peter Chen
2020-07-15  0:51     ` Peter Chen
2020-07-15 10:23     ` Philippe Schenker
2020-07-15 10:23       ` Philippe Schenker
2020-07-20  3:44       ` Peter Chen
2020-07-20  3:44         ` Peter Chen
2020-07-20  7:51         ` Philippe Schenker
2020-07-20  7:51           ` Philippe Schenker
2020-07-20  8:06           ` Peter Chen
2020-07-20  8:06             ` Peter Chen
2020-07-20 10:10             ` Philippe Schenker
2020-07-20 10:10               ` Philippe Schenker
2023-05-04 16:23               ` Luca Ceresoli
2023-05-04 16:23                 ` Luca Ceresoli
2023-05-04 16:50                 ` Francesco Dolcini
2023-05-04 16:50                   ` Francesco Dolcini
2023-05-05  9:23                   ` Luca Ceresoli
2023-05-05  9:23                     ` Luca Ceresoli
2023-05-05 10:58                     ` Francesco Dolcini
2023-05-05 10:58                       ` Francesco Dolcini
2023-05-05  9:49                   ` Jun Li
2023-05-05  9:49                     ` Jun Li
2023-05-05 10:06                     ` Luca Ceresoli
2023-05-05 10:06                       ` Luca Ceresoli
2023-05-05 11:00                       ` Francesco Dolcini
2023-05-05 11:00                         ` Francesco Dolcini
2023-05-06  9:02                         ` Jun Li
2023-05-06  9:02                           ` Jun Li
2023-05-08 11:17                           ` Francesco Dolcini
2023-05-08 11:53                             ` Jun Li
2023-05-08 14:35                               ` Francesco Dolcini
2023-05-08 13:17                             ` Luca Ceresoli
2023-05-29 10:18                               ` Luca Ceresoli [this message]
2023-05-29 10:18                                 ` Luca Ceresoli
2023-05-30 11:22                                 ` Jun Li
2023-05-30 11:22                                   ` Jun Li
2023-07-06 10:23                                   ` Francesco Dolcini
2023-07-06 10:23                                     ` Francesco Dolcini
2023-07-17 16:45                                     ` Luca Ceresoli
2023-07-17 16:45                                       ` Luca Ceresoli
2023-07-18  8:14                                       ` Francesco Dolcini
2023-07-18  8:14                                         ` Francesco Dolcini
2023-07-18  8:31                                       ` [EXT] " Xu Yang
2023-07-18  8:31                                         ` Xu Yang
2023-07-18 12:25                                         ` Luca Ceresoli
2023-07-18 12:25                                           ` Luca Ceresoli
2023-07-19 11:23                                           ` Xu Yang
2023-07-19 11:23                                             ` Xu Yang
2023-07-19 16:48                                             ` Luca Ceresoli
2023-07-19 16:48                                               ` Luca Ceresoli
2023-07-20 10:13                                               ` Xu Yang
2023-07-20 10:13                                                 ` Xu Yang
2023-07-20 12:49                                                 ` Luca Ceresoli
2023-07-20 12:49                                                   ` Luca Ceresoli
2023-07-21  2:06                                                   ` Xu Yang
2023-07-21  2:06                                                     ` Xu Yang
     [not found]                                                     ` <20230721232750.0aea6e0f@booty>
     [not found]                                                       ` <DB7PR04MB450517AD9F25F47320835A5B8C03A@DB7PR04MB4505.eurprd04.prod.outlook.com>
2023-09-29 13:37                                                         ` Luca Ceresoli
2023-10-10 10:52                                                           ` Xu Yang
2023-10-10 10:52                                                             ` Xu Yang
2020-07-14 15:18 ` [PATCH v2 3/3] ARM: dts: colibri-imx6ull: disable runtime pm Philippe Schenker
2020-07-14 15:18   ` Philippe Schenker
2020-07-16 19:24 ` [PATCH v2 1/3] dt-bindings: usb: ci-hdrc-usb2: add property disable-runtime-pm Rob Herring
2020-07-17  2:31   ` Peter Chen
2020-07-17 14:14     ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230529121825.71e9b6d6@booty \
    --to=luca.ceresoli@bootlin.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=francesco.dolcini@toradex.com \
    --cc=francesco@dolcini.it \
    --cc=gregkh@linuxfoundation.org \
    --cc=jun.li@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=xu.yang_2@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.